)]}'
{"cinder/tests/unit/volume/drivers/test_vrtshyperscale.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"323ec608bcfb84595d5c0cca95c9b70da9ff0409","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from cinder.tests.unit import fake_volume"},{"line_number":22,"context_line":"from cinder.volume import configuration as conf"},{"line_number":23,"context_line":"from cinder.volume.drivers.veritas import vrtshyperscale as vrts"},{"line_number":24,"context_line":"from cinder.volume.drivers.veritas import exception as v_exception"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FakeDb(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_d1fc2640","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":66},"updated":"2019-05-03 20:40:50.000000000","message":"should come before vrtshyperscale import","commit_id":"1505f657162acc3bfba9436ce5876c6366ec0783"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cbb1d8eb324c6763e6b5c024d1704f13caee445d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from cinder.tests.unit import fake_volume"},{"line_number":22,"context_line":"from cinder.volume import configuration as conf"},{"line_number":23,"context_line":"from cinder.volume.drivers.veritas import vrtshyperscale as vrts"},{"line_number":24,"context_line":"from cinder.volume.drivers.veritas import exception as v_exception"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class FakeDb(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_d3cdf25d","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":66},"in_reply_to":"dfbec78f_d1fc2640","updated":"2019-05-06 14:02:38.000000000","message":"Done","commit_id":"1505f657162acc3bfba9436ce5876c6366ec0783"}],"cinder/volume/drivers/veritas/exception.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"323ec608bcfb84595d5c0cca95c9b70da9ff0409","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"from cinder import exception"},{"line_number":3,"context_line":"from cinder.i18n import _"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_f1e04a99","line":1,"updated":"2019-05-03 20:40:50.000000000","message":"IMO these movements should follow a consistency pattern.\nfor the gpfs driver[1] it is included in the main driver file and here we create a new one (i understand the number of exceptions are more here).\nEither we can move every exception in the driver (which i\u0027m not a fan of) or create separate exception files for every driver.\n\n[1] https://review.opendev.org/#/c/656977/1/cinder/volume/drivers/ibm/gpfs.py","commit_id":"1505f657162acc3bfba9436ce5876c6366ec0783"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cbb1d8eb324c6763e6b5c024d1704f13caee445d","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"from cinder import exception"},{"line_number":3,"context_line":"from cinder.i18n import _"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dfbec78f_f3e6f6e8","line":1,"in_reply_to":"dfbec78f_f1e04a99","updated":"2019-05-06 14:02:38.000000000","message":"The difference in this patch is that we have a utility file that needs the exceptions and the driver needs the exceptions.  the driver includes the utility file, which would create a circular dependency.","commit_id":"1505f657162acc3bfba9436ce5876c6366ec0783"}]}