)]}'
{"id":"openstack%2Fcinder~658269","triplet_id":"openstack%2Fcinder~stable%2Focata~Ic746ebbac2c0f9ab66b5082d3c0bfa37830b3d94","project":"openstack/cinder","branch":"stable/ocata","topic":"rbd-physical-block-size-simple","hashtags":[],"change_id":"Ic746ebbac2c0f9ab66b5082d3c0bfa37830b3d94","subject":"RBD: Add 512e/4k disk geometry configuration","status":"ABANDONED","created":"2019-05-10 05:50:30.000000000","updated":"2019-05-10 07:48:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"98c7ccadad30fe5aa84848526ac94fb198003a3f","_number":658269,"virtual_id_number":658269,"owner":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"actions":{},"labels":{"Verified":{"all":[{"date":"2019-05-10 05:51:06.000000000","_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-10 05:51:06.000000000","updated_by":{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"},"reviewer":{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"},"state":"REVIEWER"}],"messages":[{"id":"9b8b20657c4b1baec93b242978504e21fb450a32","author":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"date":"2019-05-10 05:50:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0cb72f081925018031b58efbea5f6539bcb3d7fb","author":{"_account_id":24921,"name":"Hedvig CI","email":"openstack@hedviginc.com","username":"hedvig_ci"},"date":"2019-05-10 05:51:06.000000000","message":"Patch Set 1:\n\n* Hedvig-CI http://os-logserver.hedviginc.com/refs/changes/69/658269/1 : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"4817c31b431dd68b563486c19d7cdf7d4b3a7435","author":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"date":"2019-05-10 05:57:10.000000000","message":"Abandoned\n\nAccidentally submitted to stable/ocata instead of master. Will resubmit.","accounts_in_message":[],"_revision_number":1},{"id":"208959639d5ca8cd13f46a2888d0f29ebc1cf41a","author":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"date":"2019-05-10 07:48:22.000000000","message":"Patch Set 1:\n\nNew change submitted at https://review.opendev.org/#/c/658283/\n\nJust in case anyone finds this one and is looking for the correct one","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0472cae35b7063e7da40ae31b2e5e0ec54234dec","revisions":{"0472cae35b7063e7da40ae31b2e5e0ec54234dec":{"kind":"REWORK","_number":1,"created":"2019-05-10 05:50:30.000000000","uploader":{"_account_id":21107,"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","username":"lathiat"},"ref":"refs/changes/69/658269/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/69/658269/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/69/658269/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/69/658269/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/69/658269/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/69/658269/1"}}},"commit":{"parents":[{"commit":"21a735e04c7d00fc88a0821e0bd949b48de4a404","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/21a735e04c7d00fc88a0821e0bd949b48de4a404"}]}],"author":{"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","date":"2019-05-09 09:35:03.000000000","tz":480},"committer":{"name":"Trent Lloyd","email":"trent.lloyd@canonical.com","date":"2019-05-10 05:50:27.000000000","tz":480},"subject":"RBD: Add 512e/4k disk geometry configuration","message":"RBD: Add 512e/4k disk geometry configuration\n\nAdd support for configuring the physical_block_size and\nlogical_block_size hints of Cinder RBD volumes using the new\n\u0027disk_geometry\u0027 configuration option.\n\nCeph performs much better when I/O is 4k-aligned otherwise it has to\nread the 4k from disk, modify and write it again. Linux guests generally\nsubmit 4k-aligned I/O, however Windows guests generally submit\n512b-aligned I/O. When hinted with physical_block_size\u003d4096 Windows\nguests will switch to submitting most I/O as 4k-aligned based on both\ntesting and information from Microsoft KB 2510009.\n\nThe infrastructure to configure this inside of nova/libvirt already\nexists, however previously only the iSCSI/SolidFire driver set this\nvalue. This extends the RBD driver to also handle this.\n\nThe SolidFire driver stores the current configuration value in the\ndatabase against the volume\u0027s provider_geometry database field. That has\nthe effect of causing the configuration option to only apply to new\nvolumes and is then difficult to change the configuration after the\nfact. Instead of storing it in the database, here we simply reference\nthe active configuration directly during volume connection so that\na configuration change is reflected next time a volume is used.\n\nDefault for new versions is disk_geometry\u003d512e, backports should\nprobably adjust this to 512 so as not to change default behaviour\nunexpectedly although I do not expect disk_geometry\u003d512e to cause any\ncompatibility issues.\n\nChange-Id: Ic746ebbac2c0f9ab66b5082d3c0bfa37830b3d94\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/0472cae35b7063e7da40ae31b2e5e0ec54234dec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/0472cae35b7063e7da40ae31b2e5e0ec54234dec"}]},"branch":"refs/heads/stable/ocata"}},"requirements":[],"submit_records":[],"submit_requirements":[]}