)]}'
{"tox.ini":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1346d8418534845237153835bb20f59deb37630d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"basepython \u003d python3"},{"line_number":36,"context_line":"whitelist_externals \u003d rm"},{"line_number":37,"context_line":"deps \u003d"},{"line_number":38,"context_line":"    {[testenv]deps}"},{"line_number":39,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":40,"context_line":"commands \u003d"},{"line_number":41,"context_line":"    rm -rf api-ref/build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dfbec78f_2ae57709","line":38,"updated":"2019-05-13 20:38:04.000000000","message":"This adds a lot of dependencies that were not previously installed. Maybe we should fix up the constraint arg to be in the install_command instead, then this environment would not need to change.","commit_id":"6ef75a6be2c29e9d0f327776f85a9edec996e147"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"42e2639dba528801c09e6a1af69dcb949be79444","unresolved":false,"context_lines":[{"line_number":35,"context_line":"basepython \u003d python3"},{"line_number":36,"context_line":"whitelist_externals \u003d rm"},{"line_number":37,"context_line":"deps \u003d"},{"line_number":38,"context_line":"    {[testenv]deps}"},{"line_number":39,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":40,"context_line":"commands \u003d"},{"line_number":41,"context_line":"    rm -rf api-ref/build"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dfbec78f_2a26d716","line":38,"in_reply_to":"dfbec78f_2ae57709","updated":"2019-05-13 20:52:34.000000000","message":"its just installing them earlier. as this tox.ini does not specify skip_install\u003dTrue, the cinder egg installation will actually pull in runtime requirements anyway, just later.","commit_id":"6ef75a6be2c29e9d0f327776f85a9edec996e147"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"42e2639dba528801c09e6a1af69dcb949be79444","unresolved":false,"context_lines":[{"line_number":154,"context_line":"[testenv:bandit]"},{"line_number":155,"context_line":"basepython \u003d python3"},{"line_number":156,"context_line":"deps \u003d"},{"line_number":157,"context_line":"    {[testenv]deps}"},{"line_number":158,"context_line":"commands \u003d bandit -r cinder -n5 -x tests -ll"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"[testenv:bandit-baseline]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dfbec78f_8a7a63ee","line":157,"updated":"2019-05-13 20:52:34.000000000","message":"I can fix this.","commit_id":"6ef75a6be2c29e9d0f327776f85a9edec996e147"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1346d8418534845237153835bb20f59deb37630d","unresolved":false,"context_lines":[{"line_number":154,"context_line":"[testenv:bandit]"},{"line_number":155,"context_line":"basepython \u003d python3"},{"line_number":156,"context_line":"deps \u003d"},{"line_number":157,"context_line":"    {[testenv]deps}"},{"line_number":158,"context_line":"commands \u003d bandit -r cinder -n5 -x tests -ll"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"[testenv:bandit-baseline]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"dfbec78f_aaa727bd","line":157,"updated":"2019-05-13 20:38:04.000000000","message":"Same with this one.","commit_id":"6ef75a6be2c29e9d0f327776f85a9edec996e147"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"73ff0c0ef80f2cf71d244124568e3d2255f19d4b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"basepython \u003d python3"},{"line_number":37,"context_line":"whitelist_externals \u003d rm"},{"line_number":38,"context_line":"deps \u003d"},{"line_number":39,"context_line":"    {[testenv]deps}"},{"line_number":40,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":41,"context_line":"commands \u003d"},{"line_number":42,"context_line":"    rm -rf api-ref/build"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7faddb67_d1571e26","line":39,"updated":"2019-08-10 08:35:27.000000000","message":"this is wrong, this adds test-requirements etc.","commit_id":"06e4d0a2adf6304f9612fd6522eb7604b50bcb1e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"73ff0c0ef80f2cf71d244124568e3d2255f19d4b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"[testenv:docs]"},{"line_number":136,"context_line":"basepython \u003d python3"},{"line_number":137,"context_line":"deps \u003d"},{"line_number":138,"context_line":"    {[testenv]deps}"},{"line_number":139,"context_line":"    -r{toxinidir}/doc/requirements.txt"},{"line_number":140,"context_line":"commands \u003d"},{"line_number":141,"context_line":"    doc8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7faddb67_b132a20e","line":138,"updated":"2019-08-10 08:35:27.000000000","message":"same problem - installs too much","commit_id":"06e4d0a2adf6304f9612fd6522eb7604b50bcb1e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1718b6b5ef31ca20ca376386b7ea2ffb1c717f1f","unresolved":false,"context_lines":[{"line_number":154,"context_line":"[testenv:bandit]"},{"line_number":155,"context_line":"basepython \u003d python3"},{"line_number":156,"context_line":"deps \u003d"},{"line_number":157,"context_line":"    bandit\u003e\u003d1.1.0"},{"line_number":158,"context_line":"commands \u003d bandit -r cinder -n5 -x cinder/tests/* -ll"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"[testenv:bandit-baseline]"}],"source_content_type":"text/x-properties","patch_set":4,"id":"7faddb67_71150a49","line":157,"updated":"2019-08-10 08:48:45.000000000","message":"shouldn\u0027t we constrain bandit with an upper limit ? That broke testing a few weeks ago where a new version introduced new tests.","commit_id":"06e4d0a2adf6304f9612fd6522eb7604b50bcb1e"}]}
