)]}'
{"cinder/tests/unit/api/contrib/test_quotas.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8906db57a4679ffe4dc8243bf6988f8a39614b79","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def make_body(root\u003dTrue, gigabytes\u003d1000, snapshots\u003d10,"},{"line_number":45,"context_line":"              volumes\u003d10, backups\u003d10, backup_gigabytes\u003d1000,"},{"line_number":46,"context_line":"              tenant_id\u003dfake.PROJECT_ID, per_volume_gigabytes\u003d-1, groups\u003d10,"},{"line_number":47,"context_line":"              default\u003dFalse):"},{"line_number":48,"context_line":"    resources \u003d {\u0027gigabytes\u0027: gigabytes,"},{"line_number":49,"context_line":"                 \u0027snapshots\u0027: snapshots,"},{"line_number":50,"context_line":"                 \u0027volumes\u0027: volumes,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_fd3948f1","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":21},"updated":"2019-05-29 17:36:52.000000000","message":"What is \"default\"? If something is a default, shouldn\u0027t it be True?\n\nWould this be more accurate to name it \"subproject\u003dFalse\"?","commit_id":"ef89e7a24d58183f48711841576bd61110d180c8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"03661dcc65fea158f06677953427f634d87a3cd1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def make_body(root\u003dTrue, gigabytes\u003d1000, snapshots\u003d10,"},{"line_number":45,"context_line":"              volumes\u003d10, backups\u003d10, backup_gigabytes\u003d1000,"},{"line_number":46,"context_line":"              tenant_id\u003dfake.PROJECT_ID, per_volume_gigabytes\u003d-1, groups\u003d10,"},{"line_number":47,"context_line":"              default\u003dFalse):"},{"line_number":48,"context_line":"    resources \u003d {\u0027gigabytes\u0027: gigabytes,"},{"line_number":49,"context_line":"                 \u0027snapshots\u0027: snapshots,"},{"line_number":50,"context_line":"                 \u0027volumes\u0027: volumes,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_006f13c5","line":47,"range":{"start_line":47,"start_character":14,"end_line":47,"end_character":21},"in_reply_to":"bfb3d3c7_fd3948f1","updated":"2019-05-29 17:52:05.000000000","message":"agreed. subproject is better\nDone","commit_id":"ef89e7a24d58183f48711841576bd61110d180c8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8906db57a4679ffe4dc8243bf6988f8a39614b79","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    volume_types \u003d db.volume_type_get_all(context.get_admin_context())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for volume_type in volume_types:"},{"line_number":59,"context_line":"        # default values for subproject are 0"},{"line_number":60,"context_line":"        if default:"},{"line_number":61,"context_line":"            resources[\u0027gigabytes_\u0027 + volume_type] \u003d 0"},{"line_number":62,"context_line":"            resources[\u0027snapshots_\u0027 + volume_type] \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_5d52d43c","line":59,"updated":"2019-05-29 17:36:52.000000000","message":"This could really be simplified to:\n\n    quota \u003d 0 if default else -1\n    resources[\u0027gigabytes_\u0027 + volume_type] \u003d quota\n    resources[\u0027snapshots_\u0027 + volume_type] \u003d quota\n    resources[\u0027volumes_\u0027 + volume_type] \u003d quota","commit_id":"ef89e7a24d58183f48711841576bd61110d180c8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"03661dcc65fea158f06677953427f634d87a3cd1","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    volume_types \u003d db.volume_type_get_all(context.get_admin_context())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    for volume_type in volume_types:"},{"line_number":59,"context_line":"        # default values for subproject are 0"},{"line_number":60,"context_line":"        if default:"},{"line_number":61,"context_line":"            resources[\u0027gigabytes_\u0027 + volume_type] \u003d 0"},{"line_number":62,"context_line":"            resources[\u0027snapshots_\u0027 + volume_type] \u003d 0"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_a06727b7","line":59,"in_reply_to":"bfb3d3c7_5d52d43c","updated":"2019-05-29 17:52:05.000000000","message":"Done","commit_id":"ef89e7a24d58183f48711841576bd61110d180c8"}]}