)]}'
{"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6a2f3c06591c20376a52fcc7f2817e48b2142e40","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        \"\"\""},{"line_number":581,"context_line":"        self.shares \u003d {}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        url \u003d self._strip_qb_protocol(self.configuration.quobyte_volume_url)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_78a35a9f","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":11},"updated":"2020-04-17 12:43:10.000000000","message":"Strictly speaking, without a protocol this thing isn\u0027t a URL.  I realize that you know the format of what\u0027s in there, but someone else maintaining the driver might make an assumption about it based on the variable name.  It\u0027s not a problem unless there\u0027s a place in the code where you actually *need* there to be a protocol in the string.  You might want to make a proactive run through the code to check for that.","commit_id":"674b86a5da2cfb8b294eb3296f36d5ffbb86ed4f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"e3fd6675be350c78d91de5bb1ecc31751020de97","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        \"\"\""},{"line_number":581,"context_line":"        self.shares \u003d {}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        url \u003d self._strip_qb_protocol(self.configuration.quobyte_volume_url)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_87233e56","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":11},"in_reply_to":"3f4c43b2_78a35a9f","updated":"2020-04-20 14:40:47.000000000","message":"I wonder this might be something you could do during driver\u0027s initialization, as self.configuration.quobyte_volume_url wont  change until volume service is restarted.","commit_id":"674b86a5da2cfb8b294eb3296f36d5ffbb86ed4f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"81645d4cc1021eedc78db7759af7c794b6f02192","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        \"\"\""},{"line_number":581,"context_line":"        self.shares \u003d {}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        url \u003d self._strip_qb_protocol(self.configuration.quobyte_volume_url)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1f493fa4_4b722813","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":11},"in_reply_to":"3f4c43b2_78a35a9f","updated":"2020-04-23 15:34:00.000000000","message":"Thanks for pointing that out.\nThe usage is fine although admittedly not very clean in naming.","commit_id":"674b86a5da2cfb8b294eb3296f36d5ffbb86ed4f"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"d5d58ef3f0c8fb0c454d3fe5c9a33a074b9633b5","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        \"\"\""},{"line_number":581,"context_line":"        self.shares \u003d {}"},{"line_number":582,"context_line":""},{"line_number":583,"context_line":"        url \u003d self._strip_qb_protocol(self.configuration.quobyte_volume_url)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        self.shares[url] \u003d None  # None \u003d No extra mount options."},{"line_number":586,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4c43b2_672392be","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":11},"in_reply_to":"3f4c43b2_87233e56","updated":"2020-04-20 14:53:32.000000000","message":"Anyway, this is not the focus of this patch so you can ignore my comment.","commit_id":"674b86a5da2cfb8b294eb3296f36d5ffbb86ed4f"}]}