)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6ef5a0c9cd1e443d453a90242126ee7203ecae54","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"    def clone_image(self, context, volume, image_location, image_meta,"},{"line_number":1380,"context_line":"                    image_service):"},{"line_number":1381,"context_line":"        \"\"\"Clone image directly to a volume.\"\"\""},{"line_number":1382,"context_line":"        ret \u003d self.copy_image_to_volume("},{"line_number":1383,"context_line":"            context, volume, image_service, image_meta[\u0027id\u0027])"},{"line_number":1384,"context_line":"        return (ret, True)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_185f23e3","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":11},"updated":"2019-06-04 15:09:28.000000000","message":"What is the value of \"ret\", here?","commit_id":"01bfdbd45e4e3de3306aeef174aac0591c5b56eb"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d056cbb9128ad258483b5da9d91d787a6612f4ca","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"    def clone_image(self, context, volume, image_location, image_meta,"},{"line_number":1380,"context_line":"                    image_service):"},{"line_number":1381,"context_line":"        \"\"\"Clone image directly to a volume.\"\"\""},{"line_number":1382,"context_line":"        ret \u003d self.copy_image_to_volume("},{"line_number":1383,"context_line":"            context, volume, image_service, image_meta[\u0027id\u0027])"},{"line_number":1384,"context_line":"        return (ret, True)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_309af36d","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":11},"in_reply_to":"9fb8cfa7_185f23e3","updated":"2019-06-07 22:15:44.000000000","message":"For the VMwareVcVmdkDriver, it is None. This method is inherited in VMwareVstorageObjectDriver. \n\nVMwareVstorageObjectDriver.copy_image_to_volume returns the provider_location.","commit_id":"01bfdbd45e4e3de3306aeef174aac0591c5b56eb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9308ced63ad2040f760f6de88305a2564ac512fe","unresolved":false,"context_lines":[{"line_number":1379,"context_line":"    def clone_image(self, context, volume, image_location, image_meta,"},{"line_number":1380,"context_line":"                    image_service):"},{"line_number":1381,"context_line":"        \"\"\"Clone image directly to a volume.\"\"\""},{"line_number":1382,"context_line":"        ret \u003d self.copy_image_to_volume("},{"line_number":1383,"context_line":"            context, volume, image_service, image_meta[\u0027id\u0027])"},{"line_number":1384,"context_line":"        return (ret, True)"},{"line_number":1385,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e9030dbd","line":1382,"range":{"start_line":1382,"start_character":8,"end_line":1382,"end_character":11},"in_reply_to":"9fb8cfa7_309af36d","updated":"2019-11-15 22:32:32.000000000","message":"Just want to verify that there\u0027s no point catching any exceptions here and returning (None, False) because any attempt to try a different strategy to create a volume from the image is also going to fail.  (For example, with a VMware OpenStack cloud, trying to download the image from Glance is pointless because you\u0027d be using the vmware glance_store ... is that correct?)","commit_id":"01bfdbd45e4e3de3306aeef174aac0591c5b56eb"}]}