)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f5da7cf14f47793272f624d56c272d2d358f8940","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up test requirements"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"testresources and testscenarios were added in ec40c3b6 to address an"},{"line_number":10,"context_line":"issue with oslo.db not pulling in its own requirements."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"tempest was used when we had the tempest plugin in the main cinder repo"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_82f3b909","line":9,"updated":"2019-11-27 19:41:37.000000000","message":"Apparently this is still the case.","commit_id":"d13c22c3800f0e06eb3ad9215d18a90f8005212e"}],"requirements.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"fbf9338ec763f75a965b2ce347fbec5a7e1c3484","unresolved":false,"context_lines":[{"line_number":19,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.concurrency\u003e\u003d3.26.0 # Apache-2.0"},{"line_number":21,"context_line":"oslo.context\u003e\u003d2.19.2 # Apache-2.0"},{"line_number":22,"context_line":"oslo.db\u003e\u003d4.35.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.messaging\u003e\u003d6.4.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_828412b4","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":15},"updated":"2019-11-28 10:20:32.000000000","message":"These changes look fine but any reason to not bump to an higher version?\n\nThe latest releases of the train cycle reach the version 5.0.2\n\nHowever, the \"\u003e\u003d\" will install the higher version available so it will install 5.0.2 if I\u0027m right, so looks good in the current state.\n\nhttps://github.com/openstack/oslo.db/releases\nhttps://github.com/openstack/releases/blob/master/deliverables/train/oslo.db.yaml","commit_id":"d06c52e8ae3a790eb44d27ab0ebbc71439539096"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4fac1d71bfb23b1a434e2775340a999d895f34b1","unresolved":false,"context_lines":[{"line_number":19,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":20,"context_line":"oslo.concurrency\u003e\u003d3.26.0 # Apache-2.0"},{"line_number":21,"context_line":"oslo.context\u003e\u003d2.19.2 # Apache-2.0"},{"line_number":22,"context_line":"oslo.db\u003e\u003d4.35.0 # Apache-2.0"},{"line_number":23,"context_line":"oslo.log\u003e\u003d3.36.0 # Apache-2.0"},{"line_number":24,"context_line":"oslo.messaging\u003e\u003d6.4.0 # Apache-2.0"},{"line_number":25,"context_line":"oslo.middleware\u003e\u003d3.31.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_838a6362","line":22,"range":{"start_line":22,"start_character":9,"end_line":22,"end_character":15},"in_reply_to":"3fa7e38b_828412b4","updated":"2020-01-02 20:38:34.000000000","message":"We could, but typically we don\u0027t raise the minimum requirements unless we find some issue with the older version. Then we would want to set the new minimum to whatever release introduced the bug fix or functionality that we know we need.","commit_id":"d06c52e8ae3a790eb44d27ab0ebbc71439539096"}],"test-requirements.txt":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"58c78dcea9f1f3775a09fffe6ab667480631eb86","unresolved":false,"context_lines":[{"line_number":22,"context_line":"bandit\u003d\u003d1.6.0 # Apache-2.0"},{"line_number":23,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":24,"context_line":"reno\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":25,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"}],"source_content_type":"text/plain","patch_set":6,"id":"3fa7e38b_9db002df","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"updated":"2020-01-14 08:41:42.000000000","message":"Should it be moved to doc/recuirements.txt?","commit_id":"a90970da156158f82e3f45b4d70329f6fd4cddba"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"91e4b04477b54d2b819a670949510438fe89d2ef","unresolved":false,"context_lines":[{"line_number":22,"context_line":"bandit\u003d\u003d1.6.0 # Apache-2.0"},{"line_number":23,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":24,"context_line":"reno\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":25,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"}],"source_content_type":"text/plain","patch_set":6,"id":"3fa7e38b_ac7d8e71","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"in_reply_to":"3fa7e38b_9db002df","updated":"2020-01-14 12:43:29.000000000","message":"IIRC, we are doing some things in our unit tests that require this. So it is a doc requirement, but non-doc jobs will fail without it. So rather than installing doc/requirements with everything (which would kind of defeat the purpose of having it as a separate file) it was safer to just keep it here.\n\nNow that I think about it, I believe it is the use of the doc8 linter that has an issue if this is not included.","commit_id":"a90970da156158f82e3f45b4d70329f6fd4cddba"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ab4f93832fa3184ff7b755725c5a59aa3b0f9523","unresolved":false,"context_lines":[{"line_number":22,"context_line":"bandit\u003d\u003d1.6.0 # Apache-2.0"},{"line_number":23,"context_line":"doc8\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":24,"context_line":"reno\u003e\u003d2.5.0 # Apache-2.0"},{"line_number":25,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"}],"source_content_type":"text/plain","patch_set":6,"id":"3fa7e38b_220c4539","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":8},"in_reply_to":"3fa7e38b_ac7d8e71","updated":"2020-01-14 14:10:14.000000000","message":"I didn\u0027t find any direct usages of pygments in our tests. That\u0027s why I was asking to move it to docs requirements","commit_id":"a90970da156158f82e3f45b4d70329f6fd4cddba"}]}
