)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"143ddd15d875ace360bc19cc680e633e0d18c089","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The arg name in restore_backup of backup rpcapi is volume_host, but"},{"line_number":10,"context_line":"actually we use backup.host. This is very easy to misunderstand."},{"line_number":11,"context_line":"Also, modify the host to the same host is not necessary."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3dbd21981a67bedb389ce12ac083c501073e846a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_2b9724ee","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":56},"updated":"2019-11-11 17:35:35.000000000","message":"Please provide a different patch with this change.","commit_id":"98b08f831b5873d2951feba141bbc2804387cd31"}],"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"143ddd15d875ace360bc19cc680e633e0d18c089","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        volume \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":537,"context_line":"        self._notify_about_backup_usage(context, backup, \"restore.start\")"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        backup.host \u003d self.host"},{"line_number":540,"context_line":"        backup.save()"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        expected_status \u003d [fields.VolumeStatus.RESTORING_BACKUP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_2b08848f","side":"PARENT","line":539,"updated":"2019-11-11 17:35:35.000000000","message":"-1: We should not mix 2 different changes in the same patch:\n\n- Remove unnecessary saving of host\n- Change the RPC parameter\n\nPlease send a different patch with this change and the one suggested by Hervé, and mention in the commit message why we can remove it:  Because at the API level we already use method `_get_available_backup_service_host` to select and save the host.","commit_id":"821cc703c03d62b86dc4ca6729b9d72ef650c3a0"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"48943d86b6e8db3efc7f28f6b482423cc4dc681f","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        volume \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":537,"context_line":"        self._notify_about_backup_usage(context, backup, \"restore.start\")"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"        backup.host \u003d self.host"},{"line_number":540,"context_line":"        backup.save()"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"        expected_status \u003d [fields.VolumeStatus.RESTORING_BACKUP,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6025325c","side":"PARENT","line":539,"in_reply_to":"3fa7e38b_2b08848f","updated":"2019-11-12 09:32:07.000000000","message":"Done\nAnother patch is:https://review.opendev.org/#/c/693792/","commit_id":"821cc703c03d62b86dc4ca6729b9d72ef650c3a0"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"887a31b2a53516f60d753f49a8904f26e2394b80","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self._notify_about_backup_usage(context, backup, \"create.start\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        backup.host \u003d self.host"},{"line_number":362,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":363,"context_line":"        backup.save()"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e815a49c","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":31},"updated":"2019-11-08 09:46:08.000000000","message":"Related to your changes:\n\nWhat\u0027s about this one?\nWe don\u0027t need to remove this one too?\n\nElse maybe we need to keep these assignation and maybe test through a if statement if they need to be updated, thoughts?\n\nI don\u0027t have enough background here to be sure if we need to keep or leave these assignments but maybe simply surround it with a check can keep the things more safer rather remove them.","commit_id":"98b08f831b5873d2951feba141bbc2804387cd31"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"48943d86b6e8db3efc7f28f6b482423cc4dc681f","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self._notify_about_backup_usage(context, backup, \"create.start\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        backup.host \u003d self.host"},{"line_number":362,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":363,"context_line":"        backup.save()"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_00147ee8","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":31},"in_reply_to":"3fa7e38b_e815a49c","updated":"2019-11-12 09:32:07.000000000","message":"Hi, Hervé Beraud. You can see the detail in this patch:\nhttps://review.opendev.org/#/c/693792/","commit_id":"98b08f831b5873d2951feba141bbc2804387cd31"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"143ddd15d875ace360bc19cc680e633e0d18c089","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self._notify_about_backup_usage(context, backup, \"create.start\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        backup.host \u003d self.host"},{"line_number":362,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":363,"context_line":"        backup.save()"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_cbae9080","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":31},"in_reply_to":"3fa7e38b_e815a49c","updated":"2019-11-11 17:35:35.000000000","message":"Yes, we can remove it here as well.","commit_id":"98b08f831b5873d2951feba141bbc2804387cd31"}]}