)]}'
{"cinder/tests/unit/volume/drivers/nec/test_volume.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2c91519f8f7b23152faf06c053c331be2a50bec7","unresolved":false,"context_lines":[{"line_number":999,"context_line":"        self.assertEqual(\u0027192.168.2.93:3260\u0027, portal[3])"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d618bc1e","line":1002,"range":{"start_line":1002,"start_character":8,"end_line":1002,"end_character":19},"updated":"2019-07-01 20:07:24.000000000","message":"Modifying self.vol will get messy when tests run in a different order, etc.\n\nYou want to copy this to a local \"vol\" and pass that into iscsi_initialize_connection_snapshot below rather than making changes that can impact other test methods.","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80705847eb7cabfd37576d8d67b37b809fbb7ddd","unresolved":false,"context_lines":[{"line_number":999,"context_line":"        self.assertEqual(\u0027192.168.2.93:3260\u0027, portal[3])"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_17267769","line":1002,"range":{"start_line":1002,"start_character":13,"end_line":1002,"end_character":19},"updated":"2019-06-28 06:30:59.000000000","message":"snap.id","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b5753b4767b30f7f4ea01d23f0c5f9e8368b2650","unresolved":false,"context_lines":[{"line_number":999,"context_line":"        self.assertEqual(\u0027192.168.2.93:3260\u0027, portal[3])"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_df1516e7","line":1002,"range":{"start_line":1002,"start_character":13,"end_line":1002,"end_character":19},"in_reply_to":"9fb8cfa7_17267769","updated":"2019-07-03 06:30:20.000000000","message":"Done","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b5753b4767b30f7f4ea01d23f0c5f9e8368b2650","unresolved":false,"context_lines":[{"line_number":999,"context_line":"        self.assertEqual(\u0027192.168.2.93:3260\u0027, portal[3])"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_7fd0aa2c","line":1002,"range":{"start_line":1002,"start_character":8,"end_line":1002,"end_character":19},"in_reply_to":"9fb8cfa7_d618bc1e","updated":"2019-07-03 06:30:20.000000000","message":"Done","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80705847eb7cabfd37576d8d67b37b809fbb7ddd","unresolved":false,"context_lines":[{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":1006,"context_line":"        ret \u003d self.iscsi_initialize_connection_snapshot(self.vol, connector)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_773333ac","line":1003,"range":{"start_line":1003,"start_character":8,"end_line":1003,"end_character":26},"updated":"2019-06-28 06:30:59.000000000","message":"this doesn\u0027t seem right\nIMO this should have been snap.volume_id","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b5753b4767b30f7f4ea01d23f0c5f9e8368b2650","unresolved":false,"context_lines":[{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def test_initialize_connection_snapshot(self):"},{"line_number":1002,"context_line":"        self.vol.id \u003d \"46045673-41e7-44a7-9333-02f07feab04b\""},{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":1006,"context_line":"        ret \u003d self.iscsi_initialize_connection_snapshot(self.vol, connector)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_9fd55e1e","line":1003,"range":{"start_line":1003,"start_character":8,"end_line":1003,"end_character":26},"in_reply_to":"9fb8cfa7_773333ac","updated":"2019-07-03 06:30:20.000000000","message":"Done","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"80705847eb7cabfd37576d8d67b37b809fbb7ddd","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":1006,"context_line":"        ret \u003d self.iscsi_initialize_connection_snapshot(self.vol, connector)"},{"line_number":1007,"context_line":"        self.assertIsNotNone(ret)"},{"line_number":1008,"context_line":"        self.assertEqual(\u0027iscsi\u0027, ret[\u0027driver_volume_type\u0027])"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d723ff54","line":1006,"range":{"start_line":1006,"start_character":56,"end_line":1006,"end_character":64},"updated":"2019-06-28 06:30:59.000000000","message":"a snapshot is expected here","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"b5753b4767b30f7f4ea01d23f0c5f9e8368b2650","unresolved":false,"context_lines":[{"line_number":1003,"context_line":"        self.vol.volume_id \u003d \"92dbc7f4-dbc3-4a87-aef4-d5a2ada3a9af\""},{"line_number":1004,"context_line":"        connector \u003d {\u0027initiator\u0027: \"iqn.1994-05.com.redhat:d1d8e8f23255\","},{"line_number":1005,"context_line":"                     \u0027multipath\u0027: True}"},{"line_number":1006,"context_line":"        ret \u003d self.iscsi_initialize_connection_snapshot(self.vol, connector)"},{"line_number":1007,"context_line":"        self.assertIsNotNone(ret)"},{"line_number":1008,"context_line":"        self.assertEqual(\u0027iscsi\u0027, ret[\u0027driver_volume_type\u0027])"},{"line_number":1009,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_3fda324b","line":1006,"range":{"start_line":1006,"start_character":56,"end_line":1006,"end_character":64},"in_reply_to":"9fb8cfa7_d723ff54","updated":"2019-07-03 06:30:20.000000000","message":"Done","commit_id":"713543e8507692a86d1e315451bea3975b1daf6a"}],"cinder/volume/drivers/nec/volume_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c40591fe0eb03bcf97d1d2b43c5c64ddba93502","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027nec_queryconfig_view\u0027,"},{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d1,"},{"line_number":98,"context_line":"               help\u003d\u0027Number of iSCSI portals.\u0027),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":100,"context_line":"                default\u003dTrue,"},{"line_number":101,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_e2492660","side":"PARENT","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":48},"updated":"2019-07-25 11:07:27.000000000","message":"you can\u0027t delete a config option directly, it needs to be deprecated for a release and then removed in the next","commit_id":"b415b277f265ccc75221e558e007637a3546f078"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"1d0360c9bcb38c2bd8dfdd223d9c5808c16cc632","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027nec_queryconfig_view\u0027,"},{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d1,"},{"line_number":98,"context_line":"               help\u003d\u0027Number of iSCSI portals.\u0027),"},{"line_number":99,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":100,"context_line":"                default\u003dTrue,"},{"line_number":101,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ed133265","side":"PARENT","line":98,"range":{"start_line":96,"start_character":0,"end_line":98,"end_character":48},"in_reply_to":"7faddb67_e2492660","updated":"2019-07-29 08:33:21.000000000","message":"Done","commit_id":"b415b277f265ccc75221e558e007637a3546f078"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8342be583bf55648c7637e8b11418678d2a4c809","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027nec_queryconfig_view\u0027,"},{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":99,"context_line":"                    \u0027and may be removed in the next release. \u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":101,"context_line":"                default\u003dTrue,"},{"line_number":102,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e856c006","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":64},"updated":"2019-07-29 08:43:19.000000000","message":"deprecated_for_removal\u003dTrue\nThis flag is also required for showing deprecation","commit_id":"10bf8329d1e9b9a9a2703263d6a25942d8305c83"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"280eb0bb3f4f85eb2d61cc6b422e31d9682f8555","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    cfg.BoolOpt(\u0027nec_queryconfig_view\u0027,"},{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":99,"context_line":"                    \u0027and may be removed in the next release. \u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":101,"context_line":"                default\u003dTrue,"},{"line_number":102,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9e2426c8","line":99,"range":{"start_line":96,"start_character":0,"end_line":99,"end_character":64},"in_reply_to":"7faddb67_e856c006","updated":"2019-07-29 12:15:30.000000000","message":"Done","commit_id":"10bf8329d1e9b9a9a2703263d6a25942d8305c83"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4d62de088828045071bb604ab9288b4fc9bafa9d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":99,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":100,"context_line":"                    \u0027and may be removed in the next release. \u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_7f19fa77","line":97,"updated":"2019-07-31 15:04:43.000000000","message":"What is the meaning of \"0\" for this option?  The code chooses a sensible default?\n\nIf this option is setting a limit on the number of portals, it isn\u0027t really described as such here.","commit_id":"3c122e2a3e8f12a33503290692de75f4723820f1"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"c1365929f087f1d5e836aee0e13a6e97995b56aa","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                default\u003dFalse,"},{"line_number":95,"context_line":"                help\u003d\u0027Use legacy iSMCLI command.\u0027),"},{"line_number":96,"context_line":"    cfg.IntOpt(\u0027nec_iscsi_portals_per_cont\u0027,"},{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":99,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":100,"context_line":"                    \u0027and may be removed in the next release. \u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_5e318058","line":97,"in_reply_to":"7faddb67_7f19fa77","updated":"2019-08-02 08:03:16.000000000","message":"When the option is set to 0, the driver returns all available portals.\n\nI chose 0 to balance I/O load among all available portals by default.\nIf the number is limited by default, I/O load may not be balanced.\nThe driver always selects the first N portals because it must return the same set of portals on every call.\n\nI fixed the help description.","commit_id":"3c122e2a3e8f12a33503290692de75f4723820f1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4d62de088828045071bb604ab9288b4fc9bafa9d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":99,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":100,"context_line":"                    \u0027and may be removed in the next release. \u0027),"},{"line_number":101,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":102,"context_line":"                default\u003dTrue,"},{"line_number":103,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_df102e51","line":100,"range":{"start_line":100,"start_character":60,"end_line":100,"end_character":61},"updated":"2019-07-31 15:04:43.000000000","message":"Extra space","commit_id":"3c122e2a3e8f12a33503290692de75f4723820f1"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"c1365929f087f1d5e836aee0e13a6e97995b56aa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"               default\u003d0,"},{"line_number":98,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":99,"context_line":"               help\u003d\u0027Number of iSCSI portals. This option is deprecated \u0027"},{"line_number":100,"context_line":"                    \u0027and may be removed in the next release. \u0027),"},{"line_number":101,"context_line":"    cfg.BoolOpt(\u0027nec_auto_accesscontrol\u0027,"},{"line_number":102,"context_line":"                default\u003dTrue,"},{"line_number":103,"context_line":"                help\u003d\u0027Configure access control automatically.\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_7e36bc53","line":100,"range":{"start_line":100,"start_character":60,"end_line":100,"end_character":61},"in_reply_to":"7faddb67_df102e51","updated":"2019-08-02 08:03:16.000000000","message":"Done","commit_id":"3c122e2a3e8f12a33503290692de75f4723820f1"}],"releasenotes/notes/nec-allow-more-than-4iSCSI-portals-8342defe64491f81.yaml":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"4aad72a4225c43d4189464e17f8ba32900936896","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NEC Driver: Added support of more than 4 iSCSI portals"},{"line_number":5,"context_line":"    for a node, and deprecated ``nec_iscsi_portals_per_cont``"},{"line_number":6,"context_line":"    config option. The option was used to limit number of"},{"line_number":7,"context_line":"    portals and is no longer needed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5faad753_5bad7e2f","line":7,"updated":"2019-09-10 14:59:18.000000000","message":"Please, add \u0027deprecations\u0027 section","commit_id":"03ca62f4e3957031339522af8f1f2e7f974c0acd"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"792c09e159e393770bbfe3defd5bdc86f0326b28","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    NEC Driver: Added support of more than 4 iSCSI portals"},{"line_number":5,"context_line":"    for a node, and deprecated ``nec_iscsi_portals_per_cont``"},{"line_number":6,"context_line":"    config option. The option was used to limit number of"},{"line_number":7,"context_line":"    portals and is no longer needed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5faad753_4b15959b","line":7,"in_reply_to":"5faad753_5bad7e2f","updated":"2019-09-11 12:02:51.000000000","message":"Done","commit_id":"03ca62f4e3957031339522af8f1f2e7f974c0acd"}]}