)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2ce477807aff3711c2eddb52870916800755ea57","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"            query \u003d _volume_get_query(context).filter(conditions)"},{"line_number":2293,"context_line":"            if filters:"},{"line_number":2294,"context_line":"                if \u0027host\u0027 in filters:"},{"line_number":2295,"context_line":"                    del filters[\u0027host\u0027]"},{"line_number":2296,"context_line":""},{"line_number":2297,"context_line":"                query \u003d _process_volume_filters(query, filters)"},{"line_number":2298,"context_line":"                # No volumes would match, return empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_80f4cc87","line":2295,"updated":"2019-09-11 11:14:42.000000000","message":"-1: This should raise an exception, as this is a programming error","commit_id":"036ad5ddafb324164a04c63552374cd42d2322d2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"511a78e806671cb416a6232358cdc6c240761d1a","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"            query \u003d _volume_get_query(context).filter(conditions)"},{"line_number":2293,"context_line":"            if filters:"},{"line_number":2294,"context_line":"                if \u0027host\u0027 in filters:"},{"line_number":2295,"context_line":"                    del filters[\u0027host\u0027]"},{"line_number":2296,"context_line":""},{"line_number":2297,"context_line":"                query \u003d _process_volume_filters(query, filters)"},{"line_number":2298,"context_line":"                # No volumes would match, return empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1c001066","line":2295,"in_reply_to":"3fa7e38b_3d15ea3d","updated":"2019-11-19 03:01:30.000000000","message":"Host in other filters is allowed, but here it doesn\u0027t make sense (unless the host parameter is None).\n\nIf we receive here host as a parameter and also as a filter we cannot just ignore the one in the filters, because we don\u0027t know what the caller wanted to do.\n\nThe caller must only pass the host once, and if it\u0027s passed in both places it most likely means that it\u0027s a programming error.","commit_id":"036ad5ddafb324164a04c63552374cd42d2322d2"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"386db3688df35a2b0f486d6e9cceb2b45c8f1334","unresolved":false,"context_lines":[{"line_number":2292,"context_line":"            query \u003d _volume_get_query(context).filter(conditions)"},{"line_number":2293,"context_line":"            if filters:"},{"line_number":2294,"context_line":"                if \u0027host\u0027 in filters:"},{"line_number":2295,"context_line":"                    del filters[\u0027host\u0027]"},{"line_number":2296,"context_line":""},{"line_number":2297,"context_line":"                query \u003d _process_volume_filters(query, filters)"},{"line_number":2298,"context_line":"                # No volumes would match, return empty list"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3d15ea3d","line":2295,"in_reply_to":"5faad753_80f4cc87","updated":"2019-11-15 09:20:40.000000000","message":"You mean host in filters is not allowed?","commit_id":"036ad5ddafb324164a04c63552374cd42d2322d2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"511a78e806671cb416a6232358cdc6c240761d1a","unresolved":false,"context_lines":[{"line_number":2231,"context_line":"    if host and isinstance(host, six.string_types):"},{"line_number":2232,"context_line":"        session \u003d get_session()"},{"line_number":2233,"context_line":"        with session.begin():"},{"line_number":2234,"context_line":"            conditions \u003d _filter_host(models.Volume.host, host)"},{"line_number":2235,"context_line":"            query \u003d _volume_get_query(context).filter(conditions)"},{"line_number":2236,"context_line":"            if filters:"},{"line_number":2237,"context_line":"                if \u0027host\u0027 in filters:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_bc6bfc1c","line":2234,"updated":"2019-11-19 03:01:30.000000000","message":"-1: Making this change is dangerous.  With this change the command \"cinder-manage volume update_host\" will accept the \"currenthost\" parameter in the form of \"host\" without defining the backend, which could lead to all the different backends being renamed.\n\nExample:  If we have cinder-volume with backends: \n  localhost.localdomain@lvm1#lvm1\n  localhost.localdomain@rbd#rbd\n\nRunning command:\n\n  cinder-manage volume update_host localhost.localdomain newhost.localdomain@lvm#lvm\n\nWith the current code: Nothing happens\n\nWith this change: All volumes for both backends, lvm and rbd, change their host !!","commit_id":"d7852af52ad468ab648480d9f2947a4f4f6c0a46"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"511a78e806671cb416a6232358cdc6c240761d1a","unresolved":false,"context_lines":[{"line_number":2234,"context_line":"            conditions \u003d _filter_host(models.Volume.host, host)"},{"line_number":2235,"context_line":"            query \u003d _volume_get_query(context).filter(conditions)"},{"line_number":2236,"context_line":"            if filters:"},{"line_number":2237,"context_line":"                if \u0027host\u0027 in filters:"},{"line_number":2238,"context_line":"                    del filters[\u0027host\u0027]"},{"line_number":2239,"context_line":""},{"line_number":2240,"context_line":"                query \u003d _process_volume_filters(query, filters)"},{"line_number":2241,"context_line":"                # No volumes would match, return empty list"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_7c1ca4c1","line":2238,"range":{"start_line":2237,"start_character":0,"end_line":2238,"end_character":39},"updated":"2019-11-19 03:01:30.000000000","message":"-1: We cannot silently ignore a parameter/filter","commit_id":"d7852af52ad468ab648480d9f2947a4f4f6c0a46"}]}