)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"08b54db16eaea16f66f70164c700fa94685b2ab1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Robustify skipactivation detection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When lvchange is not in the $PATH for non-root user,"},{"line_number":10,"context_line":"this code otherwise traces."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I308bd97cb729e83677f18a693274265a182d794c"},{"line_number":13,"context_line":"Closes-Bug: #1269445"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FRVI%3D","line":10,"updated":"2014-01-15 16:30:00.000000000","message":"Could you please add some detail here that your are robustifying by handling the exception and adding a debug message?\n\nThanks!","commit_id":"32404788855746fe13a6be0b63158fcd434c9d0e"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"3d5df5f1125992e572fa690224e152b970b45553","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dirk Mueller \u003cdirk@dmllr.de\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-16 15:30:40 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Robustify skipactivation detection"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Running lvchange might fail due to not being in"},{"line_number":10,"context_line":"$PATH for non-root user, and the corresponding OSError"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2FMP8%3D","line":7,"updated":"2014-01-16 15:54:24.000000000","message":"\"LVM: Robustify skipactivation detection\" please - makes reading the changelog easier. Thanks","commit_id":"c53c3c2b696616f0333e302d64b11ad5c101f232"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a1a71f193cbb659ec82554512953877f7367839d","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            cmd \u003d [\u0027lvchange\u0027, \u0027--help\u0027]"},{"line_number":233,"context_line":"            (out, err) \u003d self._execute("},{"line_number":234,"context_line":"                *cmd, root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":235,"context_line":"        except (putils.ProcessExecutionError, OSError):"},{"line_number":236,"context_line":"            LOG.debug(_(\"Ignoring error during testing whether lvchange \""},{"line_number":237,"context_line":"                        \"can ignore skip activation\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FRJo%3D","line":234,"updated":"2014-01-15 17:26:36.000000000","message":"If you are ignoring the error, why bother promoting this to run as root?","commit_id":"32404788855746fe13a6be0b63158fcd434c9d0e"},{"author":{"_account_id":6593,"name":"Dirk Mueller","email":"dirk@dmllr.de","username":"dmllr"},"change_message_id":"eef1275fd614f8851dc0ff6c2a8a42f3ca53e214","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        try:"},{"line_number":232,"context_line":"            cmd \u003d [\u0027lvchange\u0027, \u0027--help\u0027]"},{"line_number":233,"context_line":"            (out, err) \u003d self._execute("},{"line_number":234,"context_line":"                *cmd, root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":235,"context_line":"        except (putils.ProcessExecutionError, OSError):"},{"line_number":236,"context_line":"            LOG.debug(_(\"Ignoring error during testing whether lvchange \""},{"line_number":237,"context_line":"                        \"can ignore skip activation\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FQ5M%3D","line":234,"in_reply_to":"AAAAUH%2F%2FRJo%3D","updated":"2014-01-15 18:03:00.000000000","message":"Because that way the \"test\" code and the actual code later run in the same environment: Same user, same $PATH. When not run as root, the $PATH is different and that might cause a false-negative of the test. \n\nThe exception handling avoids a performance issue (it was running lvchange --help every time since it always backtraced before being able to set the caching flag)","commit_id":"32404788855746fe13a6be0b63158fcd434c9d0e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"08b54db16eaea16f66f70164c700fa94685b2ab1","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                *cmd, root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":235,"context_line":"        except (putils.ProcessExecutionError, OSError):"},{"line_number":236,"context_line":"            LOG.debug(_(\"Ignoring error during testing whether lvchange \""},{"line_number":237,"context_line":"                        \"can ignore skip activation\"))"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        lines \u003d out.split(\u0027\\n\u0027)"},{"line_number":240,"context_line":"        for line in lines:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FRWE%3D","line":237,"updated":"2014-01-15 16:30:00.000000000","message":"Recommend ending this with \"...\" to be consistent with the other debug message at line 588.","commit_id":"32404788855746fe13a6be0b63158fcd434c9d0e"}],"cinder/tests/brick/test_brick_lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"843c6a7f1b075e42137e683154e17a6d33a781c6","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.vg._supports_snapshot_lv_activation \u003d None"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def test_lvchange_ignskipact_support_yes(self):"},{"line_number":176,"context_line":"        \"\"\"Tests if lvchange -K is available via a lvm2 version check"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        Stubs provide output for \"vgs --version\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BuKc%3D","line":175,"updated":"2014-01-22 19:56:32.000000000","message":"It would be a lot simpler to write these two tests similarly to test_snapshot_lv_activate_support.  ^","commit_id":"75934474531e523ddede7b88fd52b3480f1607cf"}]}