)]}'
{"cinder/api/v2/limits.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0276e2170e1dcdc2bf4df7e46c88ceb3efe44922","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        if http_client.OK \u003c\u003d resp.status \u003c http_client.MULTIPLE_CHOICES:"},{"line_number":420,"context_line":"            return None, None"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return resp.getheader(\"X-Wait-Seconds\"), resp.read() or None"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_08b08a42","line":420,"range":{"start_line":420,"start_character":0,"end_line":420,"end_character":29},"updated":"2020-08-26 21:01:06.000000000","message":"hey, came here from the bug report on manila - but this change makes no sense.. :)\n\n \n\nThe code here is checking against the limiter if a delay is necessary - the limiter responds with HTTP 2xx statuses if a delay is not necessary.\n\nI understand this is a bit unreadable, but this check tries to catchall \"safe\"/OK HTTP responses - i.e., any HTTP code \u003e199 and \u003c300.","commit_id":"9d9b05f413c2e2e7e11ce64a5bdd13056b263b3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"da6c9448330db128668881d93eb68222608c88d8","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        resp \u003d conn.getresponse()"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        if http_client.OK \u003c\u003d resp.status \u003c http_client.MULTIPLE_CHOICES:"},{"line_number":420,"context_line":"            return None, None"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        return resp.getheader(\"X-Wait-Seconds\"), resp.read() or None"},{"line_number":423,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3a64a221","line":420,"range":{"start_line":420,"start_character":0,"end_line":420,"end_character":29},"in_reply_to":"9f560f44_08b08a42","updated":"2020-08-27 17:12:39.000000000","message":"I apologize for the churn, misread this :)","commit_id":"9d9b05f413c2e2e7e11ce64a5bdd13056b263b3b"}],"cinder/tests/unit/api/v2/test_limits.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5eb3ce321e0f530101d63eb4399fd00335932d77","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        # restore original HTTPConnection object"},{"line_number":734,"context_line":"        http_client.HTTPConnection \u003d oldHTTPConnection"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_200(self):"},{"line_number":737,"context_line":"        \"\"\"Successful request test.\"\"\""},{"line_number":738,"context_line":"        delay \u003d self.proxy.check_for_delay(\"GET\", \"/anything\")"},{"line_number":739,"context_line":"        self.assertEqual((None, None), delay)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ba9b0762","line":736,"range":{"start_line":736,"start_character":8,"end_line":736,"end_character":16},"updated":"2020-01-22 01:33:22.000000000","message":"Seems like this should have covered it, so either we have a test case issue, or there\u0027s something else going on with this call.","commit_id":"9d9b05f413c2e2e7e11ce64a5bdd13056b263b3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2319041509b256c26c7c3059aed0815ba3a7e58e","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        # restore original HTTPConnection object"},{"line_number":734,"context_line":"        http_client.HTTPConnection \u003d oldHTTPConnection"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_200(self):"},{"line_number":737,"context_line":"        \"\"\"Successful request test.\"\"\""},{"line_number":738,"context_line":"        delay \u003d self.proxy.check_for_delay(\"GET\", \"/anything\")"},{"line_number":739,"context_line":"        self.assertEqual((None, None), delay)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_357795a2","line":736,"range":{"start_line":736,"start_character":8,"end_line":736,"end_character":16},"in_reply_to":"1fa4df85_48e99fe3","updated":"2020-08-27 17:24:25.000000000","message":"This test passes because, even as \n\n  200 \u003e\u003d 204 \u003c 300\n\nreturns False,\n\nthe response is None, None\n\nbecause of https://review.opendev.org/#/c/669124/1/cinder/api/v2/limits.py@422:\n\n  resp.getheader(\"X-Wait-Seconds\"), resp.read() or None","commit_id":"9d9b05f413c2e2e7e11ce64a5bdd13056b263b3b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"724954adfc139fd9ae8eed282b1bddcb8b48adad","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        # restore original HTTPConnection object"},{"line_number":734,"context_line":"        http_client.HTTPConnection \u003d oldHTTPConnection"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"    def test_200(self):"},{"line_number":737,"context_line":"        \"\"\"Successful request test.\"\"\""},{"line_number":738,"context_line":"        delay \u003d self.proxy.check_for_delay(\"GET\", \"/anything\")"},{"line_number":739,"context_line":"        self.assertEqual((None, None), delay)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_48e99fe3","line":736,"range":{"start_line":736,"start_character":8,"end_line":736,"end_character":16},"in_reply_to":"3fa7e38b_ba9b0762","updated":"2020-03-09 16:44:29.000000000","message":"This test is actually named wrong because it tests 204 and not 200.","commit_id":"9d9b05f413c2e2e7e11ce64a5bdd13056b263b3b"}]}