)]}'
{"cinder/volume/drivers/linstordrv.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c631c1a52f3e0c4dede737d99b2ad395f5cd3cde","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":"            else:"},{"line_number":198,"context_line":"                return None"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":201,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_9e46cdc0","line":198,"range":{"start_line":195,"start_character":12,"end_line":198,"end_character":27},"updated":"2019-10-01 15:10:54.000000000","message":"All of these look like they could just be return api_reply.","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"},{"author":{"_account_id":28940,"name":"Woojay Poynter","email":"tenaciouswp@gmail.com","username":"woojay"},"change_message_id":"9b88065babf682103e8d49d10e156eb75a72edc6","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":"            else:"},{"line_number":198,"context_line":"                return None"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":201,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6ed00055","line":198,"range":{"start_line":195,"start_character":12,"end_line":198,"end_character":27},"in_reply_to":"3fa7e38b_9e46cdc0","updated":"2019-10-01 17:23:11.000000000","message":"All gone!","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3bd7e3e6afe43f573563ef440f359fcf5afeadc9","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":199,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_eba7f3a6","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":32},"updated":"2019-10-02 15:02:41.000000000","message":"I think the original comment of \"return api_reply\" is more clear, but I guess None is the default so this should be OK. If you do an update though, I still think it would be better to get rid of the if statements.","commit_id":"f89240056cc294e7968ce72facbd17b3a4eb07a6"},{"author":{"_account_id":28940,"name":"Woojay Poynter","email":"tenaciouswp@gmail.com","username":"woojay"},"change_message_id":"6b40c1eae103733a04dc7c5a2648b79f61d1346c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":199,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3611eb54","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":32},"in_reply_to":"3fa7e38b_73b0d5de","updated":"2019-10-02 18:43:46.000000000","message":"Done - Thank you for the comment.","commit_id":"f89240056cc294e7968ce72facbd17b3a4eb07a6"},{"author":{"_account_id":28940,"name":"Woojay Poynter","email":"tenaciouswp@gmail.com","username":"woojay"},"change_message_id":"6b40c1eae103733a04dc7c5a2648b79f61d1346c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":199,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_960c5f3c","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":32},"in_reply_to":"3fa7e38b_eba7f3a6","updated":"2019-10-02 18:43:46.000000000","message":"Done - Thank you for the comment.","commit_id":"f89240056cc294e7968ce72facbd17b3a4eb07a6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"170de7462ff14d164b488ef6b681dc920de0d660","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            if not lin.connected:"},{"line_number":193,"context_line":"                lin.connect()"},{"line_number":194,"context_line":"            api_reply \u003d lin.resource_list()[0].__dict__[\u0027_rest_data\u0027]"},{"line_number":195,"context_line":"            if api_reply:"},{"line_number":196,"context_line":"                return api_reply"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _get_api_resource_dfn_list(self):"},{"line_number":199,"context_line":"        with lin_drv(self.default_uri) as lin:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_73b0d5de","line":196,"range":{"start_line":195,"start_character":12,"end_line":196,"end_character":32},"in_reply_to":"3fa7e38b_eba7f3a6","updated":"2019-10-02 17:23:20.000000000","message":"Here\u0027s another reason to get rid of the \u0027if\u0027 here (and in the other functions below).  If the dict returned by the call is empty, \"if api_reply\" will be false, and you\u0027ll return None (the default return value) instead of an empty dict, which could make a difference to whatever is calling this function.  I suspect that you mean \"if api_reply is not None\" as your condition, and in that case, you should do as Sean suggests and just return api_reply unconditionally.","commit_id":"f89240056cc294e7968ce72facbd17b3a4eb07a6"}],"releasenotes/notes/releasenotes/notes/drbd-linstor-rest-update-52fd52f6c09a4dd3.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5bc4d6a8b6fe34be513a281d8df3c87ccd7b7006","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    LINSTOR driver for Cinder supports LINSTOR 0.9.12 that uses REST API on"},{"line_number":5,"context_line":"    the backend and removes protobuf messages."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_819cd06a","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":45},"updated":"2019-08-28 14:43:53.000000000","message":"I think the protobuf change is independent of the 0.9.12 support?  This sentence makes it sound like they\u0027re related.\n\nI suggest adding a \u0027features\u0027 section point, something like \"The LINSTOR driver for Cinder now supports LINSTOR 0.9.12\"\n\nThen in the \u0027upgrade\u0027 section, make sure you mention the new config option introduced with this patch, something like \"The LINSTOR driver adds a new configuration option ...\"\n\nI think it\u0027s worth mentioning also that the protobuf dependency has been removed, not sure if that should go in \u0027upgrade\u0027 or \u0027other\u0027 (check with Sean or Jay).","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"},{"author":{"_account_id":28940,"name":"Woojay Poynter","email":"tenaciouswp@gmail.com","username":"woojay"},"change_message_id":"9b88065babf682103e8d49d10e156eb75a72edc6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    LINSTOR driver for Cinder supports LINSTOR 0.9.12 that uses REST API on"},{"line_number":5,"context_line":"    the backend and removes protobuf messages."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_8e3a1c96","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":45},"in_reply_to":"3fa7e38b_7e651145","updated":"2019-10-01 17:23:11.000000000","message":"Gone w/ \u0027x\u0027s on my vim.","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c631c1a52f3e0c4dede737d99b2ad395f5cd3cde","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    LINSTOR driver for Cinder supports LINSTOR 0.9.12 that uses REST API on"},{"line_number":5,"context_line":"    the backend and removes protobuf messages."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_7e651145","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":45},"in_reply_to":"7faddb67_0cbf4dd0","updated":"2019-10-01 15:10:54.000000000","message":"I do still think the protobuf mention can just be removed.","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"},{"author":{"_account_id":28940,"name":"Woojay Poynter","email":"tenaciouswp@gmail.com","username":"woojay"},"change_message_id":"73dc40a6f5c0854e6e6e622e108179cfd200d50c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    LINSTOR driver for Cinder supports LINSTOR 0.9.12 that uses REST API on"},{"line_number":5,"context_line":"    the backend and removes protobuf messages."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_0cbf4dd0","line":5,"range":{"start_line":5,"start_character":16,"end_line":5,"end_character":45},"in_reply_to":"7faddb67_819cd06a","updated":"2019-09-04 17:51:36.000000000","message":"Thank you for the feedback.  I will wait for your code review before a patch, so as not to trigger a CI run just on a doc change.  \n\nI will update the release note to include features and upgrade section as well.  Both Jay and Sean felt that protobuf removal was an internal change w/o a need for announcement.  Thanks again.","commit_id":"0f05fc1b8a743950ed12e37017c09b7b64827216"}]}