)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"c65a2dcc9273a1d781122352e9083ae104b5d2e5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"we\u0027d adopt multi-process (worker) mode that has been used for long"},{"line_number":13,"context_line":"in Glance/Swift/Nova."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The defalut behavior isn\u0027t changed with this patch, Cinder API"},{"line_number":16,"context_line":"service with still run in one process (default value of"},{"line_number":17,"context_line":"osapi_volume_workers is None)."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2BrMA%3D","line":15,"updated":"2014-01-23 10:45:08.000000000","message":"s/default/default/","commit_id":"9d487af025a638341354ece63baa4b69bf3c6f2d"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"c65a2dcc9273a1d781122352e9083ae104b5d2e5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"in Glance/Swift/Nova."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The defalut behavior isn\u0027t changed with this patch, Cinder API"},{"line_number":16,"context_line":"service with still run in one process (default value of"},{"line_number":17,"context_line":"osapi_volume_workers is None)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Implementation wise, a good portion of cinder/service.py has been"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"AAAAUH%2F%2BrL8%3D","line":16,"updated":"2014-01-23 10:45:08.000000000","message":"s/with/will/","commit_id":"9d487af025a638341354ece63baa4b69bf3c6f2d"}],"cinder/service.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9003e08d711c17ad8af87f51028845f9363fd597","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt(\u0027osapi_volume_listen_port\u0027,"},{"line_number":63,"context_line":"               default\u003d8776,"},{"line_number":64,"context_line":"               help\u003d\u0027port for os volume api to listen\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027osapi_volume_workers\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Number of workers for OpenStack Volume API service\u0027),"},{"line_number":67,"context_line":"    ]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FKio%3D","line":65,"updated":"2014-01-16 20:09:56.000000000","message":"I can\u0027t figure out how this get\u0027s used?  I mean, where we actually check it.  As far as I can see we never actually do anything with it even though we have the code that will take it as an option.","commit_id":"bccf32e75f224310de99d5629c77d53f3884d3d4"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b12d0f468d7f3d094cc721bbe77b8e03c5c06dbb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt(\u0027osapi_volume_listen_port\u0027,"},{"line_number":63,"context_line":"               default\u003d8776,"},{"line_number":64,"context_line":"               help\u003d\u0027port for os volume api to listen\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027osapi_volume_workers\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Number of workers for OpenStack Volume API service\u0027),"},{"line_number":67,"context_line":"    ]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FHus%3D","line":65,"in_reply_to":"AAAAUH%2F%2FJbw%3D","updated":"2014-01-17 08:28:18.000000000","message":"Done","commit_id":"bccf32e75f224310de99d5629c77d53f3884d3d4"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"05e53b3dbadd4e194e70b975948a1a59aebe5966","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt(\u0027osapi_volume_listen_port\u0027,"},{"line_number":63,"context_line":"               default\u003d8776,"},{"line_number":64,"context_line":"               help\u003d\u0027port for os volume api to listen\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027osapi_volume_workers\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Number of workers for OpenStack Volume API service\u0027),"},{"line_number":67,"context_line":"    ]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FJbw%3D","line":65,"in_reply_to":"AAAAUH%2F%2FKio%3D","updated":"2014-01-17 00:35:19.000000000","message":"As Bryant commented in patch https://review.openstack.org/#/c/63317/, it seems that some verification of the worker value that is sent in is necessary.","commit_id":"bccf32e75f224310de99d5629c77d53f3884d3d4"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"b12d0f468d7f3d094cc721bbe77b8e03c5c06dbb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    cfg.IntOpt(\u0027osapi_volume_listen_port\u0027,"},{"line_number":63,"context_line":"               default\u003d8776,"},{"line_number":64,"context_line":"               help\u003d\u0027port for os volume api to listen\u0027),"},{"line_number":65,"context_line":"    cfg.IntOpt(\u0027osapi_volume_workers\u0027,"},{"line_number":66,"context_line":"               help\u003d\u0027Number of workers for OpenStack Volume API service\u0027),"},{"line_number":67,"context_line":"    ]"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FH0Q%3D","line":65,"in_reply_to":"AAAAUH%2F%2FKio%3D","updated":"2014-01-17 08:28:18.000000000","message":"This option is used on line 286, when initializing WSGIService().  I can add some check to make sure the value is not negative integer.","commit_id":"bccf32e75f224310de99d5629c77d53f3884d3d4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4f3d4b5d047a78d82a09c1c4651e51bde6d15271","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.host \u003d getattr(CONF, \u0027%s_listen\u0027 % name, \"0.0.0.0\")"},{"line_number":278,"context_line":"        self.port \u003d getattr(CONF, \u0027%s_listen_port\u0027 % name, 0)"},{"line_number":279,"context_line":"        self.workers \u003d getattr(CONF, \u0027%s_workers\u0027 % name, None)"},{"line_number":280,"context_line":"        if self.workers \u003c 0:"},{"line_number":281,"context_line":"            LOG.warn(_(\"Config option %(name)s_workers must be postive \""},{"line_number":282,"context_line":"                       \"integer.  Input value ignored.\") %"},{"line_number":283,"context_line":"                     {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BvOg%3D","line":280,"updated":"2014-01-22 16:49:48.000000000","message":"Shouldn\u0027t this be \u0027\u003c 1\u0027 .  Do you want a person to be able to specify 0 workers?","commit_id":"07860e30a799a9d6696c029b0a3ed0af11e42975"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"a7ba0851f17a7054b8f96abf64ec7821371755d2","unresolved":false,"context_lines":[{"line_number":277,"context_line":"        self.host \u003d getattr(CONF, \u0027%s_listen\u0027 % name, \"0.0.0.0\")"},{"line_number":278,"context_line":"        self.port \u003d getattr(CONF, \u0027%s_listen_port\u0027 % name, 0)"},{"line_number":279,"context_line":"        self.workers \u003d getattr(CONF, \u0027%s_workers\u0027 % name, None)"},{"line_number":280,"context_line":"        if self.workers \u003c 0:"},{"line_number":281,"context_line":"            LOG.warn(_(\"Config option %(name)s_workers must be postive \""},{"line_number":282,"context_line":"                       \"integer.  Input value ignored.\") %"},{"line_number":283,"context_line":"                     {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Br1g%3D","line":280,"in_reply_to":"AAAAUH%2F%2BvOg%3D","updated":"2014-01-23 08:04:13.000000000","message":"Done","commit_id":"07860e30a799a9d6696c029b0a3ed0af11e42975"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"4f3d4b5d047a78d82a09c1c4651e51bde6d15271","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        self.workers \u003d getattr(CONF, \u0027%s_workers\u0027 % name, None)"},{"line_number":280,"context_line":"        if self.workers \u003c 0:"},{"line_number":281,"context_line":"            LOG.warn(_(\"Config option %(name)s_workers must be postive \""},{"line_number":282,"context_line":"                       \"integer.  Input value ignored.\") %"},{"line_number":283,"context_line":"                     {\u0027name\u0027: name})"},{"line_number":284,"context_line":"            # Reset workers to default"},{"line_number":285,"context_line":"            self.workers \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2BvOU%3D","line":282,"updated":"2014-01-22 16:49:48.000000000","message":"This would then be:  \nLOG.warn(_(\"Config option %(name)s_workers must be postive \"\n                  \"integer greater than 0.  Input value ignored.\"","commit_id":"07860e30a799a9d6696c029b0a3ed0af11e42975"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"a7ba0851f17a7054b8f96abf64ec7821371755d2","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        self.workers \u003d getattr(CONF, \u0027%s_workers\u0027 % name, None)"},{"line_number":280,"context_line":"        if self.workers \u003c 0:"},{"line_number":281,"context_line":"            LOG.warn(_(\"Config option %(name)s_workers must be postive \""},{"line_number":282,"context_line":"                       \"integer.  Input value ignored.\") %"},{"line_number":283,"context_line":"                     {\u0027name\u0027: name})"},{"line_number":284,"context_line":"            # Reset workers to default"},{"line_number":285,"context_line":"            self.workers \u003d None"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAUH%2F%2Br1c%3D","line":282,"in_reply_to":"AAAAUH%2F%2BvOU%3D","updated":"2014-01-23 08:04:13.000000000","message":"Done","commit_id":"07860e30a799a9d6696c029b0a3ed0af11e42975"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"74e53f9305b63c8f055741c04c381fd6af58898b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# value)"},{"line_number":81,"context_line":"#osapi_volume_workers\u003d\u003cNone\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# Options defined in cinder.test"},{"line_number":86,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAUH%2F%2BqHg%3D","line":83,"updated":"2014-01-23 13:27:14.000000000","message":"there are 2 blank lines, but it\u0027s fine for me.","commit_id":"9d487af025a638341354ece63baa4b69bf3c6f2d"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"b49c9c1996f17898c27604fd465cc225aa22b9c5","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# value)"},{"line_number":81,"context_line":"#osapi_volume_workers\u003d\u003cNone\u003e"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"#"},{"line_number":85,"context_line":"# Options defined in cinder.test"},{"line_number":86,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAAUH%2F%2Bp9k%3D","line":83,"in_reply_to":"AAAAUH%2F%2BqHg%3D","updated":"2014-01-23 13:58:54.000000000","message":"this file is generated automatically, and the script puts 2 blank lines between options defined in different files","commit_id":"9d487af025a638341354ece63baa4b69bf3c6f2d"}]}