)]}'
{"cinder/volume/drivers/rsd.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7a83fa278d0a0f6bc66cf82ef9ff2815514fe90c","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        % {\u0027vol\u0027: volume.path,"},{"line_number":139,"context_line":"                           \u0027len_pp\u0027: len_pp}))"},{"line_number":140,"context_line":"        providing_pool \u003d volume.capacity_sources[0].providing_pools[0]"},{"line_number":141,"context_line":"        return providing_pool.get_members()[0].path"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _create_vol_or_snap(self,"},{"line_number":144,"context_line":"                            storage,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_450e2b33","line":141,"updated":"2019-07-23 13:24:20.000000000","message":"you should add a minimum version check in the driver to ensure it\u0027s compatible with how it\u0027s being used.   Most drivers do this at driver startup time.https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_common.py#L381","commit_id":"83f4281010968c6e6ca1e563b0b867aaee32acde"},{"author":{"_account_id":29964,"name":"Tejdeep Kautharam","email":"tejdeep.kautharam@intel.com","username":"tejdeep"},"change_message_id":"838df5c40960819022aa81043b2b552076ed7c04","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        % {\u0027vol\u0027: volume.path,"},{"line_number":139,"context_line":"                           \u0027len_pp\u0027: len_pp}))"},{"line_number":140,"context_line":"        providing_pool \u003d volume.capacity_sources[0].providing_pools[0]"},{"line_number":141,"context_line":"        return providing_pool.get_members()[0].path"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def _create_vol_or_snap(self,"},{"line_number":144,"context_line":"                            storage,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_a7af72e1","line":141,"in_reply_to":"7faddb67_450e2b33","updated":"2019-07-31 00:51:14.000000000","message":"Done","commit_id":"83f4281010968c6e6ca1e563b0b867aaee32acde"}],"driver-requirements.txt":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"17406d1da0594331b2886e0a4d3871620c09f3ac","unresolved":false,"context_lines":[{"line_number":43,"context_line":"storpool # Apache-2.0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# RSD Driver"},{"line_number":46,"context_line":"rsd-lib\u003e1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_fd457d44","line":46,"updated":"2019-07-22 20:51:56.000000000","message":"Is this published on pypi? This should be added to global requirements and our setup.cfg, and removed from here.","commit_id":"83f4281010968c6e6ca1e563b0b867aaee32acde"},{"author":{"_account_id":29964,"name":"Tejdeep Kautharam","email":"tejdeep.kautharam@intel.com","username":"tejdeep"},"change_message_id":"838df5c40960819022aa81043b2b552076ed7c04","unresolved":false,"context_lines":[{"line_number":43,"context_line":"storpool # Apache-2.0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# RSD Driver"},{"line_number":46,"context_line":"rsd-lib\u003e1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_bd0865d9","line":46,"in_reply_to":"7faddb67_fd457d44","updated":"2019-07-31 00:51:14.000000000","message":"Hi Sean, the new version 1.1.0 is published in the PyPI https://pypi.org/project/rsd-lib/. Global Requirements already has rsd-lib and upper-constraints shows rsd-lib\u003d\u003d\u003d1.1.0(https://github.com/openstack/requirements/blob/9219fa02ac07ba4454b79e7836e69497f5074a85/upper-constraints.txt#L135). So I just updated lower-cosntraints.txt and setup.cfg in the project tree to 1.1.0","commit_id":"83f4281010968c6e6ca1e563b0b867aaee32acde"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"843e55f96e06b1b523b86da3bc979afaada703c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7faddb67_44bd51d6","line":44,"updated":"2019-07-31 14:47:57.000000000","message":"As far as I know, rsd-lib should remain in driver-requirements.txt since it\u0027s still an optional requirement used by your driver.","commit_id":"a420da40fbe277eda6568fd30053cbcd7838f359"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3061bca09d34db2c62e345de1af3540a8d2c2c60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7faddb67_7fe33a35","line":44,"in_reply_to":"7faddb67_44bd51d6","updated":"2019-07-31 15:14:02.000000000","message":"I believe the plan is to get rid of this file with the work Walt has done to get these added to setup.cfg and in the official global requirements.\n\nThis lib is on pypi and has been added to g-r: https://opendev.org/openstack/requirements/src/branch/master/global-requirements.txt#L319","commit_id":"a420da40fbe277eda6568fd30053cbcd7838f359"}],"setup.cfg":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3061bca09d34db2c62e345de1af3540a8d2c2c60","unresolved":false,"context_lines":[{"line_number":98,"context_line":"output_file \u003d cinder/locale/cinder.pot"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[extras]"},{"line_number":101,"context_line":"rsd \u003d"},{"line_number":102,"context_line":"    rsd-lib\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"7faddb67_9fb95616","line":101,"updated":"2019-07-31 15:14:02.000000000","message":"This is mostly right, but I wonder if this should be rebased to be on top of https://review.opendev.org/#/c/656724/ to also pick up the addition to \"all\".","commit_id":"a420da40fbe277eda6568fd30053cbcd7838f359"},{"author":{"_account_id":29964,"name":"Tejdeep Kautharam","email":"tejdeep.kautharam@intel.com","username":"tejdeep"},"change_message_id":"e6721e2b7bfee94cc6ef4776cc98bdc926929601","unresolved":false,"context_lines":[{"line_number":98,"context_line":"output_file \u003d cinder/locale/cinder.pot"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"[extras]"},{"line_number":101,"context_line":"rsd \u003d"},{"line_number":102,"context_line":"    rsd-lib\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"7faddb67_e95c4d1a","line":101,"in_reply_to":"7faddb67_9fb95616","updated":"2019-08-02 03:27:45.000000000","message":"Hi Sean, I have rebased the commit with https://review.opendev.org/#/c/656724/","commit_id":"a420da40fbe277eda6568fd30053cbcd7838f359"}]}