)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8298dbdc545a76ec1eb216e64c2219a8c311c468","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yenai \u003cyenai@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-07 08:39:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add attach_encryptor when do detach volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0824fbecdd37623b9ddc8715a92fc6f540c45efe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_f6c11331","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"updated":"2019-11-07 09:15:25.000000000","message":"I think you need to describe why we want to do that and put more info here.\n\nDo we have an opened bug related to this? If yes, then you need to refer to it here.","commit_id":"13610c7f7367063739c2f0942278d168f3ab483a"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"1a4d8986294d7580ed954ed72bc7c833bec9575f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yenai \u003cyenai@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-11-07 08:39:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add attach_encryptor when do detach volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0824fbecdd37623b9ddc8715a92fc6f540c45efe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_91f469f3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"in_reply_to":"3fa7e38b_f6c11331","updated":"2019-11-07 10:05:37.000000000","message":"Done","commit_id":"13610c7f7367063739c2f0942278d168f3ab483a"}],"cinder/volume/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2e697a14a9b0aae716a2685d1b61af621b1f2d3c","unresolved":false,"context_lines":[{"line_number":2085,"context_line":"                          \" %(vol)s.\", {\u0027vol\u0027: volume[\u0027id\u0027]})"},{"line_number":2086,"context_line":"                self._detach_volume(ctxt, attach_info, volume, properties,"},{"line_number":2087,"context_line":"                                    force\u003dTrue,"},{"line_number":2088,"context_line":"                                    attach_encryptor\u003dattach_encryptor)"},{"line_number":2089,"context_line":"        return attach_info"},{"line_number":2090,"context_line":""},{"line_number":2091,"context_line":"    def _detach_volume(self, ctxt, attach_info, volume, properties,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_cba770bc","line":2088,"updated":"2019-11-11 17:08:40.000000000","message":"As I see it there are 2 cases:\n\n- The exception is raised before L2079 (call to `brick_attach_volume_encryptor`), and then the decrypting device mapper should not be there yet.\n\n- The exception is raised when calling `brick_attach_volume_encryptor` and the device mapper was not been cleaned up.  In this case the bug is in that method (or one that gets called from it), because when the method raises the exception to this level the device mapper should not be there.\n\nMaybe I\u0027m missing a case where this change is valid. Is there any chance to see the real logs of the issue?  The logs in the launchpad bug are from a simulation.","commit_id":"52997291eafd0e1d746c6cf6155adfd8ae045e51"}]}
