)]}'
{"cinder/api/views/backups.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dc1818edf22930e96e9af2481145d291e0111e80","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        backups_list \u003d [func(request, backup)[\u0027backup\u0027] for backup in backups]"},{"line_number":88,"context_line":"        backups_links \u003d self._get_collection_links(request,"},{"line_number":89,"context_line":"                                                   backups,"},{"line_number":90,"context_line":"                                                   coll_name,"},{"line_number":91,"context_line":"                                                   backup_count)"},{"line_number":92,"context_line":"        backups_dict \u003d dict(backups\u003dbackups_list)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bf4bf228","line":90,"updated":"2019-07-31 15:14:53.000000000","message":"This looks like it risks overloading some assumptions further down the stack, because \"backups/detail\" is probably not actually a \"collection name\"?","commit_id":"d1affdaf44b43ed05f3a2bdf50bff94a0a0c317e"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"abe922f0baa0de6fe6c5ce6de405646c8b8ac6a7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        backups_list \u003d [func(request, backup)[\u0027backup\u0027] for backup in backups]"},{"line_number":88,"context_line":"        backups_links \u003d self._get_collection_links(request,"},{"line_number":89,"context_line":"                                                   backups,"},{"line_number":90,"context_line":"                                                   coll_name,"},{"line_number":91,"context_line":"                                                   backup_count)"},{"line_number":92,"context_line":"        backups_dict \u003d dict(backups\u003dbackups_list)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b451cc38","line":90,"in_reply_to":"7faddb67_bf4bf228","updated":"2019-08-02 03:06:10.000000000","message":"The REST api for backups is /v3/{project_id}/backups/detail[0] or /v2/{project_id}/backups/detail[1]. So not only for v3 but also for v2 is backups/detail.\n\nWe will generate the next link here[2]. And If we do not set \u0027/detail\u0027 in collection_name, when we try to get backups by this link(eg: default value of osapi_max_limit is 1000, and we have 1001 backups), we will only get summary info of backups.\n\n[0] https://docs.openstack.org/api-ref/block-storage/v3/index.html#list-backups-with-detail\n[1] https://docs.openstack.org/api-ref/block-storage/v2/index.html#backups-backups","commit_id":"d1affdaf44b43ed05f3a2bdf50bff94a0a0c317e"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"3aa2b2637eb9bdb94ebb6bbf807478e9e52e6d4f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def detail_list(self, request, backups, backup_count\u003dNone):"},{"line_number":33,"context_line":"        \"\"\"Detailed view of a list of backups .\"\"\""},{"line_number":34,"context_line":"        return self._list_view(self.detail, request, backups, backup_count,"},{"line_number":35,"context_line":"                               self._collection_name + \u0027/detail\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def summary(self, request, backup):"},{"line_number":38,"context_line":"        \"\"\"Generic, non-detailed view of a backup.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_258913c9","line":35,"range":{"start_line":35,"start_character":31,"end_line":35,"end_character":64},"updated":"2019-08-02 03:11:02.000000000","message":"BTW, if we do not use \u0027/detail\u0027 here, the new unit test will be failure.","commit_id":"8781ccae7334a98241a6e22a46eebc10be754596"}]}