)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"01a9465a57ea78624afe3e61ba8d43f6d0e8225d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"RSD driver method fails when float volume size is passed to the"},{"line_number":10,"context_line":"extend_volume method. Fixed this bug by casting size_in_gb to int"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/670677"},{"line_number":13,"context_line":"Change-Id: I7c0abd7ff0bcb620b3e686885e7e6f04b9f9a519"},{"line_number":14,"context_line":"Closes-Bug: #1838714"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a1b09044","line":12,"updated":"2019-08-02 12:04:06.000000000","message":"Depends-on is for cross-repo dependencies. If it\u0027s the same repo, the commit should just be on top of the change it depends on.","commit_id":"c023fcbb1902e8a5bfe9b9e83bf7c33cafa73997"}],"cinder/volume/drivers/rsd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"01a9465a57ea78624afe3e61ba8d43f6d0e8225d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                      % volume_url))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def extend_volume(self, volume_url, size_in_gb):"},{"line_number":302,"context_line":"        size_in_bytes \u003d int(size_in_gb) * units.Gi"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            volume \u003d self._get_volume(volume_url)"},{"line_number":305,"context_line":"            volume.resize(size_in_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_41899c72","line":302,"updated":"2019-08-02 12:04:06.000000000","message":"There shouldn\u0027t be a need to do this, unless there is an issue when using cinderlib. Not sure if cinderlib accounts for that in any way.","commit_id":"c023fcbb1902e8a5bfe9b9e83bf7c33cafa73997"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4f4473066e24e39ebc09a50ff8433e5d09a7e82a","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                      % volume_url))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def extend_volume(self, volume_url, size_in_gb):"},{"line_number":302,"context_line":"        size_in_bytes \u003d int(size_in_gb) * units.Gi"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            volume \u003d self._get_volume(volume_url)"},{"line_number":305,"context_line":"            volume.resize(size_in_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b63d1fbc","line":302,"in_reply_to":"7faddb67_41899c72","updated":"2019-08-05 11:21:09.000000000","message":"Cinderlib doesn\u0027t check the type of the size, so it could be passing to the driver a float, a string, None, or whatever the library user decides to pass.\n\nI don\u0027t think this can happen in Cinder itself, as no other driver seems to need this change.\n\nIf this change is for a cinderlib case we should add the casting here: https://opendev.org/openstack/cinderlib/src/branch/master/cinderlib/objects.py#L491","commit_id":"c023fcbb1902e8a5bfe9b9e83bf7c33cafa73997"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"09d1c1a190068b9a3f864036aed8f18d17254f80","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                      % volume_url))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def extend_volume(self, volume_url, size_in_gb):"},{"line_number":302,"context_line":"        size_in_bytes \u003d int(size_in_gb) * units.Gi"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            volume \u003d self._get_volume(volume_url)"},{"line_number":305,"context_line":"            volume.resize(size_in_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_cf525569","line":302,"in_reply_to":"7faddb67_9125825e","updated":"2019-08-07 09:22:46.000000000","message":"That\u0027s probably something that was necessary before, but now it\u0027s not.","commit_id":"c023fcbb1902e8a5bfe9b9e83bf7c33cafa73997"},{"author":{"_account_id":29964,"name":"Tejdeep Kautharam","email":"tejdeep.kautharam@intel.com","username":"tejdeep"},"change_message_id":"a326adabccd027796008e845d2ebe605209f2279","unresolved":false,"context_lines":[{"line_number":299,"context_line":"                      % volume_url))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def extend_volume(self, volume_url, size_in_gb):"},{"line_number":302,"context_line":"        size_in_bytes \u003d int(size_in_gb) * units.Gi"},{"line_number":303,"context_line":"        try:"},{"line_number":304,"context_line":"            volume \u003d self._get_volume(volume_url)"},{"line_number":305,"context_line":"            volume.resize(size_in_bytes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_9125825e","line":302,"in_reply_to":"7faddb67_b63d1fbc","updated":"2019-08-05 23:55:52.000000000","message":"I found the same kind of casting in the rbd driver.\nhttps://github.com/openstack/cinder/blob/9f7ef27b2a287343e33f526ede25386ffe6f6c78/cinder/volume/drivers/rbd.py#L1630","commit_id":"c023fcbb1902e8a5bfe9b9e83bf7c33cafa73997"}]}