)]}'
{"cinder/volume/drivers/nec/volume.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9eb8323e298df31ce22b3cda93efb1a548dd0d82","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                 Fixed bug #1777385: driver removed access permission from"},{"line_number":48,"context_line":"                 the destination node after live-migraion."},{"line_number":49,"context_line":"                 Fixed bug #1778669: LUNs of detached volumes are never reused."},{"line_number":50,"context_line":"        1.11.1 - Add support pytyon 3."},{"line_number":51,"context_line":"                 Add support for multi-attach."},{"line_number":52,"context_line":"                 Add support of more than 4 iSCSI portals for a node."},{"line_number":53,"context_line":"                 Add support to revert a volume to a snapshot."}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e649e530","line":50,"range":{"start_line":50,"start_character":29,"end_line":50,"end_character":35},"updated":"2019-09-25 11:24:03.000000000","message":"this could be corrected in a followup","commit_id":"36d8607190e26a856762ee9b355bdc48d5d0929b"}],"cinder/volume/drivers/nec/volume_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9eb8323e298df31ce22b3cda93efb1a548dd0d82","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        specs \u003d {}"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":827,"context_line":"        type_id \u003d volume_type_id"},{"line_number":828,"context_line":"        if type_id is not None:"},{"line_number":829,"context_line":"            volume_type \u003d volume_types.get_volume_type(ctxt, type_id)"},{"line_number":830,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c1192c7a","line":827,"range":{"start_line":827,"start_character":8,"end_line":827,"end_character":18},"updated":"2019-09-25 11:24:03.000000000","message":"do we need this variable anymore?","commit_id":"36d8607190e26a856762ee9b355bdc48d5d0929b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9eb8323e298df31ce22b3cda93efb1a548dd0d82","unresolved":false,"context_lines":[{"line_number":855,"context_line":"        else:"},{"line_number":856,"context_line":"            # 0: Set to no limit.(default)"},{"line_number":857,"context_line":"            # None: Keep current value."},{"line_number":858,"context_line":"            specs[\u0027upperlimit\u0027] \u003d \u00270\u0027 if reset else None"},{"line_number":859,"context_line":""},{"line_number":860,"context_line":"        if \u0027lowerlimit\u0027 in specs and specs[\u0027lowerlimit\u0027] is not None:"},{"line_number":861,"context_line":"            if self.validates_number(specs[\u0027lowerlimit\u0027]) is True:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_216840b7","line":858,"range":{"start_line":858,"start_character":34,"end_line":858,"end_character":37},"updated":"2019-09-25 11:24:03.000000000","message":"could you provide the reason for setting this as a string?\nwe usually specify no limit as -1","commit_id":"36d8607190e26a856762ee9b355bdc48d5d0929b"}],"cinder/volume/drivers/nec/volume_helper.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9eb8323e298df31ce22b3cda93efb1a548dd0d82","unresolved":false,"context_lines":[{"line_number":721,"context_line":"    def _migrate(self, volume, host, volume_type_id, validator, pool_selecter):"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        # bind LD."},{"line_number":724,"context_line":"        (rvname,"},{"line_number":725,"context_line":"         ldn,"},{"line_number":726,"context_line":"         selected_pool) \u003d self._bind_ld(volume,"},{"line_number":727,"context_line":"                                        volume.size,"},{"line_number":728,"context_line":"                                        validator,"},{"line_number":729,"context_line":"                                        self._convert_id2migratename,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_c321aea1","line":726,"range":{"start_line":724,"start_character":8,"end_line":726,"end_character":23},"updated":"2019-09-25 11:24:03.000000000","message":"the formatting could be improved here","commit_id":"a5ed91ee7644e4fbed3d878f9b4da26c502119d3"}]}
