)]}'
{"cinder/api/api_utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"428ca14e40f39c7daf4ec7cfd9076ec5f7916688","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def _parse_is_public(is_public):"},{"line_number":25,"context_line":"    \"\"\"Parse is_public into something usable."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    * True: List public volume types only"},{"line_number":28,"context_line":"    * False: List private volume types only"},{"line_number":29,"context_line":"    * None: List both public and private volume types"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if is_public is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3fbe3bae","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":53},"updated":"2019-08-14 17:58:18.000000000","message":"Since this is used by both volume types and group types, would be better to update it as\n* True: List public types only\n...","commit_id":"90f962553a50df4123739ab5730ae1639e397d70"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7e870873e945b9c7fa81272aa14a275e8e93709d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"def _parse_is_public(is_public):"},{"line_number":25,"context_line":"    \"\"\"Parse is_public into something usable."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    * True: List public volume types only"},{"line_number":28,"context_line":"    * False: List private volume types only"},{"line_number":29,"context_line":"    * None: List both public and private volume types"},{"line_number":30,"context_line":"    \"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    if is_public is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_010aeb77","line":29,"range":{"start_line":27,"start_character":0,"end_line":29,"end_character":53},"in_reply_to":"7faddb67_3fbe3bae","updated":"2019-08-15 20:38:00.000000000","message":"Agree that this should be updated on a different patch.  Though note that this doesn\u0027t actually list anything, it\u0027s just a mapping from the input to {True, False, None}, and the calling function is supposed to know what the return value means.  I think we\u0027d be better off mapping this into a three-valued enumeration rather than do this tri-state boolean kind of thing and hope that no one confuses None and False in the calling code.  Guess what I\u0027m saying is rather than update the docstring, maybe we should refactor this function and the code that uses it a bit.  It really looks like an accident waiting to happen.","commit_id":"90f962553a50df4123739ab5730ae1639e397d70"}]}