)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3f9ca277db310bd8b50d62797b1ac67a8d40498e","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    \"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    VERSION \u003d \"4.0.13\""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"    stats \u003d {}"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_21324af3","line":297,"updated":"2019-08-20 15:18:13.000000000","message":"Version bump and history addition here as well.","commit_id":"18946fc31d8ffa0641f732029d07f57b8774fae2"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b0beeb2d4fd042fd668263aca6470566dbf9c61e","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"            failover_target \u003d common._replication_targets[0]"},{"line_number":232,"context_line":"            replication_mode \u003d failover_target[\u0027replication_mode\u0027]"},{"line_number":233,"context_line":"            quorum_witness_ip \u003d failover_target.get(\u0027quorum_witness_ip\u0027, None)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            if replication_mode !\u003d 1 or quorum_witness_ip \u003d\u003d \u0027\u0027:"},{"line_number":236,"context_line":"                LOG.info(\u0027Active/Passive replication has been \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_6f6a28ee","line":233,"range":{"start_line":233,"start_character":71,"end_line":233,"end_character":77},"updated":"2019-08-08 12:39:06.000000000","message":"This is not needed since the default for .get() is None.","commit_id":"c1e197b669db357eab89fbf6e0d3ba00b7e7d263"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b0beeb2d4fd042fd668263aca6470566dbf9c61e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            host, cpg \u003d self._create_host("},{"line_number":244,"context_line":"                common, volume, connector,"},{"line_number":245,"context_line":"                failover_target, cpg, cl)"},{"line_number":246,"context_line":"            target_wwns, init_targ_map, numPaths \u003d \\"},{"line_number":247,"context_line":"                self._build_initiator_target_map(common, connector, cl)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"            # check if a VLUN already exists for this host"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2f7430d0","line":246,"range":{"start_line":246,"start_character":51,"end_line":246,"end_character":52},"updated":"2019-08-08 12:39:06.000000000","message":"Please avoid using \\ to span multiple lines. Wrap in () if necessary.","commit_id":"c1e197b669db357eab89fbf6e0d3ba00b7e7d263"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b0beeb2d4fd042fd668263aca6470566dbf9c61e","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            vlun \u003d None"},{"line_number":253,"context_line":"            if existing_vlun is None:"},{"line_number":254,"context_line":"                # now that we have a host, create the VLUN"},{"line_number":255,"context_line":"                if self.lookup_service is not None and numPaths \u003d\u003d 1:"},{"line_number":256,"context_line":"                    nsp \u003d None"},{"line_number":257,"context_line":"                    active_fc_port_list \u003d self._get_active_fc_target_ports(cl)"},{"line_number":258,"context_line":"                    for port in active_fc_port_list:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_2f22f0bb","line":255,"range":{"start_line":255,"start_character":19,"end_line":255,"end_character":50},"updated":"2019-08-08 12:39:06.000000000","message":"Trivial suggestion only - Could just be \"if self.lookup_service and numPaths \u003d\u003d 1\".","commit_id":"c1e197b669db357eab89fbf6e0d3ba00b7e7d263"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b0beeb2d4fd042fd668263aca6470566dbf9c61e","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"                    failover_target \u003d common._replication_targets[0]"},{"line_number":314,"context_line":"                    replication_mode \u003d failover_target[\u0027replication_mode\u0027]"},{"line_number":315,"context_line":"                    quorum_witness_ip \u003d \\"},{"line_number":316,"context_line":"                        failover_target.get(\u0027quorum_witness_ip\u0027, None)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"                    if replication_mode \u003d\u003d 1 and quorum_witness_ip:"},{"line_number":319,"context_line":"                        LOG.info(\u0027Peer Persistence has been configured\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_cf1c7c79","line":316,"range":{"start_line":315,"start_character":20,"end_line":316,"end_character":70},"updated":"2019-08-08 12:39:06.000000000","message":"Same comments regarding \\ and get().","commit_id":"c1e197b669db357eab89fbf6e0d3ba00b7e7d263"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3f9ca277db310bd8b50d62797b1ac67a8d40498e","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    \"\"\""},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    VERSION \u003d \"4.0.5\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    # The name of the CI wiki page."},{"line_number":121,"context_line":"    CI_WIKI_NAME \u003d \"HPE_Storage_CI\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6113625d","line":118,"updated":"2019-08-20 15:18:13.000000000","message":"Please bump the version and history for this.  This is a new capability.","commit_id":"18946fc31d8ffa0641f732029d07f57b8774fae2"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3f9ca277db310bd8b50d62797b1ac67a8d40498e","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    \"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    VERSION \u003d \"4.0.2\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    # The name of the CI wiki page."},{"line_number":135,"context_line":"    CI_WIKI_NAME \u003d \"HPE_Storage_CI\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e128b286","line":132,"updated":"2019-08-20 15:18:13.000000000","message":"Please bump the version and history for this.","commit_id":"18946fc31d8ffa0641f732029d07f57b8774fae2"}]}
