)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7931f4c8604fe56e9d4a11a72a1ee146a801d489","unresolved":false,"context_lines":[{"line_number":238,"context_line":"          2.0.14 - Fix bug #1782588 qos settings on extend"},{"line_number":239,"context_line":"    \"\"\""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    VERSION \u003d \u00272.0.14\u0027"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    # ThirdPartySystems wiki page"},{"line_number":244,"context_line":"    CI_WIKI_NAME \u003d \"NetApp_SolidFire_CI\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_cb193ed1","line":241,"updated":"2019-08-16 21:09:10.000000000","message":"Shouldn\u0027t you update the version number and history?","commit_id":"97f283ed1d5dd092b51fa283114de8f8fffa131c"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"1cd9f6bce67ac9dd8a2aa826a7d11a349c79d50d","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        repl_configs \u003d repl_configs[0]"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        # Just in case the user is trying to do something really stupid"},{"line_number":405,"context_line":"        if repl_configs[\u0027mvip\u0027] \u003d\u003d self.configuration.san_ip:"},{"line_number":406,"context_line":"            msg \u003d _(\"Replication target and source are the same.\")"},{"line_number":407,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7880e2f7","line":404,"updated":"2019-08-22 19:51:35.000000000","message":"please remove this comment as it doesn\u0027t really help.","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"996025b975fed0489a82916d7e1669c7e89ee6a3","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        repl_configs \u003d repl_configs[0]"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        # Just in case the user is trying to do something really stupid"},{"line_number":405,"context_line":"        if repl_configs[\u0027mvip\u0027] \u003d\u003d self.configuration.san_ip:"},{"line_number":406,"context_line":"            msg \u003d _(\"Replication target and source are the same.\")"},{"line_number":407,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d62b897f","line":404,"in_reply_to":"7faddb67_4a8a53bc","updated":"2019-09-19 19:21:02.000000000","message":"Changed to you suggestion. Thanks!","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"f68a145542c11448e4c50420b28bc1a5b015d735","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        repl_configs \u003d repl_configs[0]"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        # Just in case the user is trying to do something really stupid"},{"line_number":405,"context_line":"        if repl_configs[\u0027mvip\u0027] \u003d\u003d self.configuration.san_ip:"},{"line_number":406,"context_line":"            msg \u003d _(\"Replication target and source are the same.\")"},{"line_number":407,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4a8a53bc","line":404,"in_reply_to":"7faddb67_7880e2f7","updated":"2019-09-01 02:52:17.000000000","message":"It helped me :). \nYeap, it does not make that sense as in the day It was wrote. It would better read as:\n# Check if the user is not using the same MVIP as source and replication target.","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"f68a145542c11448e4c50420b28bc1a5b015d735","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                   \u0027SolidFire API call.\u0027 % response[\u0027error\u0027][\u0027name\u0027])"},{"line_number":609,"context_line":"            LOG.debug(msg)"},{"line_number":610,"context_line":"            LOG.debug(\"API response: %s\", response)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"            raise SolidFireRetryableException(message\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if ((\u0027error\u0027 in response) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2a7b57bf","line":611,"updated":"2019-09-01 02:52:17.000000000","message":"Dont really need this line.","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"996025b975fed0489a82916d7e1669c7e89ee6a3","unresolved":false,"context_lines":[{"line_number":608,"context_line":"                   \u0027SolidFire API call.\u0027 % response[\u0027error\u0027][\u0027name\u0027])"},{"line_number":609,"context_line":"            LOG.debug(msg)"},{"line_number":610,"context_line":"            LOG.debug(\"API response: %s\", response)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"            raise SolidFireRetryableException(message\u003dmsg)"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        if ((\u0027error\u0027 in response) and"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f6b8052b","line":611,"in_reply_to":"7faddb67_2a7b57bf","updated":"2019-09-19 19:21:02.000000000","message":"Removed.","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"f68a145542c11448e4c50420b28bc1a5b015d735","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            if backing_file is not None:"},{"line_number":1080,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1081,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1082,"context_line":"                    reason\u003d_("},{"line_number":1083,"context_line":"                        \"fmt\u003d%(fmt)s backed by:%(backing_file)s\") % {"},{"line_number":1084,"context_line":"                        \u0027fmt\u0027: fmt, \u0027backing_file\u0027: backing_file, })"},{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"            virtual_size \u003d int(math.ceil(float(data.virtual_size) / units.Gi))"},{"line_number":1087,"context_line":"            attributes \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_5f32fea8","line":1084,"range":{"start_line":1082,"start_character":20,"end_line":1084,"end_character":68},"updated":"2019-09-01 02:52:17.000000000","message":"Would better avoid changes that does not have effect on the proposed solutions.","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"996025b975fed0489a82916d7e1669c7e89ee6a3","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            if backing_file is not None:"},{"line_number":1080,"context_line":"                raise exception.ImageUnacceptable("},{"line_number":1081,"context_line":"                    image_id\u003dimage_id,"},{"line_number":1082,"context_line":"                    reason\u003d_("},{"line_number":1083,"context_line":"                        \"fmt\u003d%(fmt)s backed by:%(backing_file)s\") % {"},{"line_number":1084,"context_line":"                        \u0027fmt\u0027: fmt, \u0027backing_file\u0027: backing_file, })"},{"line_number":1085,"context_line":""},{"line_number":1086,"context_line":"            virtual_size \u003d int(math.ceil(float(data.virtual_size) / units.Gi))"},{"line_number":1087,"context_line":"            attributes \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_566559e0","line":1084,"range":{"start_line":1082,"start_character":20,"end_line":1084,"end_character":68},"in_reply_to":"7faddb67_5f32fea8","updated":"2019-09-19 19:21:02.000000000","message":"This function was removed in patch. See https://review.opendev.org/#/c/664739/","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"f68a145542c11448e4c50420b28bc1a5b015d735","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"                        image_id\u003dimage_id,"},{"line_number":1131,"context_line":"                        reason\u003d_(\"Converted to %(vol_format)s, but format is \""},{"line_number":1132,"context_line":"                                 \"now %(file_format)s\") % {"},{"line_number":1133,"context_line":"                            \u0027vol_format\u0027: \u0027raw\u0027,"},{"line_number":1134,"context_line":"                            \u0027file_format\u0027: data.file_format})"},{"line_number":1135,"context_line":"            except Exception as exc:"},{"line_number":1136,"context_line":"                vol \u003d self._get_sf_volume(image_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ff22ca53","line":1133,"range":{"start_line":1133,"start_character":28,"end_line":1133,"end_character":48},"updated":"2019-09-01 02:52:17.000000000","message":"same","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"996025b975fed0489a82916d7e1669c7e89ee6a3","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"                        image_id\u003dimage_id,"},{"line_number":1131,"context_line":"                        reason\u003d_(\"Converted to %(vol_format)s, but format is \""},{"line_number":1132,"context_line":"                                 \"now %(file_format)s\") % {"},{"line_number":1133,"context_line":"                            \u0027vol_format\u0027: \u0027raw\u0027,"},{"line_number":1134,"context_line":"                            \u0027file_format\u0027: data.file_format})"},{"line_number":1135,"context_line":"            except Exception as exc:"},{"line_number":1136,"context_line":"                vol \u003d self._get_sf_volume(image_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b69b6dc7","line":1133,"range":{"start_line":1133,"start_character":28,"end_line":1133,"end_character":48},"in_reply_to":"7faddb67_ff22ca53","updated":"2019-09-19 19:21:02.000000000","message":"Same as the above","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"f68a145542c11448e4c50420b28bc1a5b015d735","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"        type_ref \u003d volume_types.get_volume_type(ctxt, type_id)"},{"line_number":1557,"context_line":"        specs \u003d type_ref.get(\u0027extra_specs\u0027)"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        # TODO(erlon): Ass support for sync/snapshot replication"},{"line_number":1560,"context_line":"        if specs.get(\u0027replication_enabled\u0027, \"\") \u003d\u003d \"\u003cis\u003e True\":"},{"line_number":1561,"context_line":"            rep_type \u003d \u0027Async\u0027"},{"line_number":1562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1f280631","line":1559,"range":{"start_line":1559,"start_character":23,"end_line":1559,"end_character":26},"updated":"2019-09-01 02:52:17.000000000","message":"Add","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"996025b975fed0489a82916d7e1669c7e89ee6a3","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"        type_ref \u003d volume_types.get_volume_type(ctxt, type_id)"},{"line_number":1557,"context_line":"        specs \u003d type_ref.get(\u0027extra_specs\u0027)"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        # TODO(erlon): Ass support for sync/snapshot replication"},{"line_number":1560,"context_line":"        if specs.get(\u0027replication_enabled\u0027, \"\") \u003d\u003d \"\u003cis\u003e True\":"},{"line_number":1561,"context_line":"            rep_type \u003d \u0027Async\u0027"},{"line_number":1562,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d69e29b7","line":1559,"range":{"start_line":1559,"start_character":23,"end_line":1559,"end_character":26},"in_reply_to":"7faddb67_1f280631","updated":"2019-09-19 19:21:02.000000000","message":"fixed :)","commit_id":"c16cc2f09d7fe214acd6cabc7e856f3604668775"}]}