)]}'
{"id":"openstack%2Fcinder~67607","triplet_id":"openstack%2Fcinder~master~Ia2d96086865c346ea1d5e85a655412ac12cf7372","project":"openstack/cinder","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"Ia2d96086865c346ea1d5e85a655412ac12cf7372","subject":"replace assertTrue(isinstance) to assertIsInstance","status":"ABANDONED","created":"2014-01-18 01:15:23.000000000","updated":"2014-01-21 14:29:53.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d0a1ad7d1ef8e9d4f6ff9a1faa16f26b01e31250","_number":67607,"virtual_id_number":67607,"owner":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":1,"date":"2014-01-21 05:41:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"all":[{"value":1,"date":"2014-01-21 11:49:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"date":"2014-01-18 03:37:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":2,"date":"2014-01-21 09:36:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2014-01-21 12:59:06.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"date":"2014-01-21 09:36:40.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-01-21 12:59:06.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-21 05:41:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-01-21 09:36:40.000000000","updated_by":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"reviewer":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"state":"REVIEWER"},{"updated":"2014-01-21 11:49:52.000000000","updated_by":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"reviewer":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"state":"REVIEWER"},{"updated":"2014-01-21 12:59:06.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"}],"messages":[{"id":"21c158fe90be44c1b098654d674bf57f10f4f757","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-18 03:26:48.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-pep8 http://logs.openstack.org/07/67607/1/check/gate-cinder-pep8/83d9aa1 : SUCCESS in 3m 32s\n- gate-cinder-docs http://docs-draft.openstack.org/07/67607/1/check/gate-cinder-docs/af43dc0/doc/build/html/ : SUCCESS in 5m 43s\n- gate-cinder-python26 http://logs.openstack.org/07/67607/1/check/gate-cinder-python26/a52d84f : SUCCESS in 5m 53s\n- gate-cinder-python27 http://logs.openstack.org/07/67607/1/check/gate-cinder-python27/d85be18 : SUCCESS in 5m 07s\n- gate-cinder-pylint http://logs.openstack.org/07/67607/1/check/gate-cinder-pylint/e4a830a : SUCCESS in 4m 49s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-full/d79a7c0 : SUCCESS in 58m 28s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-postgres-full/b8f88c2 : SUCCESS in 59m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-neutron/1ef38c5 : SUCCESS in 47m 51s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-large-ops/bf2b5cb : FAILURE in 11m 59s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-neutron-large-ops/e754b28 : SUCCESS in 13m 41s\n- check-grenade-dsvm http://logs.openstack.org/07/67607/1/check/check-grenade-dsvm/af798c4 : SUCCESS in 31m 53s\n","accounts_in_message":[],"_revision_number":1},{"id":"2b70503acd53a6d8d3c2f41bccb9adb35a9d21cc","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2014-01-18 03:37:06.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"0c271bd86c981d35caea623bdfc7cfac5e7b3ce2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-18 05:10:46.000000000","message":"Patch Set 1:\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-cinder-pep8 http://logs.openstack.org/07/67607/1/check/gate-cinder-pep8/d76517f : SUCCESS in 4m 10s\n- gate-cinder-docs http://docs-draft.openstack.org/07/67607/1/check/gate-cinder-docs/5dc3dee/doc/build/html/ : SUCCESS in 6m 29s\n- gate-cinder-python26 http://logs.openstack.org/07/67607/1/check/gate-cinder-python26/07a9d3d : SUCCESS in 5m 56s\n- gate-cinder-python27 http://logs.openstack.org/07/67607/1/check/gate-cinder-python27/a5a9908 : SUCCESS in 5m 18s\n- gate-cinder-pylint http://logs.openstack.org/07/67607/1/check/gate-cinder-pylint/59493aa : SUCCESS in 4m 54s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-full/3f98fe5 : FAILURE in 1h 08m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-postgres-full/a506319 : FAILURE in 1h 02m 54s\n- check-tempest-dsvm-neutron http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-neutron/aa23f49 : SUCCESS in 38m 54s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-large-ops/e8e93aa : SUCCESS in 11m 34s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-neutron-large-ops/3ce5dec : SUCCESS in 13m 38s\n- check-grenade-dsvm http://logs.openstack.org/07/67607/1/check/check-grenade-dsvm/3e7c5cc : SUCCESS in 36m 56s\n","accounts_in_message":[],"_revision_number":1},{"id":"4a3b53f87d33ceb5c3574f8b4303316366d47a8c","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2014-01-21 02:16:56.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"16ff3f88b0c63c60a4b82342ff9edf9583f6fc3a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-21 05:41:04.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-cinder-pep8 http://logs.openstack.org/07/67607/1/check/gate-cinder-pep8/c11d836 : SUCCESS in 4m 09s\n- gate-cinder-docs http://docs-draft.openstack.org/07/67607/1/check/gate-cinder-docs/ec516d5/doc/build/html/ : SUCCESS in 7m 14s\n- gate-cinder-python26 http://logs.openstack.org/07/67607/1/check/gate-cinder-python26/b2a6930 : SUCCESS in 6m 03s\n- gate-cinder-python27 http://logs.openstack.org/07/67607/1/check/gate-cinder-python27/d2aff98 : SUCCESS in 6m 33s\n- gate-cinder-pylint http://logs.openstack.org/07/67607/1/check/gate-cinder-pylint/57f8dcc : SUCCESS in 5m 30s (non-voting)\n- check-tempest-dsvm-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-full/97f94a8 : SUCCESS in 57m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-postgres-full/c9b837e : SUCCESS in 1h 02m 00s\n- check-tempest-dsvm-neutron http://logs.openstack.org/07/67607/1/check/check-tempest-dsvm-neutron/e5417ee : SUCCESS in 33m 36s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-large-ops/68209fc : SUCCESS in 12m 44s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/07/67607/1/check/gate-tempest-dsvm-neutron-large-ops/d0e8b18 : SUCCESS in 13m 03s\n- check-grenade-dsvm http://logs.openstack.org/07/67607/1/check/check-grenade-dsvm/74d0805 : SUCCESS in 34m 37s\n","accounts_in_message":[],"_revision_number":1},{"id":"3244b49a780059bf96e8e7385c48f4b2e42da640","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2014-01-21 09:36:40.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9569c9b99480439fe136d6db6aa60f01933105fd","author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"date":"2014-01-21 11:49:46.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"cf1c3eb1c7c7b7fcf5c6f44b1370dda57ab868b8","author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"date":"2014-01-21 11:49:52.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1b7eabe38d30303bdfc59fe376b82306f0ebe321","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2014-01-21 12:59:06.000000000","message":"Patch Set 1: Do not merge\n\nCan we get this into our hacking tests? Otherwise we\u0027re going to keep having churn patches like this to do cleanups of relatively low value (they don\u0027t fix any bugs, they don\u0027t make the code substantially more readable, etc)","accounts_in_message":[],"_revision_number":1},{"id":"1d8c791c0072d556ebe0763b77929302b10998d5","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2014-01-21 14:16:23.000000000","message":"Patch Set 1: Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"87567d9a8c7ff4de4ea0c890cad6b6505ebe8465","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2014-01-21 14:29:53.000000000","message":"Patch Set 1:\n\nDuncan Thomas,I agree with you","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6500fb557e6713cae9434730928114c06941ddc5","revisions":{"6500fb557e6713cae9434730928114c06941ddc5":{"kind":"REWORK","_number":1,"created":"2014-01-18 01:15:23.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/07/67607/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/07/67607/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/07/67607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/07/67607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/07/67607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/07/67607/1"}}},"commit":{"parents":[{"commit":"ea9c59448e9f3d4652f8c7010965ffa25ca56804","subject":"Merge \"GlusterFS: Synchronize additional operations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/ea9c59448e9f3d4652f8c7010965ffa25ca56804"}]}],"author":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 01:11:36.000000000","tz":480},"committer":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 01:11:36.000000000","tz":480},"subject":"replace assertTrue(isinstance) to assertIsInstance","message":"replace assertTrue(isinstance) to assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: Ia2d96086865c346ea1d5e85a655412ac12cf7372\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/6500fb557e6713cae9434730928114c06941ddc5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/6500fb557e6713cae9434730928114c06941ddc5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
