)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0db21de970df196d815bec2b6157ab94341dc852","unresolved":false,"context_lines":[{"line_number":16,"context_line":"This is to remove them for code clean."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4ca1800363078da1869c48ac817ef9ca4a033d60"},{"line_number":19,"context_line":"partially-implements: blueprint cleanup-unused-helpers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_2d62aa17","line":19,"range":{"start_line":19,"start_character":21,"end_line":19,"end_character":54},"updated":"2019-08-13 17:24:58.000000000","message":"We don\u0027t need a blueprint for cleaning up unused code, let\u0027s just close this out and remove it from the commit message here.","commit_id":"0d223a47aa53007de8ab7498423cbbd1ad181656"}],"cinder/volume/group_types.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0db21de970df196d815bec2b6157ab94341dc852","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    return group_type[\u0027is_public\u0027]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"def add_group_type_access(context, group_type_id, project_id):"},{"line_number":188,"context_line":"    \"\"\"Add access to group type for project_id.\"\"\""},{"line_number":189,"context_line":"    if group_type_id is None:"},{"line_number":190,"context_line":"        msg \u003d _(\"group_type_id cannot be None\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_edb6d28a","line":187,"range":{"start_line":187,"start_character":4,"end_line":187,"end_character":25},"updated":"2019-08-13 17:24:58.000000000","message":"Is this used?\n\nThis is concerning... do we know the context of what\u0027s going on with this code?","commit_id":"0d223a47aa53007de8ab7498423cbbd1ad181656"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fd98ae16c5925f4756c52b0db88b0b7a9f9a5e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_ad68dab9","line":199,"updated":"2019-08-13 16:37:53.000000000","message":"remove this line as well","commit_id":"0d223a47aa53007de8ab7498423cbbd1ad181656"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d5a545be6d6a4b9f7b17c4ff9b468b40d6d7855c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        return group_specs"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def is_public_group_type(context, group_type_id):"},{"line_number":182,"context_line":"    \"\"\"Return is_public boolean value of group type\"\"\""},{"line_number":183,"context_line":"    group_type \u003d db.group_type_get(context, group_type_id)"},{"line_number":184,"context_line":"    return group_type[\u0027is_public\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_8f770b3c","line":184,"range":{"start_line":181,"start_character":0,"end_line":184,"end_character":34},"updated":"2019-08-14 05:16:38.000000000","message":"Since this method was used in add/remove group type access,\nthis also isn\u0027t used anymore, i think we need to discuss the validity of group type code to better know why these were implemented in the first place.","commit_id":"5c185e6587476c108671de562d137b2477ede0f7"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f732f35b3642b6bb85a46b9fbaca9562a7ea803c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        return group_specs"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def is_public_group_type(context, group_type_id):"},{"line_number":182,"context_line":"    \"\"\"Return is_public boolean value of group type\"\"\""},{"line_number":183,"context_line":"    group_type \u003d db.group_type_get(context, group_type_id)"},{"line_number":184,"context_line":"    return group_type[\u0027is_public\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_af5a0780","line":184,"range":{"start_line":181,"start_character":0,"end_line":184,"end_character":34},"in_reply_to":"7faddb67_8f770b3c","updated":"2019-08-14 05:49:30.000000000","message":"oh, yes, removed now.\nMaybe in the original BP, we\u0027ll implement many helpers we think to be needed, but finally after three years some are still not used:)","commit_id":"5c185e6587476c108671de562d137b2477ede0f7"}]}