)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                    \"(1) multipath is not enabled in cinder.conf. \""},{"line_number":125,"context_line":"                    \"(2) Fiber Channel Zone Manager is not used. \""},{"line_number":126,"context_line":"                    \"(3) the 3PAR backend is prezoned with this \""},{"line_number":127,"context_line":"                    \" specific nsp only. \""},{"line_number":128,"context_line":"                    \"For example if nsp is 2 1 2, the format of the \""},{"line_number":129,"context_line":"                    \"option\u0027s value is 2:1:2\"),"},{"line_number":130,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3e7a8423","line":127,"range":{"start_line":127,"start_character":21,"end_line":127,"end_character":22},"updated":"2019-08-19 14:36:20.000000000","message":"Extra space. Maybe something to fix in master if something more significant is being done.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                initiator \u003d connector.get(\u0027wwpns\u0027)[0]"},{"line_number":182,"context_line":"                if user_target is None:"},{"line_number":183,"context_line":"                    target_wwns \u003d target_wwns[:1]"},{"line_number":184,"context_line":"                    init_targ_map[initiator] \u003d \\"},{"line_number":185,"context_line":"                        init_targ_map[initiator][:1]"},{"line_number":186,"context_line":"                else:"},{"line_number":187,"context_line":"                    target_wwns \u003d [user_target]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_7e99dc6a","line":184,"range":{"start_line":184,"start_character":47,"end_line":184,"end_character":48},"updated":"2019-08-19 14:36:20.000000000","message":"Another thing we should have caught on master.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        if not target_nsp:"},{"line_number":428,"context_line":"            return None"},{"line_number":429,"context_line":"        else:"},{"line_number":430,"context_line":"            # Get target wwn from target nsp"},{"line_number":431,"context_line":"            fc_ports \u003d common.get_active_fc_target_ports()"},{"line_number":432,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_dea7b0a7","line":429,"range":{"start_line":429,"start_character":7,"end_line":429,"end_character":13},"updated":"2019-08-19 14:36:20.000000000","message":"Else was not needed here since the if block returns.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":440,"context_line":"            if not target_wwn:"},{"line_number":441,"context_line":"                LOG.warning(\"Did not get wwn for target nsp: \""},{"line_number":442,"context_line":"                            \"%(nsp)s\", {\u0027nsp\u0027: target_nsp})"},{"line_number":443,"context_line":"                return None"},{"line_number":444,"context_line":"            else:"},{"line_number":445,"context_line":"                return target_wwn"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bebc34bb","line":444,"range":{"start_line":443,"start_character":16,"end_line":444,"end_character":17},"updated":"2019-08-19 14:36:20.000000000","message":"This all could have been skipped.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"}],"releasenotes/notes/hpe-3par-specify-nsp-for-fc-bootable-volume-f372879e1b625b4d.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This change fixes bug 1809249 - 3PAR driver picks wrong port when"},{"line_number":5,"context_line":"    not in multipath mode. Now the user can specify target NSP (Node-"},{"line_number":6,"context_line":"    Slot-Port) in cinder.conf. This information is used to create"},{"line_number":7,"context_line":"    initiator target map accordingly. And then bootable volume is"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_ded570e7","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":15},"updated":"2019-08-19 14:36:20.000000000","message":"\"This change\" doesn\u0027t make sense in the release notes as they are just a long list of statements without the context of being part of an individual patchset.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06f3bf0d3f9109957f25dc72699f996c831ca749","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    not in multipath mode. Now the user can specify target NSP (Node-"},{"line_number":6,"context_line":"    Slot-Port) in cinder.conf. This information is used to create"},{"line_number":7,"context_line":"    initiator target map accordingly. And then bootable volume is"},{"line_number":8,"context_line":"    created successfully."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_fed2acfc","line":8,"updated":"2019-08-19 14:36:20.000000000","message":"This should also state what the new config option is that was added so the deployer knows what they need to set.","commit_id":"077a8df29a5fdfa01aaf88b91469d147c3f01584"}]}