)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30843,"name":"Ondrej Melichar","email":"melichar@ics.muni.cz"},"change_message_id":"9c540dd7000742f4a8787d9d89fbce97c9cb860c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Hill \u003cdhill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-20 07:50:54 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use desination id instead of source id in snapshot temp name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use desintation id instead of source id in snapshot temp name as"},{"line_number":10,"context_line":"this will prevent concurrency due to file system requirement of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7faddb67_a005d811","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":14},"updated":"2019-08-20 13:07:38.000000000","message":"I think you meant \"destination\".","commit_id":"1502bfc8c6b038667b3ab6a49aa2b676291d52e9"},{"author":{"_account_id":30843,"name":"Ondrej Melichar","email":"melichar@ics.muni.cz"},"change_message_id":"9c540dd7000742f4a8787d9d89fbce97c9cb860c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use desination id instead of source id in snapshot temp name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use desintation id instead of source id in snapshot temp name as"},{"line_number":10,"context_line":"this will prevent concurrency due to file system requirement of"},{"line_number":11,"context_line":"having unique file names."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7faddb67_c0081428","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":15},"updated":"2019-08-20 13:07:38.000000000","message":"same","commit_id":"1502bfc8c6b038667b3ab6a49aa2b676291d52e9"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d0e4ace43b2168f8d2104f9a2b2a326a42af57a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Takashi Kajinami \u003ctkajinam@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-10 20:02:10 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use destination id instead of source id in snapshot temp name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use destintation id instead of source id in snapshot temp name as"},{"line_number":10,"context_line":"this will prevent concurrency due to file system requirement of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_0e214cfd","line":7,"updated":"2019-11-06 02:49:29.000000000","message":"nit: It\u0027s usually best to describe the what instead of the how.  For example: \"Fix remotefs clone concurrency issue\"","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d0e4ace43b2168f8d2104f9a2b2a326a42af57a5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use destination id instead of source id in snapshot temp name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use destintation id instead of source id in snapshot temp name as"},{"line_number":10,"context_line":"this will prevent concurrency due to file system requirement of"},{"line_number":11,"context_line":"having unique file names."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5bd185d04dbda673a5882d61aaab7acdd99b74a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_ae1d98bf","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":29},"updated":"2019-11-06 02:49:29.000000000","message":"nit: concurrency issues","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"}],"cinder/volume/drivers/remotefs.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c47d7774653bdc2e88e088233f05b677a71a0150","unresolved":false,"context_lines":[{"line_number":1057,"context_line":""},{"line_number":1058,"context_line":"            temp_snapshot \u003d Snapshot(volume_name\u003dvolume_name,"},{"line_number":1059,"context_line":"                                     volume_size\u003dsrc_vref.size,"},{"line_number":1060,"context_line":"                                     name\u003d\u0027clone-snap-%s\u0027 % volume.id,"},{"line_number":1061,"context_line":"                                     volume_id\u003dsrc_vref.id,"},{"line_number":1062,"context_line":"                                     id\u003d\u0027tmp-snap-%s\u0027 % volume.id,"},{"line_number":1063,"context_line":"                                     volume\u003dsrc_vref)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_4fd45a20","line":1060,"range":{"start_line":1060,"start_character":37,"end_line":1060,"end_character":70},"updated":"2019-08-20 07:31:32.000000000","message":"unit tests should be fixed accordingly.\nCurrently the following tests are failing.\n\ncinder.tests.unit.volume.drivers.test_remotefs.RemoteFsSnapDriverTestCase.test_create_cloned_volume_2\ncinder.tests.unit.volume.drivers.test_remotefs.RemoteFsSnapDriverTestCase.test_create_cloned_volume_3","commit_id":"8ddbc82aed58cb3e988fdb09a12ab6f8931246fe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c47d7774653bdc2e88e088233f05b677a71a0150","unresolved":false,"context_lines":[{"line_number":1296,"context_line":"        # the next step will also fail.   This should fail at this point,"},{"line_number":1297,"context_line":"        # snapshot should be aborted and everything reverted."},{"line_number":1298,"context_line":"        try:"},{"line_number":1299,"context_line":"          self._execute(*command, run_as_root\u003dself._execute_as_root)"},{"line_number":1300,"context_line":"        except Exception as exc:"},{"line_number":1301,"context_line":"          LOG.debug(exc)"},{"line_number":1302,"context_line":"          raise"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_cff92ac8","line":1299,"range":{"start_line":1299,"start_character":8,"end_line":1299,"end_character":10},"updated":"2019-08-20 07:31:32.000000000","message":"indentation should be fixed to avoid pep8 errors","commit_id":"8ddbc82aed58cb3e988fdb09a12ab6f8931246fe"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"c47d7774653bdc2e88e088233f05b677a71a0150","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        # snapshot should be aborted and everything reverted."},{"line_number":1298,"context_line":"        try:"},{"line_number":1299,"context_line":"          self._execute(*command, run_as_root\u003dself._execute_as_root)"},{"line_number":1300,"context_line":"        except Exception as exc:"},{"line_number":1301,"context_line":"          LOG.debug(exc)"},{"line_number":1302,"context_line":"          raise"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        command \u003d [\u0027qemu-img\u0027, \u0027rebase\u0027, \u0027-u\u0027,"},{"line_number":1305,"context_line":"                   \u0027-b\u0027, backing_filename,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_0fa8a289","line":1302,"range":{"start_line":1300,"start_character":0,"end_line":1302,"end_character":15},"updated":"2019-08-20 07:31:32.000000000","message":"I\u0027m not sure about the reason why we need this, because\n\n- If we get exceptions in _execute, the raised exception should be passed to upper layers, without any reraise\n\n- Executiong logs are recorded in oslo.concurrency level, and recording again here seems to be too much.","commit_id":"8ddbc82aed58cb3e988fdb09a12ab6f8931246fe"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"4a9b0bd1185e84d0a9d39258e385f68654e50f89","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        # snapshot should be aborted and everything reverted."},{"line_number":1298,"context_line":"        try:"},{"line_number":1299,"context_line":"          self._execute(*command, run_as_root\u003dself._execute_as_root)"},{"line_number":1300,"context_line":"        except Exception as exc:"},{"line_number":1301,"context_line":"          LOG.debug(exc)"},{"line_number":1302,"context_line":"          raise"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        command \u003d [\u0027qemu-img\u0027, \u0027rebase\u0027, \u0027-u\u0027,"},{"line_number":1305,"context_line":"                   \u0027-b\u0027, backing_filename,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_f2140aa2","line":1302,"range":{"start_line":1300,"start_character":0,"end_line":1302,"end_character":15},"in_reply_to":"7faddb67_0fa8a289","updated":"2019-08-20 11:39:20.000000000","message":"Well the problem is that somehow, the first qemu-img create failed and we still tried executing the qemu-img convert ... this is not expected and it should have failed before imho ... or something deleted the successfully create file in \"qemu-img create\" and brought us in a weird state where we\u0027re loop on \"qemu-img info\" on a missing file.","commit_id":"8ddbc82aed58cb3e988fdb09a12ab6f8931246fe"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b955e42784119d480f3be88e886fc44761ade66a","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1059,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1060,"context_line":"                \u0027volume_size\u0027: src_vref.size,"},{"line_number":1061,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % volume.id,"},{"line_number":1062,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1063,"context_line":"                \u0027volume_type_id\u0027: src_vref.volume_type_id,"},{"line_number":1064,"context_line":"                \u0027encryption_key_id\u0027: src_vref.encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_5c0be522","line":1061,"updated":"2019-09-13 14:23:53.000000000","message":"I\u0027m not sure how this achieves the goal here -- isn\u0027t the filename used for the temp snapshot generated based on the snapshot id in _get_new_snap_path() and not by using the display_name?","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"0f836cde854528d6751cce0a93a068e85b9bc312","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1059,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1060,"context_line":"                \u0027volume_size\u0027: src_vref.size,"},{"line_number":1061,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % volume.id,"},{"line_number":1062,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1063,"context_line":"                \u0027volume_type_id\u0027: src_vref.volume_type_id,"},{"line_number":1064,"context_line":"                \u0027encryption_key_id\u0027: src_vref.encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_efbfeecd","line":1061,"in_reply_to":"3fa7e38b_2051a5d9","updated":"2019-10-03 11:48:30.000000000","message":"Yes there was and now it says I can\u0027t upload merges or something like that.","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dbc1a491d98cd672014130cf6b158e22036a25bb","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1059,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1060,"context_line":"                \u0027volume_size\u0027: src_vref.size,"},{"line_number":1061,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % volume.id,"},{"line_number":1062,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1063,"context_line":"                \u0027volume_type_id\u0027: src_vref.volume_type_id,"},{"line_number":1064,"context_line":"                \u0027encryption_key_id\u0027: src_vref.encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_2051a5d9","line":1061,"in_reply_to":"3fa7e38b_8b93ee4f","updated":"2019-09-17 16:58:13.000000000","message":"But this is now the only change that this patch makes -- was there an error in rebasing?","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"5fb246b835fd2dfc1ed7a30e55a9d8007df7b6c0","unresolved":false,"context_lines":[{"line_number":1058,"context_line":"                \u0027status\u0027: fields.SnapshotStatus.CREATING,"},{"line_number":1059,"context_line":"                \u0027progress\u0027: \u00270%\u0027,"},{"line_number":1060,"context_line":"                \u0027volume_size\u0027: src_vref.size,"},{"line_number":1061,"context_line":"                \u0027display_name\u0027: \u0027tmp-snap-%s\u0027 % volume.id,"},{"line_number":1062,"context_line":"                \u0027display_description\u0027: None,"},{"line_number":1063,"context_line":"                \u0027volume_type_id\u0027: src_vref.volume_type_id,"},{"line_number":1064,"context_line":"                \u0027encryption_key_id\u0027: src_vref.encryption_key_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"3fa7e38b_8b93ee4f","line":1061,"in_reply_to":"5faad753_5c0be522","updated":"2019-09-16 21:15:38.000000000","message":"I thought having display_name using the same id as the temp file would help troubleshooting.  I reverted it but if you want me to revert the revertion, just let me know.","commit_id":"31632797b03b9baa7c9ee171c90401a8ea251a95"}]}