)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11920a2f2c12c26c6924876f3e874711ffea533f","unresolved":false,"context_lines":[{"line_number":5373,"context_line":"                    \u0027ServiceLevel\u0027: sl, \u0027Workload\u0027: wl,"},{"line_number":5374,"context_line":"                    \u0027Emulation\u0027: vol_header[\u0027emulationType\u0027],"},{"line_number":5375,"context_line":"                    \u0027Configuration\u0027: vol_header[\u0027configuration\u0027],"},{"line_number":5376,"context_line":"                    \u0027CompressionDisabled\u0027: cd}"},{"line_number":5377,"context_line":""},{"line_number":5378,"context_line":"        is_rep_enabled \u003d vol_info[\u0027rdfInfo\u0027][\u0027RDF\u0027]"},{"line_number":5379,"context_line":"        if is_rep_enabled:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_ea52f53a","line":5376,"range":{"start_line":5376,"start_character":20,"end_line":5376,"end_character":45},"updated":"2019-09-25 21:19:28.000000000","message":"This is pretty weird, because when cd \u003d\u003d \u0027False\u0027, bool(metadata[\u0027CompressionDisabled\u0027]) \u003d\u003d True.  But this does preserve the current behavior, so I guess it\u0027s OK.  Just pointing it out for awareness.","commit_id":"f1eb128c821c257ab035518f34b7df269eaa7cdd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11920a2f2c12c26c6924876f3e874711ffea533f","unresolved":false,"context_lines":[{"line_number":5374,"context_line":"                    \u0027Emulation\u0027: vol_header[\u0027emulationType\u0027],"},{"line_number":5375,"context_line":"                    \u0027Configuration\u0027: vol_header[\u0027configuration\u0027],"},{"line_number":5376,"context_line":"                    \u0027CompressionDisabled\u0027: cd}"},{"line_number":5377,"context_line":""},{"line_number":5378,"context_line":"        is_rep_enabled \u003d vol_info[\u0027rdfInfo\u0027][\u0027RDF\u0027]"},{"line_number":5379,"context_line":"        if is_rep_enabled:"},{"line_number":5380,"context_line":"            rdf_info \u003d vol_info[\u0027rdfInfo\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2a29ed99","line":5377,"updated":"2019-09-25 21:19:28.000000000","message":"OK, I see that you handle this by using strutils.bool_from_string at https://review.opendev.org/#/c/677473/9/cinder/volume/drivers/dell_emc/powermax/utils.py@383","commit_id":"f1eb128c821c257ab035518f34b7df269eaa7cdd"}],"cinder/volume/drivers/dell_emc/powermax/metadata.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"aec8022d4ff771e53df561673a9db3527353a217","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder.objects import volume"},{"line_number":24,"context_line":"from cinder import version"},{"line_number":25,"context_line":"from cinder.volume.drivers.dell_emc.powermax import utils"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"CLEANUP_LIST \u003d [\u0027masking_view\u0027, \u0027child_storage_group\u0027, \u0027parent_storage_group\u0027,"},{"line_number":29,"context_line":"                \u0027initiator_group\u0027, \u0027port_group\u0027, \u0027storage_group\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_8c050fc5","line":26,"updated":"2019-09-19 12:32:36.000000000","message":"This should not have been moved. It was correct between the standard lib imports and the local imports.","commit_id":"d620bd7cd115e6d2f2b50dbccc6aacdd37a6fcd4"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"3ec8c8ee2a4fb9af21c1b395f4acf5e7c7b93286","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinder.objects import volume"},{"line_number":24,"context_line":"from cinder import version"},{"line_number":25,"context_line":"from cinder.volume.drivers.dell_emc.powermax import utils"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":"CLEANUP_LIST \u003d [\u0027masking_view\u0027, \u0027child_storage_group\u0027, \u0027parent_storage_group\u0027,"},{"line_number":29,"context_line":"                \u0027initiator_group\u0027, \u0027port_group\u0027, \u0027storage_group\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_3bf44bcf","line":26,"in_reply_to":"3fa7e38b_8c050fc5","updated":"2019-09-19 16:02:42.000000000","message":"Sure, no problem, we will change it back","commit_id":"d620bd7cd115e6d2f2b50dbccc6aacdd37a6fcd4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11920a2f2c12c26c6924876f3e874711ffea533f","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinder.objects import volume"},{"line_number":26,"context_line":"from cinder import version"},{"line_number":27,"context_line":"from cinder.volume.drivers.dell_emc.powermax import utils"},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":"CLEANUP_LIST \u003d [\u0027masking_view\u0027, \u0027child_storage_group\u0027, \u0027parent_storage_group\u0027,"},{"line_number":30,"context_line":"                \u0027initiator_group\u0027, \u0027port_group\u0027, \u0027storage_group\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_ca9619f1","line":27,"updated":"2019-09-25 21:19:28.000000000","message":"Nit: there should be a blank line between 27 and 28 (though I notice these files aren\u0027t consistent, so you may want to check the style guide.)","commit_id":"f1eb128c821c257ab035518f34b7df269eaa7cdd"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11920a2f2c12c26c6924876f3e874711ffea533f","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        \"\"\""},{"line_number":382,"context_line":"        do_disable_compression \u003d False"},{"line_number":383,"context_line":"        if (DISABLECOMPRESSION in extra_specs and strutils.bool_from_string("},{"line_number":384,"context_line":"                extra_specs[DISABLECOMPRESSION])) or not extra_specs.get(SLO):"},{"line_number":385,"context_line":"            do_disable_compression \u003d True"},{"line_number":386,"context_line":"        return do_disable_compression"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_2adfadd6","line":384,"updated":"2019-09-25 21:19:28.000000000","message":"Nit: you could use extra_specs.get() here on DISABLE_COMPRESSION like you do on SLO to simplify the expression","commit_id":"f1eb128c821c257ab035518f34b7df269eaa7cdd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11920a2f2c12c26c6924876f3e874711ffea533f","unresolved":false,"context_lines":[{"line_number":972,"context_line":"                message\u003dexception_message)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    @staticmethod"},{"line_number":975,"context_line":"    def get_service_level_workload(extra_specs):"},{"line_number":976,"context_line":"        \"\"\"Get the service level and workload combination from extra specs."},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"        :param extra_specs: extra specifications"}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_8ab58180","line":975,"updated":"2019-09-25 21:19:28.000000000","message":"Nit: if you named this \u0027get_service_level_and_workload\u0027 it would be more obvious that it returns two values.","commit_id":"f1eb128c821c257ab035518f34b7df269eaa7cdd"}]}