)]}'
{"cinder/tests/unit/targets/test_scst_driver.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c7a6a2ae932262ab22046a43a6e971a5f3cb3124","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                \u0027ed2c2222-5fc0-11e4-aa15-123b93f75cba\u0027,"},{"line_number":233,"context_line":"                0, 1, self.fake_volumes_dir, None)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_iscsi_location(self):"},{"line_number":236,"context_line":"        # location \u003d self.target._iscsi_location(\u0027portal\u0027, 1, \u0027target\u0027, 2)"},{"line_number":237,"context_line":"        # self.assertEqual(\u0027portal:3260,1 target 2\u0027, location)"},{"line_number":238,"context_line":"        pass"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_iscsi_location_IPv6(self):"},{"line_number":241,"context_line":"        ip \u003d \u0027fd00:fd00:fd00:3000::12\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_0905cd10","line":238,"range":{"start_line":235,"start_character":0,"end_line":238,"end_character":12},"updated":"2019-08-22 10:43:11.000000000","message":"is this needed?","commit_id":"39c923a919a53ad35e4dc5660659ee7c332f7cb7"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"544ccb6d5cc20321355d59e08eb289f176dc2085","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                \u0027ed2c2222-5fc0-11e4-aa15-123b93f75cba\u0027,"},{"line_number":233,"context_line":"                0, 1, self.fake_volumes_dir, None)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def test_iscsi_location(self):"},{"line_number":236,"context_line":"        # location \u003d self.target._iscsi_location(\u0027portal\u0027, 1, \u0027target\u0027, 2)"},{"line_number":237,"context_line":"        # self.assertEqual(\u0027portal:3260,1 target 2\u0027, location)"},{"line_number":238,"context_line":"        pass"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def test_iscsi_location_IPv6(self):"},{"line_number":241,"context_line":"        ip \u003d \u0027fd00:fd00:fd00:3000::12\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_10aba91e","line":238,"range":{"start_line":235,"start_character":0,"end_line":238,"end_character":12},"in_reply_to":"7faddb67_0905cd10","updated":"2019-08-22 16:12:54.000000000","message":"I forgot to remove the comments, good catch!","commit_id":"39c923a919a53ad35e4dc5660659ee7c332f7cb7"}],"cinder/volume/utils.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"e91a4e5c59914d52588cfa9c638731dd0cbe7c78","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"    return encryption"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"def sanitize_host(host):"},{"line_number":1212,"context_line":"    \"\"\"Ensure IPv6 addresses are enclosed in [] for iSCSI portals.\"\"\""},{"line_number":1213,"context_line":"    if netutils.is_valid_ipv6(host):"},{"line_number":1214,"context_line":"        return \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_87130b5c","line":1211,"updated":"2019-08-20 18:34:59.000000000","message":"Not recommending a change, but just for comparison purposes:\n\nhttps://github.com/openstack/manila/blob/master/manila/share/drivers/helpers.py#L184","commit_id":"6bc6d2ef4cf139c62738e0bac597c30df192b633"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"df3864e759eff6d4a110e35686aae814c3c7967c","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"    return encryption"},{"line_number":1209,"context_line":""},{"line_number":1210,"context_line":""},{"line_number":1211,"context_line":"def sanitize_host(host):"},{"line_number":1212,"context_line":"    \"\"\"Ensure IPv6 addresses are enclosed in [] for iSCSI portals.\"\"\""},{"line_number":1213,"context_line":"    if netutils.is_valid_ipv6(host):"},{"line_number":1214,"context_line":"        return \u0027[%s]\u0027 % host"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8934764a","line":1211,"in_reply_to":"7faddb67_87130b5c","updated":"2019-08-21 09:47:36.000000000","message":"Thanks for the reference.  I\u0027d rather stick with this code as it looks clearer and cleaner to me.  :-)","commit_id":"6bc6d2ef4cf139c62738e0bac597c30df192b633"}]}