)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eb11d624988b70d67290e32dfbc15e2fe5554392","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[api-ref]control_location should be mandatory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"control_location in encryption type interfaces should be mandatory"},{"line_number":10,"context_line":"except for update interface, and, since it\u0027s mandatory, it shouldn\u0027t"},{"line_number":11,"context_line":"have default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_810189b8","line":11,"range":{"start_line":10,"start_character":34,"end_line":11,"end_character":19},"updated":"2019-08-22 20:09:25.000000000","message":"I\u0027m not sure the co-relation being made between a mandatory field and it not having a default value.","commit_id":"a7de79074b1d72ef962108dcaa96156d52dfdf69"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7a651bcfcbe8de2fc9360075e648c44c0112ee21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[api-ref]control_location should be mandatory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"control_location in encryption type interfaces should be mandatory"},{"line_number":10,"context_line":"except for update interface, and, since it\u0027s mandatory, it shouldn\u0027t"},{"line_number":11,"context_line":"have default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_5e44c419","line":11,"range":{"start_line":10,"start_character":34,"end_line":11,"end_character":19},"in_reply_to":"7faddb67_1a009f35","updated":"2019-08-23 10:03:45.000000000","message":"I think my comment was regarding the client code where the control_location field is optional and a default value is provided.\nYou\u0027re correct with respect to cinder API.\nI think we need to fix the gap between client and API here.","commit_id":"a7de79074b1d72ef962108dcaa96156d52dfdf69"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"e42b4c4638f5b6432f447a8f2d76f2dde7657763","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[api-ref]control_location should be mandatory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"control_location in encryption type interfaces should be mandatory"},{"line_number":10,"context_line":"except for update interface, and, since it\u0027s mandatory, it shouldn\u0027t"},{"line_number":11,"context_line":"have default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_1a009f35","line":11,"range":{"start_line":10,"start_character":34,"end_line":11,"end_character":19},"in_reply_to":"7faddb67_810189b8","updated":"2019-08-23 00:47:46.000000000","message":"I think \"default value\" means if a parameter is not passed, it will take the \"default value\", so for a mandatory field, we must pass the parameter in, which makes \"default value\" useless.","commit_id":"a7de79074b1d72ef962108dcaa96156d52dfdf69"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4fffe47401ac0ebb50e04ac9f5311cec3e2bba2e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ref:"},{"line_number":16,"context_line":"[1] https://github.com/openstack/cinder/blob/7bb05f327aa207573246f8ab356e2565c7c805b0/cinder/api/schemas/volume_type_encryption.py"},{"line_number":17,"context_line":"[2]  https://github.com/openstack/cinder/blob/7bb05f327aa207573246f8ab356e2565c7c805b0/cinder/api/contrib/volume_type_encryption.py"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"partially-implements: blueprint volume-response-schema-validation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_d3993b6e","line":16,"updated":"2019-09-11 14:50:08.000000000","message":"Please avoid linking to github in commit messages.  The Cinder project isn\u0027t hosted on github.","commit_id":"a7de79074b1d72ef962108dcaa96156d52dfdf69"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"deb0d97d18fc5df8966052ab04afca8d33ef50ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[api-ref]control_location should be mandatory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"control_location in encryption type interfaces should be mandatory"},{"line_number":10,"context_line":"except for update interface, and, since it\u0027s mandatory, it shouldn\u0027t"},{"line_number":11,"context_line":"have default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_642680ba","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"updated":"2020-04-20 18:02:59.000000000","message":"It would be a bit more informative to say:\n\ncontrol_location has been required in the POST /v3/{uid}/types/{tid}/encryption request body since schema validation was introduced in rocky.  Update the api-ref text to be accurate.","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f30883297698788e2b070cca8557021c3bd650eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[api-ref]control_location should be mandatory"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"control_location in encryption type interfaces should be mandatory"},{"line_number":10,"context_line":"except for update interface, and, since it\u0027s mandatory, it shouldn\u0027t"},{"line_number":11,"context_line":"have default value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"https://docs.openstack.org/api-ref/block-storage/v3/index.html?expanded\u003dupload-volume-to-image-detail,updates-volume-read-only-access-mode-flag-detail,create-an-encryption-type-detail#create-an-encryption-type"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_7a7f63aa","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":19},"in_reply_to":"1f493fa4_642680ba","updated":"2020-05-20 08:35:02.000000000","message":"Done","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"deb0d97d18fc5df8966052ab04afca8d33ef50ba","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Response-Head: {\u0027status\u0027: \u0027400\u0027, u\u0027content-length\u0027: \u0027100\u0027, u\u0027vary\u0027: \u0027OpenStack-API-Version\u0027, u\u0027server\u0027: \u0027IAG\u0027, u\u0027openstack-api-version\u0027: \u00273.0\u0027}"},{"line_number":23,"context_line":"                  Response-Body: {\"badRequest\": {\"message\": \"Invalid input received: control_location must be defined\", \"code\": 400}}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"partially-implements: blueprint volume-response-schema-validation"},{"line_number":26,"context_line":"Change-Id: I462186878ea8dc856575bca83d25fdcb6e008052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_24511810","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":65},"updated":"2020-04-20 18:02:59.000000000","message":"This patch doesn\u0027t seem relevant to that blueprint.  (I think it\u0027s a bug you discovered while working on the BP?)","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f30883297698788e2b070cca8557021c3bd650eb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Response-Head: {\u0027status\u0027: \u0027400\u0027, u\u0027content-length\u0027: \u0027100\u0027, u\u0027vary\u0027: \u0027OpenStack-API-Version\u0027, u\u0027server\u0027: \u0027IAG\u0027, u\u0027openstack-api-version\u0027: \u00273.0\u0027}"},{"line_number":23,"context_line":"                  Response-Body: {\"badRequest\": {\"message\": \"Invalid input received: control_location must be defined\", \"code\": 400}}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"partially-implements: blueprint volume-response-schema-validation"},{"line_number":26,"context_line":"Change-Id: I462186878ea8dc856575bca83d25fdcb6e008052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_5a7a5fb9","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":65},"in_reply_to":"1f493fa4_24511810","updated":"2020-05-20 08:35:02.000000000","message":"Done","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4c65db7a70323a4bbc194fcf2303dc26c9ae947c","unresolved":true,"context_lines":[{"line_number":21,"context_line":"                  Request-Body: {\"encryption\": {\"provider\": \"LuksEncryptor\"}}"},{"line_number":22,"context_line":"Response-Head: {\u0027status\u0027: \u0027400\u0027, u\u0027content-length\u0027: \u0027100\u0027, u\u0027vary\u0027: \u0027OpenStack-API-Version\u0027, u\u0027server\u0027: \u0027IAG\u0027, u\u0027openstack-api-version\u0027: \u00273.0\u0027}"},{"line_number":23,"context_line":"                  Response-Body: {\"badRequest\": {\"message\": \"Invalid input received: control_location must be defined\", \"code\": 400}}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I462186878ea8dc856575bca83d25fdcb6e008052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"60d8bdd9_f4f2bd4e","line":24,"updated":"2022-03-09 14:25:34.000000000","message":":-1: As far as I understood we need to add:\nCloses-Bug: #1964145","commit_id":"6fc69d7458457829f8934c682acb7be0070ed3e8"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a053154d32e273122a4a29c064ffe98ab8c6e527","unresolved":true,"context_lines":[{"line_number":21,"context_line":"                  Request-Body: {\"encryption\": {\"provider\": \"LuksEncryptor\"}}"},{"line_number":22,"context_line":"Response-Head: {\u0027status\u0027: \u0027400\u0027, u\u0027content-length\u0027: \u0027100\u0027, u\u0027vary\u0027: \u0027OpenStack-API-Version\u0027, u\u0027server\u0027: \u0027IAG\u0027, u\u0027openstack-api-version\u0027: \u00273.0\u0027}"},{"line_number":23,"context_line":"                  Response-Body: {\"badRequest\": {\"message\": \"Invalid input received: control_location must be defined\", \"code\": 400}}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I462186878ea8dc856575bca83d25fdcb6e008052"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f14f81cf_89598a89","line":24,"in_reply_to":"60d8bdd9_f4f2bd4e","updated":"2022-03-09 15:05:43.000000000","message":"Ignore this. That bug needs a new patch.","commit_id":"6fc69d7458457829f8934c682acb7be0070ed3e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"74c54fb1632f26593b3d1c9eda1c6224e15c2216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2cfbd140_d9f48a6d","updated":"2022-02-18 14:38:05.000000000","message":"Couldn\u0027t the fact that this value is required, despite it may just use a default value, be considered as a bug and fixed in the code instead?","commit_id":"6fc69d7458457829f8934c682acb7be0070ed3e8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63d6342cecf56c27e2b8dcd133d4c0f8b5b3a276","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3db251b7_0fc2e9ee","updated":"2022-03-10 02:20:29.000000000","message":"We discussed this at the cinder bug squad meeting today and concluded that instead of changing the api-ref, we\u0027ll change the code to do what the docs currently say.  This is backward compatible and won\u0027t require a new microversion because it\u0027s a widening change, that is, all requests that previously succeeded will continue to succeed when the \"optional\" control_location is included in the request.","commit_id":"6fc69d7458457829f8934c682acb7be0070ed3e8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a52bdd908d066b23c03f3e316e4b60bde992a7dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"067800fc_5bff371e","in_reply_to":"2cfbd140_d9f48a6d","updated":"2022-03-08 15:42:11.000000000","message":"Yes, I think this is a good idea -- \"front-end\" is used almost all of the time, we should just default to this.\n\nFiled this as a bug:\n    https://bugs.launchpad.net/cinder/+bug/1964145","commit_id":"6fc69d7458457829f8934c682acb7be0070ed3e8"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"deb0d97d18fc5df8966052ab04afca8d33ef50ba","unresolved":false,"context_lines":[{"line_number":828,"context_line":"control_location_optional:"},{"line_number":829,"context_line":"  description: |"},{"line_number":830,"context_line":"    Notional service where encryption is performed. Valid values are"},{"line_number":831,"context_line":"    \"front-end\" or \"back-end\". The default value is \"front-end\"."},{"line_number":832,"context_line":"  in: body"},{"line_number":833,"context_line":"  required: false"},{"line_number":834,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f493fa4_01ab2e1d","line":831,"range":{"start_line":831,"start_character":30,"end_line":831,"end_character":64},"updated":"2020-04-20 18:02:59.000000000","message":"There\u0027s no default value here, either.  If the control_location is included, the schema forces the user to pick one of the values from the enum.  (Same thing for v2)","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"f30883297698788e2b070cca8557021c3bd650eb","unresolved":false,"context_lines":[{"line_number":828,"context_line":"control_location_optional:"},{"line_number":829,"context_line":"  description: |"},{"line_number":830,"context_line":"    Notional service where encryption is performed. Valid values are"},{"line_number":831,"context_line":"    \"front-end\" or \"back-end\". The default value is \"front-end\"."},{"line_number":832,"context_line":"  in: body"},{"line_number":833,"context_line":"  required: false"},{"line_number":834,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff570b3c_9a519739","line":831,"range":{"start_line":831,"start_character":30,"end_line":831,"end_character":64},"in_reply_to":"1f493fa4_01ab2e1d","updated":"2020-05-20 08:35:02.000000000","message":"Done","commit_id":"33a9aa8ed46679b760b3b8e2746b535eb728e433"}]}