)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"ff9bdd0062b975bd4302e37e3ad39022de1821a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ling-yun \u003czengyunling@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-20 19:24:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume transfer in volume_dstroy function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doing volume force delete operation on volume-A will change volume-A\u0027s"},{"line_number":10,"context_line":"status to \u0027deleted\u0027, so all related data about volume-A should be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B3hU%3D","line":7,"updated":"2014-01-21 09:34:56.000000000","message":"destroy","commit_id":"43b87e96e000acac2e2407c8ded1817c493be9dd"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"7f21eeaf90ef30eed2abb0496940aef73fa82a4a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ling-yun \u003czengyunling@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-20 19:24:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume transfer in volume_dstroy function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doing volume force delete operation on volume-A will change volume-A\u0027s"},{"line_number":10,"context_line":"status to \u0027deleted\u0027, so all related data about volume-A should be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B23Y%3D","line":7,"in_reply_to":"AAAAUH%2F%2B3hU%3D","updated":"2014-01-21 11:33:46.000000000","message":"Modify it in next patch.","commit_id":"43b87e96e000acac2e2407c8ded1817c493be9dd"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0dda06e4183507b61b34b2f87d14781276bf483b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ling-yun \u003czengyunling@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-24 16:27:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume transfer in volume_dstroy function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doing volume force delete operation on volume-A will change volume-A\u0027s"},{"line_number":10,"context_line":"status to \u0027deleted\u0027, so all related data about volume-A should be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F%2BkQI%3D","line":7,"updated":"2014-01-24 11:04:57.000000000","message":"Need to address Avishay\u0027s previous comment: change to volume_destroy","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4dfe26d773530f9b0ab79d80452f2e6490c3c838","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ling-yun \u003czengyunling@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-24 16:27:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Delete volume transfer in volume_dstroy function"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Doing volume force delete operation on volume-A will change volume-A\u0027s"},{"line_number":10,"context_line":"status to \u0027deleted\u0027, so all related data about volume-A should be deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAUH%2F%2Bjf0%3D","line":7,"in_reply_to":"AAAAUH%2F%2BkQI%3D","updated":"2014-01-24 12:52:21.000000000","message":"Thanks.Modify it in next patch.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"}],"cinder/tests/api/contrib/test_volume_transfer.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a8d4d42ac02f8c340361f19bc4859598ea433573","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        #verify volume deleted"},{"line_number":401,"context_line":"        resp \u003d req.get_response(fakes.wsgi_app())"},{"line_number":402,"context_line":"        # request is accepted"},{"line_number":403,"context_line":"        self.assertEqual(resp.status_int, 202)"},{"line_number":404,"context_line":"        # volume is deleted"},{"line_number":405,"context_line":"        self.assertRaises(exception.NotFound, db.volume_get, ctx, volume_id)"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BpKI%3D","line":403,"updated":"2014-01-23 16:10:46.000000000","message":"This assert seems to be failing.\n\nI haven\u0027t tried this out, but since your change is at the db layer it might be more appropriate and easier to test this in cinder/tests/test_volume_transfer.py","commit_id":"c509411e9a6c92860f8d3cf9cddcc27ec7c2fefd"}],"cinder/tests/test_volume_transfer.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0dda06e4183507b61b34b2f87d14781276bf483b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.assertEqual(t[\u0027id\u0027], transfer[\u0027id\u0027], \u0027Unexpected transfer id\u0027)"},{"line_number":131,"context_line":"        #force delete volume"},{"line_number":132,"context_line":"        db.volume_destroy(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":133,"context_line":"        #can\u0027t not find transfer"},{"line_number":134,"context_line":"        nctxt \u003d context.RequestContext(user_id\u003d\u0027new_user_id\u0027,"},{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkFE%3D","line":133,"updated":"2014-01-24 11:04:57.000000000","message":"# Make sure transfer has been deleted.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4dfe26d773530f9b0ab79d80452f2e6490c3c838","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.assertEqual(t[\u0027id\u0027], transfer[\u0027id\u0027], \u0027Unexpected transfer id\u0027)"},{"line_number":131,"context_line":"        #force delete volume"},{"line_number":132,"context_line":"        db.volume_destroy(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":133,"context_line":"        #can\u0027t not find transfer"},{"line_number":134,"context_line":"        nctxt \u003d context.RequestContext(user_id\u003d\u0027new_user_id\u0027,"},{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BjgI%3D","line":133,"in_reply_to":"AAAAUH%2F%2BkFE%3D","updated":"2014-01-24 12:52:21.000000000","message":"Thanks.Modify it in next patch.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0dda06e4183507b61b34b2f87d14781276bf483b","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        db.volume_destroy(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":133,"context_line":"        #can\u0027t not find transfer"},{"line_number":134,"context_line":"        nctxt \u003d context.RequestContext(user_id\u003d\u0027new_user_id\u0027,"},{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"},{"line_number":137,"context_line":"                          tx_api.get,"},{"line_number":138,"context_line":"                          nctxt,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkEI%3D","line":135,"updated":"2014-01-24 11:04:57.000000000","message":"No need to create a new context in this test, instead test that the context that created the transfer can no longer get it.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4dfe26d773530f9b0ab79d80452f2e6490c3c838","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        db.volume_destroy(context.get_admin_context(), volume[\u0027id\u0027])"},{"line_number":133,"context_line":"        #can\u0027t not find transfer"},{"line_number":134,"context_line":"        nctxt \u003d context.RequestContext(user_id\u003d\u0027new_user_id\u0027,"},{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"},{"line_number":137,"context_line":"                          tx_api.get,"},{"line_number":138,"context_line":"                          nctxt,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BjgE%3D","line":135,"in_reply_to":"AAAAUH%2F%2BkEI%3D","updated":"2014-01-24 12:52:21.000000000","message":"Thanks.Modify it in next patch.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0dda06e4183507b61b34b2f87d14781276bf483b","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"},{"line_number":137,"context_line":"                          tx_api.get,"},{"line_number":138,"context_line":"                          nctxt,"},{"line_number":139,"context_line":"                          transfer[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BkEk%3D","line":138,"updated":"2014-01-24 11:04:57.000000000","message":"You need to test with the context self.ctxt. The other user context will (should) never get the transfer, even if it has not been deleted.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"},{"author":{"_account_id":8874,"name":"ling-yun","email":"YunlingZeng@hotmail.com","username":"ling-yun"},"change_message_id":"4dfe26d773530f9b0ab79d80452f2e6490c3c838","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                                       project_id\u003d\u0027new_project_id\u0027)"},{"line_number":136,"context_line":"        self.assertRaises(exception.TransferNotFound,"},{"line_number":137,"context_line":"                          tx_api.get,"},{"line_number":138,"context_line":"                          nctxt,"},{"line_number":139,"context_line":"                          transfer[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BjgA%3D","line":138,"in_reply_to":"AAAAUH%2F%2BkEk%3D","updated":"2014-01-24 12:52:21.000000000","message":"Thanks.Modify it in next patch.","commit_id":"a8eee6213a776ebaf6546e68b5db13f7a509bef0"}]}