)]}'
{"cinder/quota.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"2544214a468dd8610bda2766a69206acaed12bf1","unresolved":false,"context_lines":[{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        # Volume type quotas."},{"line_number":865,"context_line":"        # NOTE(jdg): We also want to check deleted types here as well"},{"line_number":866,"context_line":"        # if we don\u0027t the _get_quotas resource len check on will fail"},{"line_number":867,"context_line":"        volume_types \u003d db.volume_type_get_all(context.get_admin_context(),"},{"line_number":868,"context_line":"                                              True)"},{"line_number":869,"context_line":"        for volume_type in volume_types.values():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BnF0%3D","side":"PARENT","line":866,"updated":"2014-01-23 22:00:38.000000000","message":"It seems that making this change will cause the problem noted here.  I think a different solution needs to be found.","commit_id":"c24e82d046abb4e64f83cb7201d717b9cb403517"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"f0d90a5c74420379b29f36ea95a18068c4ec13ef","unresolved":false,"context_lines":[{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        # Volume type quotas."},{"line_number":865,"context_line":"        # NOTE(jdg): We also want to check deleted types here as well"},{"line_number":866,"context_line":"        # if we don\u0027t the _get_quotas resource len check on will fail"},{"line_number":867,"context_line":"        volume_types \u003d db.volume_type_get_all(context.get_admin_context(),"},{"line_number":868,"context_line":"                                              True)"},{"line_number":869,"context_line":"        for volume_type in volume_types.values():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BdnU%3D","side":"PARENT","line":866,"in_reply_to":"AAAAUH%2F%2Bm7U%3D","updated":"2014-01-25 18:48:38.000000000","message":"Correct, the case that I added this for no longer exists and I don\u0027t see another potential pitfall here.  Vahid and I tested this out a bit and walked through it last week, I believe it\u0027s good to go.","commit_id":"c24e82d046abb4e64f83cb7201d717b9cb403517"},{"author":{"_account_id":9498,"name":"Vahid Hashemian","email":"vahidhashemian@us.ibm.com","username":"vahidhashemian"},"change_message_id":"a6f87d5c1d0e545f03ddb40b3860926a6ee264ad","unresolved":false,"context_lines":[{"line_number":863,"context_line":""},{"line_number":864,"context_line":"        # Volume type quotas."},{"line_number":865,"context_line":"        # NOTE(jdg): We also want to check deleted types here as well"},{"line_number":866,"context_line":"        # if we don\u0027t the _get_quotas resource len check on will fail"},{"line_number":867,"context_line":"        volume_types \u003d db.volume_type_get_all(context.get_admin_context(),"},{"line_number":868,"context_line":"                                              True)"},{"line_number":869,"context_line":"        for volume_type in volume_types.values():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2Bm7U%3D","side":"PARENT","line":866,"in_reply_to":"AAAAUH%2F%2BnF0%3D","updated":"2014-01-23 22:32:08.000000000","message":"Jay, I\u0027m not sure if you saw my first code review comment. I spoke to John Griffith and he believed that the violation mentioned above would no longer occur (since in-use volume types cannot be removed anymore). If this is not the case could you let me know what scenario would break this? I have not been able to find one. Thanks.","commit_id":"c24e82d046abb4e64f83cb7201d717b9cb403517"}]}