)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"80146e4ebba811129ba4297dea08510e939d3138","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-28 17:38:50 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NFS snapshot deletion issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"WIP"},{"line_number":10,"context_line":"Can\u0027t delete snapshots in error status."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ieb19d5e3f58ae2343b6b145772fec33cb7517ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_c0b86d76","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":39},"updated":"2019-08-29 15:50:48.000000000","message":"Commit message needs to be improved. First, the summary should give some clue what it\u0027s about, and simply mentioning an \"issue\" is vague.\n\nIn the body, I would mention the patch makes it possible to delete NFS snapshots that failed, when the reason is snapshots are not supported.","commit_id":"0b5f7bd4cb2c289f1cc9094b5e9f9dae90246c3b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2a69ac876a9d7f4ed8a1b0fd1724b092a9c83e34","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofia Enriquez \u003clsofia.enriquez@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-04 16:16:04 -0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NFS doesn\u0027t remove snapshots in error status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NFS driver doesn\u0027t allow to delete snapshots when \u0027snapshot support\u0027 is set to"},{"line_number":10,"context_line":"False. However, I\u0027m able to \u0027create\u0027 error snapshots anyway."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_abb4cdf1","line":7,"updated":"2019-09-05 13:23:18.000000000","message":"The summary line is a good statement of the problem, but it should summarize the patch. Maybe something like this?\n\nAllow removing NFS snapshots in error status","commit_id":"7800079e9e685a1ac8caf6013b1c1309f61a820e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2a69ac876a9d7f4ed8a1b0fd1724b092a9c83e34","unresolved":false,"context_lines":[{"line_number":10,"context_line":"False. However, I\u0027m able to \u0027create\u0027 error snapshots anyway."},{"line_number":11,"context_line":"Because of that, I have snapshots in error state that I\u0027m not able to delete."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In order to fix this, the driver should look for any NFS snapshot file in the local"},{"line_number":14,"context_line":"path even when the snapshot support is False. If there are some files, the driver"},{"line_number":15,"context_line":"avoids to check the snapshot support and just delete the snapshot."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"It makes sense to block creating snapshots when snapshot support is False. However,"},{"line_number":18,"context_line":"when deleting snapshot we don\u0027t want to block attempts to delete a broken snapshot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_4ba2f99b","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":66},"updated":"2019-09-05 13:23:18.000000000","message":"-1: This text no longer matches how this patch fixes the problem. I think you can just remove it. The remaining two paragraphs go nicely together.","commit_id":"7800079e9e685a1ac8caf6013b1c1309f61a820e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"55153077b80ca632452f77c8761272cac7f6225d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"when deleting snapshot we don\u0027t want to block attempts to delete a broken snapshot"},{"line_number":19,"context_line":"DB entry, which is necessary to clean up a failed snapshot create."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1842088"},{"line_number":22,"context_line":"Change-Id: Ieb19d5e3f58ae2343b6b145772fec33cb7517ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_d15e6177","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":6},"updated":"2020-02-18 15:46:08.000000000","message":"Should this be Partial-bug? Seems like the root issue here is that the snapshot entries were created in the first place.","commit_id":"e13b3b0eea86f99ade7b5f247fd35c54cdcb15b9"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"1ddda9b179d0f5abc09e9b9dc1f70959193eebc1","unresolved":true,"context_lines":[{"line_number":20,"context_line":"attempts to delete a broken snapshot DB entry, which is necessary to"},{"line_number":21,"context_line":"clean up a failed snapshot create."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partial-Bug: #1842088"},{"line_number":24,"context_line":"Change-Id: Ieb19d5e3f58ae2343b6b145772fec33cb7517ab5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"4587e61c_6d9ad2f9","line":23,"updated":"2021-07-14 16:58:39.000000000","message":"As I note in a previous comment, my view is this patch fully fixes the LP issue, so Closes-Bug seems correct.","commit_id":"7182c1e14ec62e45c0878d12ee976c75282de558"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"80146e4ebba811129ba4297dea08510e939d3138","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        info_path \u003d self._local_path_volume_info(snapshot.volume)"},{"line_number":578,"context_line":"        snap_exist \u003d self._read_info_file(info_path, empty_if_missing\u003dTrue)"},{"line_number":579,"context_line":"        if snap_exist:"},{"line_number":580,"context_line":"            return self._delete_snapshot(snapshot)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_80fcb53f","line":577,"updated":"2019-08-29 15:50:48.000000000","message":"Looking at the _check_snapshot_support code ad L549, it makes sense to block creating snapshots. Conversely, we do *not* want to block attempts to delete a broken snapshot DB entry, which is necessary to clean up a failed snapshot create.\n\nWith this in mind, a simpler fix seems to be to just delete L585.","commit_id":"0b5f7bd4cb2c289f1cc9094b5e9f9dae90246c3b"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bfa86b058d024b37c65979736b0805dd94045994","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        info_path \u003d self._local_path_volume_info(snapshot.volume)"},{"line_number":578,"context_line":"        snap_exist \u003d self._read_info_file(info_path, empty_if_missing\u003dTrue)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if not snap_exist:"},{"line_number":581,"context_line":"            self._check_snapshot_support()"},{"line_number":582,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ed7d4be6","line":581,"range":{"start_line":577,"start_character":0,"end_line":581,"end_character":42},"updated":"2019-08-30 19:21:54.000000000","message":"I still believe this function should not call _check_snapshot_support() at all, so L577..581 should be deleted. I\u0027m curious what others think.","commit_id":"5459d92c33b67e9ab762156f650105e280dda0e5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4eb7dcfa25a4c1277cc1d713113b62e883e7941c","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        info_path \u003d self._local_path_volume_info(snapshot.volume)"},{"line_number":578,"context_line":"        snap_exist \u003d self._read_info_file(info_path, empty_if_missing\u003dTrue)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if not snap_exist:"},{"line_number":581,"context_line":"            self._check_snapshot_support()"},{"line_number":582,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_45be8165","line":581,"range":{"start_line":577,"start_character":0,"end_line":581,"end_character":42},"in_reply_to":"7faddb67_c58831c7","updated":"2019-09-04 12:41:58.000000000","message":"(this \u003d your suggestion)","commit_id":"5459d92c33b67e9ab762156f650105e280dda0e5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1679fcbec49d3670f6f353e3fe773c2ad4ed95d5","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        info_path \u003d self._local_path_volume_info(snapshot.volume)"},{"line_number":578,"context_line":"        snap_exist \u003d self._read_info_file(info_path, empty_if_missing\u003dTrue)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        if not snap_exist:"},{"line_number":581,"context_line":"            self._check_snapshot_support()"},{"line_number":582,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c58831c7","line":581,"range":{"start_line":577,"start_character":0,"end_line":581,"end_character":42},"in_reply_to":"7faddb67_ed7d4be6","updated":"2019-09-04 12:41:36.000000000","message":"This is probably the right way to go, but it means that we need to ensure that going down the online delete path when the file doesn\u0027t actually exist is robust.","commit_id":"5459d92c33b67e9ab762156f650105e280dda0e5"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2a69ac876a9d7f4ed8a1b0fd1724b092a9c83e34","unresolved":false,"context_lines":[{"line_number":573,"context_line":"    @coordination.synchronized(\u0027{self.driver_prefix}-{snapshot.volume.id}\u0027)"},{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_0bfe41ae","side":"PARENT","line":576,"updated":"2019-09-05 13:23:18.000000000","message":"nit: L576 did not need to be deleted.","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2a69ac876a9d7f4ed8a1b0fd1724b092a9c83e34","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_56dce072","side":"PARENT","line":577,"updated":"2019-09-05 13:23:18.000000000","message":"-1: Hmm, I may have misled you (sorry!). Looking at the _delete_snapshot() code in remotefs.py, it has its own _validate_state() that will block deleting snapshots in the error state. I\u0027m now thinking something like this may be the way to go:\n\n    try:\n        self._check_snapshot_support()\n    except exception.VolumeDriverException:\n        # If snapshots aren\u0027t supported then there\u0027s nothing to delete.\n        return\n\n    return self._delete_snapshot(snapshot)","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0ce520a1f3c04a58fce0261d22cd921fb1b59bf5","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_e2997f79","side":"PARENT","line":577,"in_reply_to":"7faddb67_56dce072","updated":"2019-09-05 17:52:56.000000000","message":"+1: never mind, please ignore my previous remark. I didn\u0027t look closely enough to notice the _validate_state() code is checking the volume\u0027s state, not the snapshot\u0027s state.\n\nSorry for the confusion/noise!","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1556d970b567485401fe9050ac7db220a3e39db6","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_1b706f73","side":"PARENT","line":577,"range":{"start_line":577,"start_character":0,"end_line":577,"end_character":38},"updated":"2019-12-02 11:09:35.000000000","message":"One main issue i encountered while testing this is:\n\nIf a snapshot is in available state and snapshot support is disabled then also user can delete the \u0027available\u0027 snapshot which IMO shouldn\u0027t be allowed (and the purpose of this check here).\n\nI think we only need to allow deletion of snapshots which are in \u0027error\u0027 state when snapshot support is disabled (if the purpose of patch is to cleanup failed snapshots)\n\nAlso my suggestion : the best case would be to cleanup the created snapshot before raising exception at L#555 and L#564 during \u0027create\u0027 operation while snapshot support is disabled","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b234590080151cd3e7c29c96ba05244c170897b9","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8c953234","side":"PARENT","line":577,"range":{"start_line":577,"start_character":0,"end_line":577,"end_character":38},"in_reply_to":"3fa7e38b_1b706f73","updated":"2020-02-18 16:22:53.000000000","message":"I disagree. If snapshots were created, then the decision was made to disable snapshots, we should still allow those available snapshots to be deleted. Otherwise there is no way to get rid of them without reconfiguring the system.","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"802c990be2d0921cf16dd4416f2ee27d5e67a5fa","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        self._check_snapshot_support()"},{"line_number":578,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"    def _copy_volume_from_snapshot(self, snapshot, volume, volume_size):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a21fd55b","side":"PARENT","line":577,"range":{"start_line":577,"start_character":0,"end_line":577,"end_character":38},"in_reply_to":"3fa7e38b_8c953234","updated":"2020-02-18 19:00:19.000000000","message":"The testing done here[1] states that online volume snapshot creation/deletion fails (problem with libvirt \u003c 1.2.7) hence this check was introduced in create and delete\n\nremoving the check will still result in the snapshot going to error_deleting state in that environment\n\n[1] http://paste.openstack.org/show/789714/","commit_id":"6e585da2ff1166c25ae7cf6f26ef1cd0c465dc37"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"121b9939609bd10817abf10cc1beec6ba3722fc7","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot, previous_status_error\u003dFalse):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        if not previous_status_error:"},{"line_number":578,"context_line":"            self._check_snapshot_support()"},{"line_number":579,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fae9aa7e","line":577,"range":{"start_line":577,"start_character":8,"end_line":577,"end_character":37},"updated":"2019-12-04 06:13:36.000000000","message":"can\u0027t we do this like,\nif snapshot.status !\u003d \u0027error\u0027","commit_id":"0e6715986445673d94ec8c1b4d5fdae345013f40"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6af15efcaf5e054682231b99f0adec9880ba10c8","unresolved":false,"context_lines":[{"line_number":574,"context_line":"    def delete_snapshot(self, snapshot, previous_status_error\u003dFalse):"},{"line_number":575,"context_line":"        \"\"\"Apply locking to the delete snapshot operation.\"\"\""},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        if not previous_status_error:"},{"line_number":578,"context_line":"            self._check_snapshot_support()"},{"line_number":579,"context_line":"        return self._delete_snapshot(snapshot)"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a24d44c6","line":577,"range":{"start_line":577,"start_character":8,"end_line":577,"end_character":37},"in_reply_to":"3fa7e38b_fae9aa7e","updated":"2019-12-04 13:56:34.000000000","message":"Sadly it\u0027s not so simple, the snapshot.status is \u0027deleting\u0027.","commit_id":"0e6715986445673d94ec8c1b4d5fdae345013f40"}],"cinder/volume/manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"121b9939609bd10817abf10cc1beec6ba3722fc7","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                self.driver.unmanage_snapshot(snapshot)"},{"line_number":1229,"context_line":"            else:"},{"line_number":1230,"context_line":"                self.driver.delete_snapshot(snapshot,"},{"line_number":1231,"context_line":"                                            previous_status_error)"},{"line_number":1232,"context_line":"        except exception.SnapshotIsBusy as busy_error:"},{"line_number":1233,"context_line":"            LOG.error(\"Delete snapshot failed, due to snapshot busy.\","},{"line_number":1234,"context_line":"                      resource\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_dab4ee84","line":1231,"range":{"start_line":1231,"start_character":44,"end_line":1231,"end_character":65},"updated":"2019-12-04 06:13:36.000000000","message":"This requires adding this extra parameter to all driver\u0027s delete_snapshot function which we shouldn\u0027t since this issue is nfs specific","commit_id":"0e6715986445673d94ec8c1b4d5fdae345013f40"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6af15efcaf5e054682231b99f0adec9880ba10c8","unresolved":false,"context_lines":[{"line_number":1228,"context_line":"                self.driver.unmanage_snapshot(snapshot)"},{"line_number":1229,"context_line":"            else:"},{"line_number":1230,"context_line":"                self.driver.delete_snapshot(snapshot,"},{"line_number":1231,"context_line":"                                            previous_status_error)"},{"line_number":1232,"context_line":"        except exception.SnapshotIsBusy as busy_error:"},{"line_number":1233,"context_line":"            LOG.error(\"Delete snapshot failed, due to snapshot busy.\","},{"line_number":1234,"context_line":"                      resource\u003dsnapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_42e1f09a","line":1231,"range":{"start_line":1231,"start_character":44,"end_line":1231,"end_character":65},"in_reply_to":"3fa7e38b_dab4ee84","updated":"2019-12-04 13:56:34.000000000","message":"Make sense. Maybe I can do the cleanup only in the creation of the snapshot and avoid changing the delete_snapshot in the NFS driver.","commit_id":"0e6715986445673d94ec8c1b4d5fdae345013f40"}]}