)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"06ef50f69e4836352b985fb1fd9f0679816e6d11","unresolved":false,"context_lines":[{"line_number":22,"context_line":"when the volume would be removed. Instead, simply log a warning"},{"line_number":23,"context_line":"and return, the way other backends (example: RBD) already do."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Addresses bug 1270959."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Id61407c9a5e020d5a823dd7b8c973d237c35cb9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2B5RI%3D","line":25,"updated":"2014-01-21 00:26:21.000000000","message":"This should be \u0027Closes-bug: 1270959\u0027 so that the patch is associated with the bug automatically.","commit_id":"7ac77223823324893116f161d1e9820ff51a31d7"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"d125b0459327d19abcbd93c054b28380c351bfd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VolumeManager: initialize even if a volume can\u0027t be found"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a previously volume cannot be exported (for example, because"},{"line_number":10,"context_line":"an iSCSI target\u0027s backing LV is no longer present), VolumeManager"},{"line_number":11,"context_line":"would previously bail out, leaving the volume service uninitialized."},{"line_number":12,"context_line":"This left volumes dangling in limbo: their state would be reported"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2B20E%3D","line":9,"updated":"2014-01-21 11:44:42.000000000","message":"previously created volume?","commit_id":"6f7e2d9ea705caac335ec8e10f7119e866dd30be"}],"cinder/brick/iscsi/iscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c8c89ece30cdd0c0539ef7833731782d961ab8df","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        f.close()"},{"line_number":180,"context_line":"        LOG.debug(_(\u0027Created volume path %(vp)s,\\n\u0027"},{"line_number":181,"context_line":"                    \u0027content: %(vc)%\u0027)"},{"line_number":182,"context_line":"                  % {\u0027vp\u0027: volume_path, \u0027vc\u0027: volume_conf})"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        old_persist_file \u003d None"},{"line_number":185,"context_line":"        old_name \u003d kwargs.get(\u0027old_name\u0027, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BfL4%3D","line":182,"updated":"2014-01-25 03:10:25.000000000","message":"I\u0027ve got a patch to in flight to rework this as well... cleaning up to a \"with open xxxxx\" and adding debug.  We hit an interesting issue in the gate lately that is related to this file not existing so I want to get some more data on it.","commit_id":"2a838f4efecf4824e5e4f5612905b0e1441ca6bc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c8c89ece30cdd0c0539ef7833731782d961ab8df","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        vol_uuid_file \u003d vol_name"},{"line_number":263,"context_line":"        volume_path \u003d os.path.join(self.volumes_dir, vol_uuid_file)"},{"line_number":264,"context_line":"        if not os.path.exists(volume_path):"},{"line_number":265,"context_line":"            LOG.warning(_(\u0027Volume path %s does not exist, \u0027"},{"line_number":266,"context_line":"                          \u0027nothing to remove.\u0027) % volume_path)"},{"line_number":267,"context_line":"            return"},{"line_number":268,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BfL0%3D","line":265,"updated":"2014-01-25 03:10:25.000000000","message":"seems reasonable, and inline with how we typically deal with delete, even if it is a bit \"scary\"","commit_id":"2a838f4efecf4824e5e4f5612905b0e1441ca6bc"}],"cinder/tests/test_iscsi.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c8c89ece30cdd0c0539ef7833731782d961ab8df","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self.flags(iscsi_helper\u003d\u0027lioadm\u0027)"},{"line_number":198,"context_line":"        self.script_template \u003d \"\\n\".join(["},{"line_number":199,"context_line":"            \u0027cinder-rtstool create \u0027"},{"line_number":200,"context_line":"            \u0027/foo iqn.2011-09.org.foo.bar:blaa test_id test_pass\u0027,"},{"line_number":201,"context_line":"            \u0027cinder-rtstool delete iqn.2010-10.org.openstack:volume-blaa\u0027])"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F%2BfLw%3D","line":200,"updated":"2014-01-25 03:10:25.000000000","message":"Lio is causing you problems in unit test, need to fix these up as well or let my patch through :)\n\nIf you fix it here make sure you give mine a -2","commit_id":"2a838f4efecf4824e5e4f5612905b0e1441ca6bc"}],"cinder/volume/manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"06ef50f69e4836352b985fb1fd9f0679816e6d11","unresolved":false,"context_lines":[{"line_number":253,"context_line":"                        self.driver.ensure_export(ctxt, volume)"},{"line_number":254,"context_line":"                    except Exception as export_ex:"},{"line_number":255,"context_line":"                        LOG.error(_(\"Failed to re-export volume %s: \""},{"line_number":256,"context_line":"                                    \"setting to error state\"), volume[\u0027id\u0027])"},{"line_number":257,"context_line":"                        LOG.exception(export_ex)"},{"line_number":258,"context_line":"                        self.db.volume_update(ctxt,"},{"line_number":259,"context_line":"                                              volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B5Qo%3D","line":256,"updated":"2014-01-21 00:26:21.000000000","message":"This message should end with a \u0027.\u0027.","commit_id":"7ac77223823324893116f161d1e9820ff51a31d7"}]}
