)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"accb4eec8d6498f84bc0e561f4c39b271e6852fb","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"            if \u0027CMMVC5959E\u0027 not in e:"},{"line_number":2132,"context_line":"                # If there is no relation between the primary and the"},{"line_number":2133,"context_line":"                # secondary back-end storage, the exception is raised."},{"line_number":2134,"context_line":"                raise"},{"line_number":2135,"context_line":"        if rc_id:"},{"line_number":2136,"context_line":"            # We need setup master and aux change volumes for gmcv"},{"line_number":2137,"context_line":"            # before we can start remote relationship"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5e7c12ea","line":2134,"updated":"2019-09-04 14:36:06.000000000","message":"It looks like this is missing another raise for when the CMMVC5959E error is not detected.  Doesn\u0027t this mean that if ssh fails, the driver thinks this method succeeded?","commit_id":"65b94c363b7acfcaca68da1d24542457feef19c1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ca327068fe28708043027c0bc7fe76ab04473b63","unresolved":false,"context_lines":[{"line_number":2131,"context_line":"            if \u0027CMMVC5959E\u0027 not in e:"},{"line_number":2132,"context_line":"                # If there is no relation between the primary and the"},{"line_number":2133,"context_line":"                # secondary back-end storage, the exception is raised."},{"line_number":2134,"context_line":"                raise"},{"line_number":2135,"context_line":"        if rc_id:"},{"line_number":2136,"context_line":"            # We need setup master and aux change volumes for gmcv"},{"line_number":2137,"context_line":"            # before we can start remote relationship"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3665af45","line":2134,"in_reply_to":"7faddb67_5e7c12ea","updated":"2019-09-05 01:46:38.000000000","message":"Sorry I don\u0027t catch it, so what modification shall I make to this code?","commit_id":"65b94c363b7acfcaca68da1d24542457feef19c1"}],"cinder/volume/drivers/inspur/instorage/instorage_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"54949015e24b7c8b8b4fe84c92c5da128d344ace","unresolved":false,"context_lines":[{"line_number":2899,"context_line":""},{"line_number":2900,"context_line":"    def create_relationship(self, master, aux, system, asynccopy):"},{"line_number":2901,"context_line":"        try:"},{"line_number":2902,"context_line":"            rc_id \u003d None"},{"line_number":2903,"context_line":"            rc_id \u003d self.ssh.mkrcrelationship(master, aux, system,"},{"line_number":2904,"context_line":"                                              asynccopy)"},{"line_number":2905,"context_line":"        except exception.VolumeBackendAPIException as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e51f6d6d","line":2902,"updated":"2019-09-04 12:47:16.000000000","message":"Move this inside the except block, otherwise it won\u0027t be long before someone comes along and removes this as redundant.","commit_id":"65b94c363b7acfcaca68da1d24542457feef19c1"},{"author":{"_account_id":20190,"name":"zhufl","email":"zhu.fanglei@zte.com.cn","username":"zhufl"},"change_message_id":"ca327068fe28708043027c0bc7fe76ab04473b63","unresolved":false,"context_lines":[{"line_number":2899,"context_line":""},{"line_number":2900,"context_line":"    def create_relationship(self, master, aux, system, asynccopy):"},{"line_number":2901,"context_line":"        try:"},{"line_number":2902,"context_line":"            rc_id \u003d None"},{"line_number":2903,"context_line":"            rc_id \u003d self.ssh.mkrcrelationship(master, aux, system,"},{"line_number":2904,"context_line":"                                              asynccopy)"},{"line_number":2905,"context_line":"        except exception.VolumeBackendAPIException as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_96558352","line":2902,"in_reply_to":"7faddb67_e51f6d6d","updated":"2019-09-05 01:46:38.000000000","message":"reasonable, done","commit_id":"65b94c363b7acfcaca68da1d24542457feef19c1"}]}