)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26693,"name":"do3meli","email":"info@dominicschlegel.ch","username":"do3meli"},"change_message_id":"c78d9a9e56083f508c3c1ad13e0e8d0c6feb9552","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix \u0027detach.end\u0027 notify with old volume status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027attachemnt_delete\u0027 update volume status in"},{"line_number":10,"context_line":"volume/api.py:attachemnt_delete method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"But the \u0027detach.end\u0027 notify is still sent in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_ddb7f6d7","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":18},"updated":"2019-10-09 07:45:12.000000000","message":"type - should be attachment_delete","commit_id":"8d6ddf225a11873a677c308b71434b2b3b1d4c50"},{"author":{"_account_id":26693,"name":"do3meli","email":"info@dominicschlegel.ch","username":"do3meli"},"change_message_id":"c78d9a9e56083f508c3c1ad13e0e8d0c6feb9552","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027detach.end\u0027 notify with old volume status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027attachemnt_delete\u0027 update volume status in"},{"line_number":10,"context_line":"volume/api.py:attachemnt_delete method."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"But the \u0027detach.end\u0027 notify is still sent in"},{"line_number":13,"context_line":"volume/manage.py:attachment_delete so that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_bdb47ad2","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":31},"updated":"2019-10-09 07:45:12.000000000","message":"typo: should be attachment_delete","commit_id":"8d6ddf225a11873a677c308b71434b2b3b1d4c50"}],"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d20cd39df0077188415f8b60df18aa20d322bd8a","unresolved":false,"context_lines":[{"line_number":1474,"context_line":"                                                  reason\u003dsix.text_type(ex))"},{"line_number":1475,"context_line":""},{"line_number":1476,"context_line":"        volume.finish_detach(attachment.id)"},{"line_number":1477,"context_line":"        self._notify_about_volume_usage(context, volume, \"detach.end\")"},{"line_number":1478,"context_line":"        LOG.info(\"Detach volume completed successfully.\", resource\u003dvolume)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"    def _create_image_cache_volume_entry(self, ctx, volume_ref,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2ec9a8ab","line":1477,"updated":"2019-10-17 20:46:37.000000000","message":"What about this one?  (See below..)","commit_id":"05aff9fa27cad20f51ff6281cd90e1937fe39c2a"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d20cd39df0077188415f8b60df18aa20d322bd8a","unresolved":false,"context_lines":[{"line_number":4672,"context_line":"            self.db.volume_admin_metadata_delete(context.elevated(),"},{"line_number":4673,"context_line":"                                                 vref.id,"},{"line_number":4674,"context_line":"                                                 \u0027attached_mode\u0027)"},{"line_number":4675,"context_line":""},{"line_number":4676,"context_line":"    # Replication group API (Tiramisu)"},{"line_number":4677,"context_line":"    def enable_replication(self, ctxt, group):"},{"line_number":4678,"context_line":"        \"\"\"Enable replication.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6ecfa0b3","line":4675,"updated":"2019-10-17 20:46:37.000000000","message":"Only moving this from _do_attachment_delete introduces a difference in the notification behavior between the old and new detach APIs.\n\nSee above.","commit_id":"05aff9fa27cad20f51ff6281cd90e1937fe39c2a"}]}
