)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c71fad8d4a0261328095ce9a70302d83eccbea0a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Co-Authored-By: Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"(cherry picked from commit 12727dcdfe4484855d8c563396a25462624a16ec)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Change-Id: I12b008458cc49a4b32e86f1a33d262c85fd88e71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_15d11efc","line":27,"updated":"2019-09-19 14:54:24.000000000","message":"That (abandoned) patch may have been the inspiration for this patch, but it\u0027s not a reason to treat this patch as a cherry pick. Cherry pick statements in the commit message are primarily for referencing existing (not abandoned) patches on other branches.","commit_id":"e5020a76ecd00361e4eea24173e18cac58d76c22"}],"cinder/image/image_utils.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c71fad8d4a0261328095ce9a70302d83eccbea0a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # use default"},{"line_number":258,"context_line":"        cache_mode \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    sparse_size \u003d None"},{"line_number":261,"context_line":"    if sparse:"},{"line_number":262,"context_line":"        sparse_size \u003d \u00271M\u0027"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    cmd \u003d _get_qemu_convert_cmd(source, dest,"},{"line_number":265,"context_line":"                                out_format\u003dout_format,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d5f3869d","line":262,"range":{"start_line":260,"start_character":0,"end_line":262,"end_character":26},"updated":"2019-09-19 14:54:24.000000000","message":"I think this would be more legible if written like this:\n\n    sparse_size \u003d \u00271M\u0027 if sparse else None","commit_id":"e5020a76ecd00361e4eea24173e18cac58d76c22"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cd316339c6059377d296488d329a25dd1a62d347","unresolved":false,"context_lines":[{"line_number":149,"context_line":"def _get_qemu_convert_cmd(src, dest, out_format, src_format\u003dNone,"},{"line_number":150,"context_line":"                          out_subformat\u003dNone, cache_mode\u003dNone,"},{"line_number":151,"context_line":"                          prefix\u003dNone, cipher_spec\u003dNone,"},{"line_number":152,"context_line":"                          passphrase_file\u003dNone, sparse_size\u003dNone,"},{"line_number":153,"context_line":"                          compress\u003dFalse):"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    if out_format \u003d\u003d \u0027vhd\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_e7676824","line":152,"range":{"start_line":152,"start_character":60,"end_line":152,"end_character":64},"updated":"2020-06-03 17:52:45.000000000","message":"This should be 0 instead of None.","commit_id":"c6098054b4ffe32047709b90379533520faa5a69"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cd316339c6059377d296488d329a25dd1a62d347","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # use default"},{"line_number":258,"context_line":"        cache_mode \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    sparse_size \u003d \u00271M\u0027 if sparse else None"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    cmd \u003d _get_qemu_convert_cmd(source, dest,"},{"line_number":263,"context_line":"                                out_format\u003dout_format,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_2747a079","line":260,"range":{"start_line":260,"start_character":37,"end_line":260,"end_character":42},"updated":"2020-06-03 17:52:45.000000000","message":"This should be 0 instead of None. If sparse_size is 0, the source will not be scanned for unallocated or zero sectors, and the destination image will always be fully allocated.","commit_id":"c6098054b4ffe32047709b90379533520faa5a69"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"894d195017ad3c6c66eb51121217514edf22b24a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        # use default"},{"line_number":258,"context_line":"        cache_mode \u003d None"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    sparse_size \u003d \u00271M\u0027 if sparse else None"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    cmd \u003d _get_qemu_convert_cmd(source, dest,"},{"line_number":263,"context_line":"                                out_format\u003dout_format,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_358a1cbe","line":260,"range":{"start_line":260,"start_character":37,"end_line":260,"end_character":42},"in_reply_to":"ff570b3c_2747a079","updated":"2020-06-04 11:57:00.000000000","message":"the destination image would be fully allocated if we don\u0027t use the -S parameter as well right? then this code LGTM.","commit_id":"c6098054b4ffe32047709b90379533520faa5a69"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"894d195017ad3c6c66eb51121217514edf22b24a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    if out_subformat:"},{"line_number":193,"context_line":"        cmd +\u003d (\u0027-o\u0027, \u0027subformat\u003d%s\u0027 % out_subformat)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if sparse_size:"},{"line_number":196,"context_line":"        cmd +\u003d (\u0027-S\u0027, sparse_size)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    # AMI images can be raw or qcow2 but qemu-img doesn\u0027t accept \"ami\" as"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_35dcdce2","line":195,"range":{"start_line":195,"start_character":0,"end_line":195,"end_character":19},"updated":"2020-06-04 11:57:00.000000000","message":"this will always be true (\u00270\u0027 is a true value)\nif it\u0027s still expected to be run then,\neither remove the if statement or change default to 0 (on L#173) and append \u00270\u0027 in an else block (or not if not needed which i prefer).","commit_id":"5b1d0d7113229d792c63fe361891077ee47d8854"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"894d195017ad3c6c66eb51121217514edf22b24a","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # use default"},{"line_number":279,"context_line":"        cache_mode \u003d None"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    sparse_size \u003d \u00271M\u0027 if sparse else \u00270\u0027"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    cmd \u003d _get_qemu_convert_cmd(source, dest,"},{"line_number":284,"context_line":"                                out_format\u003dout_format,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_75fbf445","line":281,"range":{"start_line":281,"start_character":33,"end_line":281,"end_character":41},"updated":"2020-06-04 11:57:00.000000000","message":"this would also need to be changed in the latter case mentioned above.","commit_id":"5b1d0d7113229d792c63fe361891077ee47d8854"}]}