)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b68b90ebebd88bfc92f8b391904dda6cd2f82ff4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mingyue Qian \u003cqianmy.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-12 11:49:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move the constants to constants.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid a single giant commit, we will submit the community"},{"line_number":10,"context_line":"code step by step."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_32f470cf","line":7,"updated":"2019-09-19 13:56:59.000000000","message":"we can mention FUJITSU driver here for clarity that this is a driver specific refactoring","commit_id":"d5f04c1ef2c7b2a75a2891b6d60ec041608f8753"},{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"20390a04a9bde636e5d9117677c80cbadd435c45","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mingyue Qian \u003cqianmy.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-12 11:49:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Move the constants to constants.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to avoid a single giant commit, we will submit the community"},{"line_number":10,"context_line":"code step by step."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_82f38b0a","line":7,"in_reply_to":"3fa7e38b_32f470cf","updated":"2019-09-20 01:45:24.000000000","message":"OK, we do it.Thank you for your review","commit_id":"d5f04c1ef2c7b2a75a2891b6d60ec041608f8753"}],"cinder/volume/drivers/fujitsu/eternus_dx/eternus_dx_common.py":[{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"b51173a8fd74e56d9d35915f607627b15be84c21","unresolved":false,"context_lines":[{"line_number":53,"context_line":"OPC \u003d 5"},{"line_number":54,"context_line":"RETURN_TO_RESOURCEPOOL \u003d 19"},{"line_number":55,"context_line":"DETACH \u003d 8"},{"line_number":56,"context_line":"INITIALIZED \u003d 2"},{"line_number":57,"context_line":"UNSYNCHRONIZED \u003d 3"},{"line_number":58,"context_line":"BROKEN \u003d 5"},{"line_number":59,"context_line":"PREPARED \u003d 11"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_de4db272","side":"PARENT","line":56,"updated":"2019-09-12 04:04:09.000000000","message":"It was deleted on the move because it was not used","commit_id":"857df9388783083ab6b630cd00c433ffd40d8035"},{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"b51173a8fd74e56d9d35915f607627b15be84c21","unresolved":false,"context_lines":[{"line_number":54,"context_line":"RETURN_TO_RESOURCEPOOL \u003d 19"},{"line_number":55,"context_line":"DETACH \u003d 8"},{"line_number":56,"context_line":"INITIALIZED \u003d 2"},{"line_number":57,"context_line":"UNSYNCHRONIZED \u003d 3"},{"line_number":58,"context_line":"BROKEN \u003d 5"},{"line_number":59,"context_line":"PREPARED \u003d 11"},{"line_number":60,"context_line":"REPL \u003d \"FUJITSU_ReplicationService\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_3e3166ed","side":"PARENT","line":57,"updated":"2019-09-12 04:04:09.000000000","message":"It was deleted on the move because it was not used","commit_id":"857df9388783083ab6b630cd00c433ffd40d8035"},{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"b51173a8fd74e56d9d35915f607627b15be84c21","unresolved":false,"context_lines":[{"line_number":56,"context_line":"INITIALIZED \u003d 2"},{"line_number":57,"context_line":"UNSYNCHRONIZED \u003d 3"},{"line_number":58,"context_line":"BROKEN \u003d 5"},{"line_number":59,"context_line":"PREPARED \u003d 11"},{"line_number":60,"context_line":"REPL \u003d \"FUJITSU_ReplicationService\""},{"line_number":61,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":62,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_1e36eae7","side":"PARENT","line":59,"updated":"2019-09-12 04:04:09.000000000","message":"It was deleted on the move because it was not used","commit_id":"857df9388783083ab6b630cd00c433ffd40d8035"},{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"b51173a8fd74e56d9d35915f607627b15be84c21","unresolved":false,"context_lines":[{"line_number":60,"context_line":"REPL \u003d \"FUJITSU_ReplicationService\""},{"line_number":61,"context_line":"STOR_CONF \u003d \"FUJITSU_StorageConfigurationService\""},{"line_number":62,"context_line":"CTRL_CONF \u003d \"FUJITSU_ControllerConfigurationService\""},{"line_number":63,"context_line":"STOR_HWID \u003d \"FUJITSU_StorageHardwareIDManagementService\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"UNDEF_MSG \u003d \u0027Undefined Error!!\u0027"},{"line_number":66,"context_line":"JOB_RETRIES \u003d 60"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_7e37dee4","side":"PARENT","line":63,"updated":"2019-09-12 04:04:09.000000000","message":"It was deleted on the move because it was not used","commit_id":"857df9388783083ab6b630cd00c433ffd40d8035"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d2c64af465dec7d01132f7edcd45ac5bc50596e4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from cinder.i18n import _"},{"line_number":36,"context_line":"from cinder import utils"},{"line_number":37,"context_line":"from cinder.volume import configuration as conf"},{"line_number":38,"context_line":"from cinder.volume.drivers.fujitsu.eternus_dx import constants as CONSTANTS"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c502e3b4","line":38,"updated":"2019-09-20 14:14:35.000000000","message":"For this particular situation, it seems like it would be cleaner to just do:\n    from cinder.volume.drivers.fujitsu.eternus_dx.constants import *\n\n?","commit_id":"be99ddae2c8d716da766b2627034da152b2ee2c2"},{"author":{"_account_id":26387,"name":"Qian Mingyue","email":"qianmy.fnst@cn.fujitsu.com","username":"qianmingyue"},"change_message_id":"facbc360eafec891112d26f28e26f94beea9c71d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from cinder.i18n import _"},{"line_number":36,"context_line":"from cinder import utils"},{"line_number":37,"context_line":"from cinder.volume import configuration as conf"},{"line_number":38,"context_line":"from cinder.volume.drivers.fujitsu.eternus_dx import constants as CONSTANTS"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":41,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c18401b4","line":38,"in_reply_to":"3fa7e38b_c502e3b4","updated":"2019-09-23 01:34:33.000000000","message":"\u003e For this particular situation, it seems like it would be cleaner to\n \u003e just do:\n \u003e from cinder.volume.drivers.fujitsu.eternus_dx.constants import *\n \u003e \n \u003e ?\n\nYou are right, but we don\u0027t want to change this. For historical reasons, we are now offering a version of 1.6.0. We want the community code to be upgraded from 1.3.0 to 1.6.0. We can\u0027t stand this difference if we make changes. If this is necessary then we will consider the change, even if it will pay a lot of price. Thank you.","commit_id":"be99ddae2c8d716da766b2627034da152b2ee2c2"}]}