)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"64c91aa4a665657f2da0809f658160f65b8fead5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yeshwanth Allampati \u003callampati.yeshwanth@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-22 08:57:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix openstack cinder bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch to avoid the out of space issue when migrating encrypted"},{"line_number":10,"context_line":"volume between two LVM backends"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Migration of encrypted volumes or retyping to encrypted volumes causes"},{"line_number":13,"context_line":"an outofspace issue. This process has dd copy command which assumes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a6e79b12","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":31},"updated":"2019-09-22 14:53:42.000000000","message":"Not a very useful commit title. Maybe something like \"Avoid out of space issue when migrating encrypted volume\"","commit_id":"ad8210c30419eabe58c124b0b1036d129cea359c"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"71931b500c88d01d29b53625a242da8edc54b1a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yeshwanth Allampati \u003callampati.yeshwanth@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-22 08:57:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix openstack cinder bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Patch to avoid the out of space issue when migrating encrypted"},{"line_number":10,"context_line":"volume between two LVM backends"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Migration of encrypted volumes or retyping to encrypted volumes causes"},{"line_number":13,"context_line":"an outofspace issue. This process has dd copy command which assumes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_af3f52b2","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"3fa7e38b_a6e79b12","updated":"2019-09-24 12:09:09.000000000","message":"Done","commit_id":"ad8210c30419eabe58c124b0b1036d129cea359c"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c680833ea3628006c65a9d2a9166963ef1e3e68","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        :param mirror_count: Use LVM mirroring with specified count"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if lv_type \u003d\u003d \u0027thin\u0027:"},{"line_number":544,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":545,"context_line":"\t    #Fix Bug 1720885"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_711a6817","line":542,"updated":"2019-09-16 13:25:35.000000000","message":"This method is also called when creating a volume from a snapshot in the LVM driver.  I suspect in that case, we need to not add 2MB to the size.","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"9e5f8897df152010bfb726c0a4161b6f45690e57","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        :param mirror_count: Use LVM mirroring with specified count"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        \"\"\""},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        if lv_type \u003d\u003d \u0027thin\u0027:"},{"line_number":544,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":545,"context_line":"\t    #Fix Bug 1720885"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3a823eca","line":542,"in_reply_to":"5faad753_711a6817","updated":"2019-09-18 05:21:22.000000000","message":"Yes. The 2 MB is added to the size only when os.environ is set. The os.environ is set only when a new enryption_key_id is set in _migrate_volume_generic function of manager.py. In other scenerios, I hope that the os.environ[\u0027isencrypted\u0027] will not be having any value avoiding the additional 2MB.","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c680833ea3628006c65a9d2a9166963ef1e3e68","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        if lv_type \u003d\u003d \u0027thin\u0027:"},{"line_number":544,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":545,"context_line":"\t    #Fix Bug 1720885"},{"line_number":546,"context_line":"\t    if os.environ.get(\u0027isEncrypted\u0027)\u003d\u003d\u00271\u0027:"},{"line_number":547,"context_line":"\t\tst \u003d int(size_str[:-1]) "},{"line_number":548,"context_line":"\t\tintofst \u003d st* 1024 + 2 "},{"line_number":549,"context_line":"\t\tst \u003d str(intofst) + \u0027m\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_9167e4b7","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":37},"updated":"2019-09-16 13:25:35.000000000","message":"This should not check os.environ, any info like this would be passed in via the method parameters etc.","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"9e5f8897df152010bfb726c0a4161b6f45690e57","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        if lv_type \u003d\u003d \u0027thin\u0027:"},{"line_number":544,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":545,"context_line":"\t    #Fix Bug 1720885"},{"line_number":546,"context_line":"\t    if os.environ.get(\u0027isEncrypted\u0027)\u003d\u003d\u00271\u0027:"},{"line_number":547,"context_line":"\t\tst \u003d int(size_str[:-1]) "},{"line_number":548,"context_line":"\t\tintofst \u003d st* 1024 + 2 "},{"line_number":549,"context_line":"\t\tst \u003d str(intofst) + \u0027m\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fa87c6b5","line":546,"range":{"start_line":546,"start_character":8,"end_line":546,"end_character":37},"in_reply_to":"5faad753_9167e4b7","updated":"2019-09-18 05:21:22.000000000","message":"I have tried several methods to do this. Can we do this using python multiprocessing module?","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3c680833ea3628006c65a9d2a9166963ef1e3e68","unresolved":false,"context_lines":[{"line_number":545,"context_line":"\t    #Fix Bug 1720885"},{"line_number":546,"context_line":"\t    if os.environ.get(\u0027isEncrypted\u0027)\u003d\u003d\u00271\u0027:"},{"line_number":547,"context_line":"\t\tst \u003d int(size_str[:-1]) "},{"line_number":548,"context_line":"\t\tintofst \u003d st* 1024 + 2 "},{"line_number":549,"context_line":"\t\tst \u003d str(intofst) + \u0027m\u0027"},{"line_number":550,"context_line":"\t\tdel os.environ[\u0027isEncrypted\u0027]"},{"line_number":551,"context_line":"\t\tcmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, st, \u0027-n\u0027, name, pool_path]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_510bacd4","line":548,"updated":"2019-09-16 13:25:35.000000000","message":"Do we know that the \"correct\" way to size the LV is always +2MB?\n\nThis may change as we introduce LUKS2.","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"9e5f8897df152010bfb726c0a4161b6f45690e57","unresolved":false,"context_lines":[{"line_number":545,"context_line":"\t    #Fix Bug 1720885"},{"line_number":546,"context_line":"\t    if os.environ.get(\u0027isEncrypted\u0027)\u003d\u003d\u00271\u0027:"},{"line_number":547,"context_line":"\t\tst \u003d int(size_str[:-1]) "},{"line_number":548,"context_line":"\t\tintofst \u003d st* 1024 + 2 "},{"line_number":549,"context_line":"\t\tst \u003d str(intofst) + \u0027m\u0027"},{"line_number":550,"context_line":"\t\tdel os.environ[\u0027isEncrypted\u0027]"},{"line_number":551,"context_line":"\t\tcmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, st, \u0027-n\u0027, name, pool_path]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_fa7586cd","line":548,"in_reply_to":"5faad753_510bacd4","updated":"2019-09-18 05:21:22.000000000","message":"Will check this one.","commit_id":"ef72aadd514a3e8aee1a155d2cc935c66cf026f0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"15052fd5b0a18f002279a08c5eb21b1bcb64ab5b","unresolved":false,"context_lines":[{"line_number":872,"context_line":"            LOG.error(\u0027Cmd     :%s\u0027, err.cmd)"},{"line_number":873,"context_line":"            LOG.error(\u0027StdOut  :%s\u0027, err.stdout)"},{"line_number":874,"context_line":"            LOG.error(\u0027StdErr  :%s\u0027, err.stderr)"},{"line_number":875,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_20289ae0","line":875,"updated":"2019-09-19 15:37:30.000000000","message":"new line is required at end of file","commit_id":"432491818fad66eafe53971a732c560ad8f74a9b"}],"cinder/volume/manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"15052fd5b0a18f002279a08c5eb21b1bcb64ab5b","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"import requests"},{"line_number":40,"context_line":"import time"},{"line_number":41,"context_line":"import os"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"from castellan import key_manager"},{"line_number":44,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_c02e66f9","line":41,"range":{"start_line":41,"start_character":0,"end_line":41,"end_character":9},"updated":"2019-09-19 15:37:30.000000000","message":"this should be imported before requests","commit_id":"432491818fad66eafe53971a732c560ad8f74a9b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"15052fd5b0a18f002279a08c5eb21b1bcb64ab5b","unresolved":false,"context_lines":[{"line_number":5008,"context_line":"            LOG.exception(err_msg)"},{"line_number":5009,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":5010,"context_line":""},{"line_number":5011,"context_line":"        return {\u0027replication_targets\u0027: replication_targets}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_600e928e","line":5011,"updated":"2019-09-19 15:37:30.000000000","message":"new line is required at end of file","commit_id":"432491818fad66eafe53971a732c560ad8f74a9b"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"aff342c4cf0e49263f186aed967a8246abd7ebe2","unresolved":false,"context_lines":[{"line_number":5008,"context_line":"            LOG.exception(err_msg)"},{"line_number":5009,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":5010,"context_line":""},{"line_number":5011,"context_line":"        return {\u0027replication_targets\u0027: replication_targets}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ab98c6bf","line":5011,"in_reply_to":"3fa7e38b_18b4ea34","updated":"2019-09-22 08:59:30.000000000","message":"Done","commit_id":"432491818fad66eafe53971a732c560ad8f74a9b"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"cbeb491dd496e7699a6c9fa6e1e324833ea4433d","unresolved":false,"context_lines":[{"line_number":5008,"context_line":"            LOG.exception(err_msg)"},{"line_number":5009,"context_line":"            raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":5010,"context_line":""},{"line_number":5011,"context_line":"        return {\u0027replication_targets\u0027: replication_targets}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_18b4ea34","line":5011,"in_reply_to":"3fa7e38b_600e928e","updated":"2019-09-20 11:22:23.000000000","message":"Thanks for the review. Will rectify it.","commit_id":"432491818fad66eafe53971a732c560ad8f74a9b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cf102d253dc859ed277a876286e75cda56d9d34d","unresolved":false,"context_lines":[{"line_number":2204,"context_line":"                    ctxt, self.key_manager, new_type_id)"},{"line_number":2205,"context_line":"                new_vol_values[\u0027encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":2206,"context_line":"                # Fix Bug 1720885"},{"line_number":2207,"context_line":"                os.environ[\"isEncrypted\"] \u003d \"1\""},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":"        dst_service \u003d self._get_service(backend[\u0027host\u0027])"},{"line_number":2210,"context_line":"        new_volume \u003d objects.Volume("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_068868c3","line":2207,"range":{"start_line":2207,"start_character":0,"end_line":2207,"end_character":47},"updated":"2019-11-25 16:04:52.000000000","message":"It looks really hacky solution. I don\u0027t have any better solution in the mind so I put -1 to get more feedback on it.\n\nFeel free to ignore my vote if you think it could be merged","commit_id":"94ca6acc328a458e250f1bf40ec8f7f7c3e7dbfe"},{"author":{"_account_id":30974,"name":"Yeshwanth Allampati","email":"allampati.yeshwanth@tcs.com","username":"YeshwanthAllampati"},"change_message_id":"1897cd4deccabae8907d20303a71247a3b919607","unresolved":false,"context_lines":[{"line_number":2204,"context_line":"                    ctxt, self.key_manager, new_type_id)"},{"line_number":2205,"context_line":"                new_vol_values[\u0027encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":2206,"context_line":"                # Fix Bug 1720885"},{"line_number":2207,"context_line":"                os.environ[\"isEncrypted\"] \u003d \"1\""},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":"        dst_service \u003d self._get_service(backend[\u0027host\u0027])"},{"line_number":2210,"context_line":"        new_volume \u003d objects.Volume("}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_3cdf9739","line":2207,"range":{"start_line":2207,"start_character":0,"end_line":2207,"end_character":47},"in_reply_to":"3fa7e38b_068868c3","updated":"2019-11-27 06:44:31.000000000","message":"I will just share my analogy behind this line of code :-\n\nWe need \u0027lvcreate\u0027 command to work in a different way whenever we are dealing with an encrypted volume. So manager.py has to send a flag to the lvm.py if we are dealing with an encrypted volume. As \"The Environment variables are passed on from parent process to child process in python\", I felt Setting an Environment variable could be a better way.","commit_id":"94ca6acc328a458e250f1bf40ec8f7f7c3e7dbfe"}]}