)]}'
{"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"83cf89fba2fce6839631ab08c197a5804968fc40","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                self._key_manager.get(context, volume.encryption_key_id))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"            image_metadata[\u0027cinder_encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":229,"context_line":"            image_metadata[\u0027cinder_encryption_key_deletion_policy\u0027] \u003d \\"},{"line_number":230,"context_line":"                \u0027on_image_deletion\u0027"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if req_version \u003e\u003d mv.get_api_version("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7bd2ae5e","line":229,"updated":"2019-09-20 15:17:10.000000000","message":"Is there a way to do this without using \\?","commit_id":"105ba99cbaac6f5ddc8aa7d6491d74b7f9e57339"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f7c1419261d061048f2031c4835441be6835cdd","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                self._key_manager.get(context, volume.encryption_key_id))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"            image_metadata[\u0027cinder_encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":229,"context_line":"            image_metadata[\u0027cinder_encryption_key_deletion_policy\u0027] \u003d \\"},{"line_number":230,"context_line":"                \u0027on_image_deletion\u0027"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if req_version \u003e\u003d mv.get_api_version("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ef5fb83e","line":229,"in_reply_to":"3fa7e38b_3beaf674","updated":"2019-09-20 17:20:34.000000000","message":"I thought the parentheses looked worse; the only other thing I could think of was to assign the key/values to short variable names, but that seemed kind of overkill (plus, I couldn\u0027t think of shorter names that weren\u0027t too cryptic). The backslash is a venerable python language construct; using seemed the best thing to me.","commit_id":"105ba99cbaac6f5ddc8aa7d6491d74b7f9e57339"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"49c8664af7c4e8b2c66c4a800bf2904a1a34dbd5","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                self._key_manager.get(context, volume.encryption_key_id))"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"            image_metadata[\u0027cinder_encryption_key_id\u0027] \u003d encryption_key_id"},{"line_number":229,"context_line":"            image_metadata[\u0027cinder_encryption_key_deletion_policy\u0027] \u003d \\"},{"line_number":230,"context_line":"                \u0027on_image_deletion\u0027"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        if req_version \u003e\u003d mv.get_api_version("}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3beaf674","line":229,"in_reply_to":"3fa7e38b_7bd2ae5e","updated":"2019-09-20 15:34:49.000000000","message":"Backslash is cleaner here than squeezing in parentheses for no particular reason IMO","commit_id":"105ba99cbaac6f5ddc8aa7d6491d74b7f9e57339"}],"cinder/tests/unit/api/contrib/test_volume_actions.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eeafe95e3a2212465e5fdf6c26f9bd0b2b973d8d","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        mock_copy_vol.side_effect \u003d really_fake_upload_volume"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        FAKE_ID \u003d \u0027fake-encryption-key-id\u0027"},{"line_number":906,"context_line":"        mock_key_mgr \u003d mock.Mock()"},{"line_number":907,"context_line":"        mock_key_mgr.store \u003d mock.Mock(return_value\u003dFAKE_ID)"},{"line_number":908,"context_line":"        self.controller._key_mgr \u003d mock_key_mgr"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        id \u003d ENCRYPTED_VOLUME_ID"},{"line_number":911,"context_line":"        img \u003d {\"container_format\": \u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_8a75a466","line":908,"range":{"start_line":906,"start_character":0,"end_line":908,"end_character":47},"updated":"2019-09-24 13:11:06.000000000","message":"We should path the object instead of just replacing the attribute\n\n  self.mock_object(self.controller, \u0027_key_mgr\u0027)\n  self.controller._key_mgr.return_value \u003d FAKE_ID","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6f196f1804dba3d5c39a2f0c4c05d9841b202af","unresolved":false,"context_lines":[{"line_number":903,"context_line":"        mock_copy_vol.side_effect \u003d really_fake_upload_volume"},{"line_number":904,"context_line":""},{"line_number":905,"context_line":"        FAKE_ID \u003d \u0027fake-encryption-key-id\u0027"},{"line_number":906,"context_line":"        mock_key_mgr \u003d mock.Mock()"},{"line_number":907,"context_line":"        mock_key_mgr.store \u003d mock.Mock(return_value\u003dFAKE_ID)"},{"line_number":908,"context_line":"        self.controller._key_mgr \u003d mock_key_mgr"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        id \u003d ENCRYPTED_VOLUME_ID"},{"line_number":911,"context_line":"        img \u003d {\"container_format\": \u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_850fd535","line":908,"range":{"start_line":906,"start_character":0,"end_line":908,"end_character":47},"in_reply_to":"3fa7e38b_8a75a466","updated":"2019-09-24 14:10:21.000000000","message":"Done","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eeafe95e3a2212465e5fdf6c26f9bd0b2b973d8d","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        mock_key_mgr.store \u003d mock.Mock(return_value\u003dFAKE_ID)"},{"line_number":908,"context_line":"        self.controller._key_mgr \u003d mock_key_mgr"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        id \u003d ENCRYPTED_VOLUME_ID"},{"line_number":911,"context_line":"        img \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":912,"context_line":"               \"disk_format\": \u0027raw\u0027,"},{"line_number":913,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_4f057e13","line":910,"range":{"start_line":910,"start_character":8,"end_line":910,"end_character":10},"updated":"2019-09-24 13:11:06.000000000","message":"In general it\u0027s not a good idea to overwrite the `id` builtin function with a variable of the same name.","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6f196f1804dba3d5c39a2f0c4c05d9841b202af","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        mock_key_mgr.store \u003d mock.Mock(return_value\u003dFAKE_ID)"},{"line_number":908,"context_line":"        self.controller._key_mgr \u003d mock_key_mgr"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        id \u003d ENCRYPTED_VOLUME_ID"},{"line_number":911,"context_line":"        img \u003d {\"container_format\": \u0027bare\u0027,"},{"line_number":912,"context_line":"               \"disk_format\": \u0027raw\u0027,"},{"line_number":913,"context_line":"               \"image_name\": \u0027image_name\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_00019305","line":910,"range":{"start_line":910,"start_character":8,"end_line":910,"end_character":10},"in_reply_to":"3fa7e38b_4f057e13","updated":"2019-09-24 14:10:21.000000000","message":"Done","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eeafe95e3a2212465e5fdf6c26f9bd0b2b973d8d","unresolved":false,"context_lines":[{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        sent_meta \u003d res_dict[\u0027os-volume_upload_image\u0027]"},{"line_number":921,"context_line":"        self.assertIn(\u0027cinder_encryption_key_id\u0027, sent_meta)"},{"line_number":922,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_id\u0027], FAKE_ID)"},{"line_number":923,"context_line":"        self.assertIn(\u0027cinder_encryption_key_deletion_policy\u0027, sent_meta)"},{"line_number":924,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_deletion_policy\u0027],"},{"line_number":925,"context_line":"                         \u0027on_image_deletion\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_af23d2bc","line":922,"updated":"2019-09-24 13:11:06.000000000","message":"-1: Asserts must be (expected, actual), so in this case:\n\n  self.assertEqual(FAKE_ID, sent_meta[\u0027cinder_encryption_key_id\u0027])","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6f196f1804dba3d5c39a2f0c4c05d9841b202af","unresolved":false,"context_lines":[{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        sent_meta \u003d res_dict[\u0027os-volume_upload_image\u0027]"},{"line_number":921,"context_line":"        self.assertIn(\u0027cinder_encryption_key_id\u0027, sent_meta)"},{"line_number":922,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_id\u0027], FAKE_ID)"},{"line_number":923,"context_line":"        self.assertIn(\u0027cinder_encryption_key_deletion_policy\u0027, sent_meta)"},{"line_number":924,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_deletion_policy\u0027],"},{"line_number":925,"context_line":"                         \u0027on_image_deletion\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c0061b1d","line":922,"in_reply_to":"3fa7e38b_af23d2bc","updated":"2019-09-24 14:10:21.000000000","message":"Done","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"eeafe95e3a2212465e5fdf6c26f9bd0b2b973d8d","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertIn(\u0027cinder_encryption_key_id\u0027, sent_meta)"},{"line_number":922,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_id\u0027], FAKE_ID)"},{"line_number":923,"context_line":"        self.assertIn(\u0027cinder_encryption_key_deletion_policy\u0027, sent_meta)"},{"line_number":924,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_deletion_policy\u0027],"},{"line_number":925,"context_line":"                         \u0027on_image_deletion\u0027)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"    @mock.patch.object(volume_api.API, \u0027get\u0027, fake_volume_get_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_6f295a99","line":924,"updated":"2019-09-24 13:11:06.000000000","message":"ditto","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d6f196f1804dba3d5c39a2f0c4c05d9841b202af","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertIn(\u0027cinder_encryption_key_id\u0027, sent_meta)"},{"line_number":922,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_id\u0027], FAKE_ID)"},{"line_number":923,"context_line":"        self.assertIn(\u0027cinder_encryption_key_deletion_policy\u0027, sent_meta)"},{"line_number":924,"context_line":"        self.assertEqual(sent_meta[\u0027cinder_encryption_key_deletion_policy\u0027],"},{"line_number":925,"context_line":"                         \u0027on_image_deletion\u0027)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"    @mock.patch.object(volume_api.API, \u0027get\u0027, fake_volume_get_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e00b1721","line":924,"in_reply_to":"3fa7e38b_6f295a99","updated":"2019-09-24 14:10:21.000000000","message":"Done","commit_id":"e6216289990dda0e262863c740e53cbd49d2e2cd"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"86f528331b777abb4d7ae88b846729988271ee89","unresolved":false,"context_lines":[{"line_number":907,"context_line":"        # need a 2-level mock here"},{"line_number":908,"context_line":"        self.mock_object(self.controller, \u0027_key_mgr\u0027)"},{"line_number":909,"context_line":"        self.controller._key_mgr.return_value \u003d not None"},{"line_number":910,"context_line":"        self.mock_object(self.controller._key_manager, \u0027store\u0027)"},{"line_number":911,"context_line":"        self.controller._key_manager.store.return_value \u003d FAKE_ID"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":"        vol_id \u003d ENCRYPTED_VOLUME_ID"},{"line_number":914,"context_line":"        img \u003d {\"container_format\": \u0027bare\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_dc93585a","line":911,"range":{"start_line":910,"start_character":2,"end_line":911,"end_character":65},"updated":"2019-09-25 07:23:44.000000000","message":"nit: You can pass return_value\u003dFAKE_ID to the mock_object method.\n\n  self.mock_object(self.controller._key_manager, \u0027store\u0027, return_value\u003dFAKE_ID)","commit_id":"827f954cbfa7d01f00256210ad90e98104e90f7d"}]}