)]}'
{"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":7239,"name":"Kiran Kumar Vaddi","email":"kiran-kumar.vaddi@hp.com","username":"kirankv"},"change_message_id":"474093336c274adb6a07d2cc99c428a25deba8a8","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            self._update(context, id, update)"},{"line_number":93,"context_line":"        except exception.NotFound as e:"},{"line_number":94,"context_line":"            raise exc.HTTPNotFound(e)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        notifier_api.notify(context, \u0027volumeStatusUpdate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Brq4%3D","line":93,"updated":"2014-01-23 08:28:42.000000000","message":"If an exception occurs, is it not required to notify the error -or- is this handled elsewhere?","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"3548b5ee787e4312d55ebb901219c7281a09e966","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            self._update(context, id, update)"},{"line_number":93,"context_line":"        except exception.NotFound as e:"},{"line_number":94,"context_line":"            raise exc.HTTPNotFound(e)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        notifier_api.notify(context, \u0027volumeStatusUpdate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BdvM%3D","line":93,"in_reply_to":"AAAAUH%2F%2BnC4%3D","updated":"2014-01-25 17:36:58.000000000","message":"In this particular case of a \"NotFound\" I believe that Jenny is correct and there isn\u0027t a need for any sort of an update (we wouldn\u0027t have the object to update anyway :) )","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"},{"author":{"_account_id":7482,"name":"Jenny Shieh","email":"jenny.shieh@hp.com","username":"jenny-shieh"},"change_message_id":"1a1481a1a28d4ada779f41efc275e69bf92e178b","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        try:"},{"line_number":92,"context_line":"            self._update(context, id, update)"},{"line_number":93,"context_line":"        except exception.NotFound as e:"},{"line_number":94,"context_line":"            raise exc.HTTPNotFound(e)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        notifier_api.notify(context, \u0027volumeStatusUpdate\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BnC4%3D","line":93,"in_reply_to":"AAAAUH%2F%2Brq4%3D","updated":"2014-01-23 22:07:54.000000000","message":"If the update fails and has an exception, the status of the volume does not change and therefore a notify is not needed at this point. The exception will be documented in the log.","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"}],"cinder/api/v1/volumes.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"b13c8ffbd4242dd1cb7d365dc5f5eb044db1789a","unresolved":false,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        self._add_visible_admin_metadata(context, volume)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        volume_utils.notify_about_volume_usage(context, volume,"},{"line_number":484,"context_line":"                                               \u0027update.end\u0027)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        return {\u0027volume\u0027: _translate_volume_detail_view(context, volume)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BcVc%3D","line":483,"updated":"2014-01-26 10:49:01.000000000","message":"notify_about_volume_usage won\u0027t include display_description or metadata in the notification, so we may not be informed of what got updated - is this ok?","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"},{"author":{"_account_id":7482,"name":"Jenny Shieh","email":"jenny.shieh@hp.com","username":"jenny-shieh"},"change_message_id":"993fb488d67cfcf9f6173d5962f7d8b0b787789d","unresolved":false,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        self._add_visible_admin_metadata(context, volume)"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"        volume_utils.notify_about_volume_usage(context, volume,"},{"line_number":484,"context_line":"                                               \u0027update.end\u0027)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        return {\u0027volume\u0027: _translate_volume_detail_view(context, volume)}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BW1Y%3D","line":483,"in_reply_to":"AAAAUH%2F%2BcVc%3D","updated":"2014-01-27 18:45:48.000000000","message":"I think you have a good point. But most of the time  it is  enough, because we get the update notification then we can query the changed volume to get the latest data. \nIn other cases it might be useful to identify the exact change.  We think that the notification  is sufficient.","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"b13c8ffbd4242dd1cb7d365dc5f5eb044db1789a","unresolved":false,"context_lines":[{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        self._add_visible_admin_metadata(context, volume)"},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        volume_utils.notify_about_volume_usage(context, volume,"},{"line_number":460,"context_line":"                                               \u0027update.end\u0027)"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        return self._view_builder.detail(req, volume)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BcVY%3D","line":459,"updated":"2014-01-26 10:49:01.000000000","message":"Same comment as in v1","commit_id":"adbb27239809cb7b85777371b4f9d1599a56661f"}]}