)]}'
{"cinder/api/contrib/services.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ea95a8d29f1248cd382a2fae074afcc9024ab58a","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        log_req \u003d objects.LogLevel(context, prefix\u003dprefix)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        # Avoid showing constants if \u0027server\u0027 is set."},{"line_number":206,"context_line":"        server_filter \u003d body.get(\u0027server\u0027)"},{"line_number":207,"context_line":"        if not server_filter:"},{"line_number":208,"context_line":"            if constants.API_BINARY in binaries:"},{"line_number":209,"context_line":"                levels \u003d utils.get_log_levels(prefix)"},{"line_number":210,"context_line":"                result.append({\u0027host\u0027: CONF.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_887b8927","line":207,"range":{"start_line":205,"start_character":0,"end_line":207,"end_character":29},"updated":"2019-11-14 17:27:14.000000000","message":"if the cinder-api binary is in the same host set as \u0027server\u0027, this code won\u0027t show it which seems wrong.\nIMO we should add a check here comparing \u0027server\u0027 value and CONF.host\n\nif server_filter \u003d\u003d CONF.host:\n    ...","commit_id":"4a2ff3cd57ebbd2c01d7d11afe53e271d703cbde"}],"cinder/tests/unit/api/contrib/test_services.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":826,"context_line":"                          body\u003dbody)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":829,"context_line":"    def test_get_log_w_service_filter(self, get_log_mock):"},{"line_number":830,"context_line":"        service_filter \u003d \u0027controller-0\u0027"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_80fa0773","line":829,"range":{"start_line":829,"start_character":23,"end_line":829,"end_character":30},"updated":"2020-02-14 11:18:07.000000000","message":"server","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":829,"context_line":"    def test_get_log_w_service_filter(self, get_log_mock):"},{"line_number":830,"context_line":"        service_filter \u003d \u0027controller-0\u0027"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"},{"line_number":833,"context_line":"        req \u003d FakeRequest(version\u003dmv.LOG_LEVEL)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_00e617dc","line":830,"range":{"start_line":830,"start_character":8,"end_line":830,"end_character":22},"updated":"2020-02-14 11:18:07.000000000","message":"not important but i think you would like to change this too to server_filter","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    def test_get_log_w_service_filter(self, get_log_mock):"},{"line_number":830,"context_line":"        service_filter \u003d \u0027controller-0\u0027"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"},{"line_number":833,"context_line":"        req \u003d FakeRequest(version\u003dmv.LOG_LEVEL)"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_80e1a7d0","line":832,"range":{"start_line":832,"start_character":36,"end_line":832,"end_character":43},"updated":"2020-02-14 11:18:07.000000000","message":"server","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":838,"context_line":"        get_log_mock.assert_called_once_with(req, mock.sentinel.context, body)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":841,"context_line":"    def test_get_log_w_service_equals_to_host(self, get_log_mock):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e06dfb2f","line":838,"range":{"start_line":837,"start_character":0,"end_line":838,"end_character":78},"updated":"2020-02-14 11:18:07.000000000","message":"since the API binary has a constant name, can we verify that it doesn\u0027t get included in this case\n(since server filter is included and IIUC server name is not similar to hostname)","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        get_log_mock.assert_called_once_with(req, mock.sentinel.context, body)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":841,"context_line":"    def test_get_log_w_service_equals_to_host(self, get_log_mock):"},{"line_number":842,"context_line":"        service_filter \u003d \u0027server-0\u0027"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_e0eadb9e","line":841,"range":{"start_line":841,"start_character":23,"end_line":841,"end_character":30},"updated":"2020-02-14 11:18:07.000000000","message":"server","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":841,"context_line":"    def test_get_log_w_service_equals_to_host(self, get_log_mock):"},{"line_number":842,"context_line":"        service_filter \u003d \u0027server-0\u0027"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"},{"line_number":845,"context_line":"        req \u003d FakeRequest(version\u003dmv.LOG_LEVEL)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_a0262321","line":842,"range":{"start_line":842,"start_character":8,"end_line":842,"end_character":23},"updated":"2020-02-14 11:18:07.000000000","message":"same","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":841,"context_line":"    def test_get_log_w_service_equals_to_host(self, get_log_mock):"},{"line_number":842,"context_line":"        service_filter \u003d \u0027server-0\u0027"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"},{"line_number":845,"context_line":"        req \u003d FakeRequest(version\u003dmv.LOG_LEVEL)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_40c72f3e","line":844,"range":{"start_line":844,"start_character":36,"end_line":844,"end_character":43},"updated":"2020-02-14 11:18:07.000000000","message":"server","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5732455da8fe23384dfaef2ffe1c4338a5a220cc","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        body \u003d {\u0027host\u0027: CONF.host, \u0027service\u0027: service_filter}"},{"line_number":845,"context_line":"        req \u003d FakeRequest(version\u003dmv.LOG_LEVEL)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"},{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"    @ddt.data(None, \u0027\u0027, \u0027*\u0027)"},{"line_number":852,"context_line":"    @mock.patch(\u0027cinder.objects.ServiceList.get_all\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2051d363","line":849,"range":{"start_line":847,"start_character":0,"end_line":849,"end_character":63},"updated":"2020-02-14 11:18:07.000000000","message":"here we can confirm that API binary isn\u0027t included in the result","commit_id":"1f9e70aa85c6201b812a55a1351bcf96a9571263"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"231c6e029eca97c139d9ba9e075ce876e1229039","unresolved":false,"context_lines":[{"line_number":834,"context_line":""},{"line_number":835,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"},{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":838,"context_line":"        get_log_mock.assert_called_once_with(req, mock.sentinel.context, body)"},{"line_number":839,"context_line":"        self.assertNotEqual(log_levels[\u0027binary\u0027], constants.API_BINARY)"},{"line_number":840,"context_line":"        self.assertIsNot(log_levels, constants.API_BINARY)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_32cab619","line":837,"range":{"start_line":837,"start_character":8,"end_line":837,"end_character":63},"updated":"2020-06-18 08:29:09.000000000","message":"they both are mock objects here so are equal,\n\u003cMagicMock name\u003d\u0027_get_log()\u0027 id\u003d\u0027140158816818008\u0027\u003e","commit_id":"e793c5e24982e2f0d2bc3a681f5a1e3912af08b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"231c6e029eca97c139d9ba9e075ce876e1229039","unresolved":false,"context_lines":[{"line_number":836,"context_line":""},{"line_number":837,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":838,"context_line":"        get_log_mock.assert_called_once_with(req, mock.sentinel.context, body)"},{"line_number":839,"context_line":"        self.assertNotEqual(log_levels[\u0027binary\u0027], constants.API_BINARY)"},{"line_number":840,"context_line":"        self.assertIsNot(log_levels, constants.API_BINARY)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_b267e651","line":839,"range":{"start_line":839,"start_character":8,"end_line":839,"end_character":71},"updated":"2020-06-18 08:29:09.000000000","message":"i\u0027m not sure what we\u0027re actually checking here,\nlog_levels is a mock reference\n\u003cMagicMock name\u003d\u0027_get_log().__getitem__()\u0027 id\u003d\u0027140158816508896\u0027\u003e\nand constants.API_BINARY \u003d \u0027cinder-api\u0027\nso ofcourse they won\u0027t be equal but what we\u0027re trying to achieve with this assert here?","commit_id":"e793c5e24982e2f0d2bc3a681f5a1e3912af08b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"231c6e029eca97c139d9ba9e075ce876e1229039","unresolved":false,"context_lines":[{"line_number":837,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":838,"context_line":"        get_log_mock.assert_called_once_with(req, mock.sentinel.context, body)"},{"line_number":839,"context_line":"        self.assertNotEqual(log_levels[\u0027binary\u0027], constants.API_BINARY)"},{"line_number":840,"context_line":"        self.assertIsNot(log_levels, constants.API_BINARY)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"    @mock.patch(\u0027cinder.api.contrib.services.ServiceController._get_log\u0027)"},{"line_number":843,"context_line":"    def test_get_log_w_server_equals_to_host(self, get_log_mock):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_d2553a52","line":840,"range":{"start_line":840,"start_character":8,"end_line":840,"end_character":58},"updated":"2020-06-18 08:29:09.000000000","message":"log_levels \u003d \u003cMagicMock name\u003d\u0027_get_log()\u0027 id\u003d\u0027140158816818008\u0027\u003e\n\nconstants.API_BINARY \u003d \u0027cinder-api\u0027\n\nsame question, what is the purpose of this assert?","commit_id":"e793c5e24982e2f0d2bc3a681f5a1e3912af08b0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"231c6e029eca97c139d9ba9e075ce876e1229039","unresolved":false,"context_lines":[{"line_number":848,"context_line":""},{"line_number":849,"context_line":"        log_levels \u003d self.controller._get_log(req, mock.sentinel.context, body)"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":"        self.assertEqual(get_log_mock.return_value, log_levels)"},{"line_number":852,"context_line":"        self.assertNotEqual(log_levels[\u0027binary\u0027], constants.API_BINARY)"},{"line_number":853,"context_line":"        self.assertIsNot(log_levels, constants.API_BINARY)"},{"line_number":854,"context_line":""},{"line_number":855,"context_line":"    @ddt.data(None, \u0027\u0027, \u0027*\u0027)"},{"line_number":856,"context_line":"    @mock.patch(\u0027cinder.objects.ServiceList.get_all\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf51134e_72d42ebe","line":853,"range":{"start_line":851,"start_character":8,"end_line":853,"end_character":58},"updated":"2020-06-18 08:29:09.000000000","message":"same as above","commit_id":"e793c5e24982e2f0d2bc3a681f5a1e3912af08b0"}]}