)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"101ac4d1fd42c92e08771ccfed2c0d6eb5e49653","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-02 12:03:55 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure generated volume name does not exceed 63 characters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some OpenStack deployments create a volume.name, that when linked with"},{"line_number":10,"context_line":"Pure\u0027s naming standard, the resulting volume name length exceeds the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_60379de5","line":7,"updated":"2019-10-02 16:11:51.000000000","message":"Would be good to have some indication that this is related to the pure driver. Maybe something like \"Pure: limit volume names to 63 characters\"?","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"101ac4d1fd42c92e08771ccfed2c0d6eb5e49653","unresolved":false,"context_lines":[{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        # Some OpenStack deployments, eg PowerVC, create a volume.name that"},{"line_number":1551,"context_line":"        # when appended with out \u0027-cinder\u0027 string will exceed the maximum"},{"line_number":1552,"context_line":"        # volume name length for Pure, so here we ctruncate the true volume"},{"line_number":1553,"context_line":"        # name before the opennstack volume_name_template affected it and"},{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c02691bb","line":1552,"range":{"start_line":1552,"start_character":50,"end_line":1552,"end_character":59},"updated":"2019-10-02 16:11:51.000000000","message":"truncate","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ad2545b703c7ef3e20c27201100640d936b05279","unresolved":false,"context_lines":[{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"        # Some OpenStack deployments, eg PowerVC, create a volume.name that"},{"line_number":1551,"context_line":"        # when appended with out \u0027-cinder\u0027 string will exceed the maximum"},{"line_number":1552,"context_line":"        # volume name length for Pure, so here we ctruncate the true volume"},{"line_number":1553,"context_line":"        # name before the opennstack volume_name_template affected it and"},{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_40962197","line":1552,"range":{"start_line":1552,"start_character":50,"end_line":1552,"end_character":59},"in_reply_to":"3fa7e38b_c02691bb","updated":"2019-10-02 16:19:20.000000000","message":"will change this to `left truncate` as that is more descriptive","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"101ac4d1fd42c92e08771ccfed2c0d6eb5e49653","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"        # name before the opennstack volume_name_template affected it and"},{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"},{"line_number":1556,"context_line":"            actual_name \u003d base_name[7:]"},{"line_number":1557,"context_line":"            base_name \u003d \"volume-\" + actual_name[-52:]"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        repl_type \u003d self._get_replication_type_from_vol_type("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c0fd3109","line":1556,"range":{"start_line":1556,"start_character":35,"end_line":1556,"end_character":39},"updated":"2019-10-02 16:11:51.000000000","message":"I think you actually want base_name[:-7]?","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ad2545b703c7ef3e20c27201100640d936b05279","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"        # name before the opennstack volume_name_template affected it and"},{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"},{"line_number":1556,"context_line":"            actual_name \u003d base_name[7:]"},{"line_number":1557,"context_line":"            base_name \u003d \"volume-\" + actual_name[-52:]"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        repl_type \u003d self._get_replication_type_from_vol_type("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_406861b9","line":1556,"range":{"start_line":1556,"start_character":35,"end_line":1556,"end_character":39},"in_reply_to":"3fa7e38b_c0fd3109","updated":"2019-10-02 16:19:20.000000000","message":"What I\u0027m doing is removing the \u0027volume-\u0027 that is added by the volume_name_template\u0027 and then truncating the left part of the real volume name as this is less unique that the right end of the string. Then I add back the `volume-` to bring the name back into alignment with the standard","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"101ac4d1fd42c92e08771ccfed2c0d6eb5e49653","unresolved":false,"context_lines":[{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"},{"line_number":1556,"context_line":"            actual_name \u003d base_name[7:]"},{"line_number":1557,"context_line":"            base_name \u003d \"volume-\" + actual_name[-52:]"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        repl_type \u003d self._get_replication_type_from_vol_type("},{"line_number":1560,"context_line":"            volume.volume_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2018c573","line":1557,"updated":"2019-10-02 16:11:51.000000000","message":"Don\u0027t you want the first part of the name? Might seem odd to just have the last 52 characters.","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"ad2545b703c7ef3e20c27201100640d936b05279","unresolved":false,"context_lines":[{"line_number":1554,"context_line":"        # then put back the template format"},{"line_number":1555,"context_line":"        if len(base_name) \u003e 56:"},{"line_number":1556,"context_line":"            actual_name \u003d base_name[7:]"},{"line_number":1557,"context_line":"            base_name \u003d \"volume-\" + actual_name[-52:]"},{"line_number":1558,"context_line":""},{"line_number":1559,"context_line":"        repl_type \u003d self._get_replication_type_from_vol_type("},{"line_number":1560,"context_line":"            volume.volume_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_807c1973","line":1557,"in_reply_to":"3fa7e38b_2018c573","updated":"2019-10-02 16:19:20.000000000","message":"See above","commit_id":"618da6b3ce88eeeecf4b36fc16f96b42d86d80a9"}]}