)]}'
{"cinder/volume/volume_types.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0e34ae9cc88f24b7348a08a771114ff421e5aa0c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                 old_type_name,"},{"line_number":87,"context_line":"                                                 name)"},{"line_number":88,"context_line":"                # Rollback the updated information to the original"},{"line_number":89,"context_line":"                except db_exc.DBError:"},{"line_number":90,"context_line":"                    db.volume_type_update(elevated, id,"},{"line_number":91,"context_line":"                                          dict(name\u003dold_type_name,"},{"line_number":92,"context_line":"                                               description\u003dold_description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5ede92da","line":89,"range":{"start_line":89,"start_character":30,"end_line":89,"end_character":37},"updated":"2019-10-09 18:42:27.000000000","message":"I suspect this should be a narrower exception class like DBDataError?\n\nDoing this on DBError means it also would be done on connection errors, which I\u0027m not sure is correct.","commit_id":"c9efc9e81b4e8b7992d75f06d159faeef8fa77ad"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"40745e238681b81034cb9889eb337a81e676b4ae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                 old_type_name,"},{"line_number":87,"context_line":"                                                 name)"},{"line_number":88,"context_line":"                # Rollback the updated information to the original"},{"line_number":89,"context_line":"                except db_exc.DBError:"},{"line_number":90,"context_line":"                    db.volume_type_update(elevated, id,"},{"line_number":91,"context_line":"                                          dict(name\u003dold_type_name,"},{"line_number":92,"context_line":"                                               description\u003dold_description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e638d73b","line":89,"range":{"start_line":89,"start_character":30,"end_line":89,"end_character":37},"in_reply_to":"3fa7e38b_58e6864c","updated":"2019-12-10 21:53:27.000000000","message":"If we get a connection error at line 85, line 75 has succeeded and the type has been renamed but the change hasn\u0027t been made in the quotas table. So I think a rollback of the change from line 75 is correct (if we can connect to the db at line 90).  Even if we look for a more specific error here, the raise at line 94 is going to be caught at line 95, and we\u0027ll be returning VolumeTypeUpdateFailed, in which case I think having rolled the update back is more accurate.","commit_id":"c9efc9e81b4e8b7992d75f06d159faeef8fa77ad"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"22a81cc4e45328ef92628c4ac779c53724f51a22","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                                                 old_type_name,"},{"line_number":87,"context_line":"                                                 name)"},{"line_number":88,"context_line":"                # Rollback the updated information to the original"},{"line_number":89,"context_line":"                except db_exc.DBError:"},{"line_number":90,"context_line":"                    db.volume_type_update(elevated, id,"},{"line_number":91,"context_line":"                                          dict(name\u003dold_type_name,"},{"line_number":92,"context_line":"                                               description\u003dold_description,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_58e6864c","line":89,"range":{"start_line":89,"start_character":30,"end_line":89,"end_character":37},"in_reply_to":"3fa7e38b_5ede92da","updated":"2019-12-09 10:37:05.000000000","message":"I\u0027m OK with this patch because it\u0027s a cherry-pick","commit_id":"c9efc9e81b4e8b7992d75f06d159faeef8fa77ad"}]}