)]}'
{"cinder/api/contrib/types_manage.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"148a07c7a79e8bffced03785ce66a7dbd2a20ddf","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if is_public is not None:"},{"line_number":100,"context_line":"            is_public \u003d strutils.bool_from_string(is_public, strict\u003dTrue)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # If name specified, name can not be empty or greater than 255."},{"line_number":103,"context_line":"        if name is not None:"},{"line_number":104,"context_line":"            if len(name.strip()) \u003d\u003d 0:"},{"line_number":105,"context_line":"                msg \u003d _(\"Volume type name cannot be empty.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1fbfc6fb","line":102,"updated":"2019-10-09 02:20:41.000000000","message":"Please add the unit test for the scenario of request the name empty or the length \u003e 255, then match the raise message.","commit_id":"21b08c1d1869d52a4e4ccf241e55c93bc48ab538"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"194616ceb6d425b7fdb0539c0fe337f235a65ba1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if is_public is not None:"},{"line_number":100,"context_line":"            is_public \u003d strutils.bool_from_string(is_public, strict\u003dTrue)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # If name specified, name can not be empty or greater than 255."},{"line_number":103,"context_line":"        if name is not None:"},{"line_number":104,"context_line":"            if len(name.strip()) \u003d\u003d 0:"},{"line_number":105,"context_line":"                msg \u003d _(\"Volume type name cannot be empty.\")"},{"line_number":106,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":107,"context_line":"            if len(name) \u003e 255:"},{"line_number":108,"context_line":"                msg \u003d _(\"Volume type name cannot be greater than 255 \""},{"line_number":109,"context_line":"                        \"characters in length.\")"},{"line_number":110,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If description specified, length can not greater than 255."},{"line_number":113,"context_line":"        if description and len(description) \u003e 255:"},{"line_number":114,"context_line":"            msg \u003d _(\"Volume type description cannot be greater than 255 \""},{"line_number":115,"context_line":"                    \"characters in length.\")"},{"line_number":116,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Name, description and is_public can not be None."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f3bea1d2","line":115,"range":{"start_line":102,"start_character":0,"end_line":115,"end_character":44},"updated":"2019-10-09 09:44:58.000000000","message":"The maximum length case is already validated at L#89\n https://opendev.org/openstack/cinder/src/branch/master/cinder/api/validation/parameter_types.py#L122-L125","commit_id":"21b08c1d1869d52a4e4ccf241e55c93bc48ab538"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0d5e0c4d200dc1801bc8cddb3428ca7c4ca2de36","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if is_public is not None:"},{"line_number":100,"context_line":"            is_public \u003d strutils.bool_from_string(is_public, strict\u003dTrue)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        # If name specified, name can not be empty or greater than 255."},{"line_number":103,"context_line":"        if name is not None:"},{"line_number":104,"context_line":"            if len(name.strip()) \u003d\u003d 0:"},{"line_number":105,"context_line":"                msg \u003d _(\"Volume type name cannot be empty.\")"},{"line_number":106,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":107,"context_line":"            if len(name) \u003e 255:"},{"line_number":108,"context_line":"                msg \u003d _(\"Volume type name cannot be greater than 255 \""},{"line_number":109,"context_line":"                        \"characters in length.\")"},{"line_number":110,"context_line":"                raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        # If description specified, length can not greater than 255."},{"line_number":113,"context_line":"        if description and len(description) \u003e 255:"},{"line_number":114,"context_line":"            msg \u003d _(\"Volume type description cannot be greater than 255 \""},{"line_number":115,"context_line":"                    \"characters in length.\")"},{"line_number":116,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        # Name, description and is_public can not be None."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_27f610d9","line":115,"range":{"start_line":102,"start_character":0,"end_line":115,"end_character":44},"in_reply_to":"3fa7e38b_f3bea1d2","updated":"2019-10-11 02:00:36.000000000","message":"yes, volume_type\u0027s description is already validated correctly,but i found we just change  \u0027name_allow_zero_min_length\u0027 to \u0027name\u0027 in https://opendev.org/openstack/cinder/src/branch/master/cinder/api/schemas/volume_types.py#L47 is incorrect, that means we must specify volume type name when update volume type. because it not allow null,so i created update_name, which allow null,and not allow empty string.","commit_id":"21b08c1d1869d52a4e4ccf241e55c93bc48ab538"}]}