)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b6505286168a791756d69978e4a0f44cd830cf6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     mpsairam \u003cpmannidi@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-10-11 15:40:29 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove references to directly editing files in /usr/share/openstack-tripleo-heat-templates"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If users directly edit the files from the RPM, the changes will be removed"},{"line_number":10,"context_line":"on the next update. This can break the existing deployment if they don\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_736043a6","line":7,"updated":"2019-10-11 13:02:44.000000000","message":"Would be good to have the summary line actually be a short summary, within 50 characters, of what this is for.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\nMaybe \"Correct VxFlex Heat instructions\"?","commit_id":"a2ba147a3016e224471da96ae501a20bfd9c41bd"}],"doc/source/configuration/block-storage/drivers/dell-emc-vxflex-driver.rst":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"138b46c669200878b2a5218e39ded5ac965996d6","unresolved":false,"context_lines":[{"line_number":344,"context_line":"------------------------------------------------------"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"When using a containerized overcloud, such as one deployed via TripleO or"},{"line_number":347,"context_line":"Red Hat OpenStack version 12 and above, there is an additional step that must"},{"line_number":348,"context_line":"be performed."},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"Before deploying the overcloud"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_64ff1b01","line":347,"range":{"start_line":347,"start_character":26,"end_line":347,"end_character":28},"updated":"2019-10-11 15:19:01.000000000","message":"Suggest changing this to 13. In OSP-12, cinder did not run in containers. OSP-12 is already EOL, whereas 13 is a long term release.","commit_id":"a2ba147a3016e224471da96ae501a20bfd9c41bd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"138b46c669200878b2a5218e39ded5ac965996d6","unresolved":false,"context_lines":[{"line_number":352,"context_line":""},{"line_number":353,"context_line":"After ensuring that the Storage Data Client (SDC) is installed on all nodes and"},{"line_number":354,"context_line":"before deploying the overcloud, the additional volumes will need to be added to"},{"line_number":355,"context_line":"Cinder and Nova containers. This can be done by creating a file called"},{"line_number":356,"context_line":"scaleio_volumes.yaml with the following content:"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":".. code-block:: yaml"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_697616a7","line":355,"updated":"2019-10-11 15:19:01.000000000","message":"Bear in mind cinder and nova have multiple sub-services (cinder-volume, cinder-api, etc.), each of which runs in its own container. I think it would help if you were explicit about exactly which containers need access to the SDC client. I believe (please correct me if I\u0027m wrong), that\u0027s every service that relies on os-brick. So, cinder-volume and nova-compute are obvious candidates, but what about cinder-backup and glance-api (which uses os-brick when glance is configured to use cinder for its backend)?\n\nI mention this because those other services do not support the XxxOptVolumes parameters that you list on L361 and L364.","commit_id":"a2ba147a3016e224471da96ae501a20bfd9c41bd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"138b46c669200878b2a5218e39ded5ac965996d6","unresolved":false,"context_lines":[{"line_number":359,"context_line":""},{"line_number":360,"context_line":"  parameter_defaults:"},{"line_number":361,"context_line":"    CinderVolumeOptVolumes:"},{"line_number":362,"context_line":"      - /opt/emc/scaleio:/opt/emc/scaleio"},{"line_number":363,"context_line":"      - /bin/emc/scaleio:/bin/emc/scaleio"},{"line_number":364,"context_line":"    NovaComputeOptVolumes:"},{"line_number":365,"context_line":"      - /opt/emc/scaleio:/opt/emc/scaleio"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_8e36f802","line":362,"updated":"2019-10-11 15:19:01.000000000","message":"Suggest appending \":ro\" to make the mounts read-only","commit_id":"a2ba147a3016e224471da96ae501a20bfd9c41bd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"138b46c669200878b2a5218e39ded5ac965996d6","unresolved":false,"context_lines":[{"line_number":376,"context_line":""},{"line_number":377,"context_line":".. code-block:: console"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"  $ openstack overcloud deploy --template \\"},{"line_number":380,"context_line":"    [..]"},{"line_number":381,"context_line":"    -e scaleio_volumes.yaml"},{"line_number":382,"context_line":"    [..]"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_c9270ac7","line":379,"updated":"2019-10-11 15:19:01.000000000","message":"I think a better approach would be to suggest they append the \"-e scaleio_volumes.yaml\" to the list of env files in their overcloud deployment command, rather than trying to show an example of what the command might be.\n\nThe problem with this example is it misses a couple of subtleties. For example the full syntax is \"--templates [TEMPLATES]\". Your example contains a type (\"--tempate\") and makes it look like you cannot specify the [TEMPLATES] optional argument.\n\nAnother subtlety is the order of the env files can be important, so the tripleo community generally recommends appending \"-e\" arguments.","commit_id":"a2ba147a3016e224471da96ae501a20bfd9c41bd"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c71751a378b85a27ce9bab09bdc0fda18d05c553","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":".. code-block:: console"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    openstack overcloud deploy --template [TEMPLATES PATH]\\"},{"line_number":382,"context_line":"    [..]"},{"line_number":383,"context_line":"    -e scaleio_volumes.yaml"},{"line_number":384,"context_line":"    [..]"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_103c4cdf","line":381,"range":{"start_line":381,"start_character":33,"end_line":381,"end_character":41},"updated":"2019-10-14 12:53:38.000000000","message":"nit: \"templates\" (plural)","commit_id":"2292ea1ed267a54ae40628e6dca935bd1b9d846e"}]}