)]}'
{"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"e6f9382fab94b9230a7aad82a41680447f6922ca","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            LOG.exception(_(\"Not able to find a suitable datastore for \""},{"line_number":234,"context_line":"                            \"the volume: %s.\"), volume[\u0027name\u0027])"},{"line_number":235,"context_line":"            raise excep"},{"line_number":236,"context_line":"        LOG.debug(_(\"Verified volume %s can be created.\"), volume[\u0027name\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def create_volume(self, volume):"},{"line_number":239,"context_line":"        \"\"\"Creates a volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2FD7A%3D","line":236,"updated":"2014-02-17 11:35:44.000000000","message":"I think we\u0027re moving away from i18n ing debug logs. Not something which *should* be done, but I\u0027d prefer if you fix it in another patchset if you are submitting it for any reason","commit_id":"02ae642803209ce6b6a6190ba70bdbe3cd8e0534"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"948941e10b3a3100c56382b788a00e077ceead5a","unresolved":false,"context_lines":[{"line_number":233,"context_line":"            LOG.exception(_(\"Not able to find a suitable datastore for \""},{"line_number":234,"context_line":"                            \"the volume: %s.\"), volume[\u0027name\u0027])"},{"line_number":235,"context_line":"            raise excep"},{"line_number":236,"context_line":"        LOG.debug(_(\"Verified volume %s can be created.\"), volume[\u0027name\u0027])"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def create_volume(self, volume):"},{"line_number":239,"context_line":"        \"\"\"Creates a volume."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUX%2F%2B5JA%3D","line":236,"in_reply_to":"AAAAUX%2F%2FD7A%3D","updated":"2014-02-18 11:22:09.000000000","message":"This driver\u0027s code uses _() for all debug logs and there are lots of such statements. If the Cinder community\u0027s decision is to remove them then I think we could do that as part of a separate dedicated clean up patch.","commit_id":"02ae642803209ce6b6a6190ba70bdbe3cd8e0534"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"b1abc09e2f30885cc365f53c189b24fd7657f33c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            # find if any host can accommodate the volume"},{"line_number":231,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(volume)"},{"line_number":232,"context_line":"        except error_util.VimException as excep:"},{"line_number":233,"context_line":"            LOG.exception(_(\"Not able to find a suitable datastore for \""},{"line_number":234,"context_line":"                            \"the volume: %s.\"), volume[\u0027name\u0027])"},{"line_number":235,"context_line":"            raise excep"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2FwTc%3D","line":232,"updated":"2014-02-24 23:14:55.000000000","message":"Can we change this to raise a VolumeBackendException please?\n\nThe manager and calling code won\u0027t know what to do with the VimException and shouldn\u0027t necessarily care.","commit_id":"21f1933f1916afe86c2a60a6a314924508411958"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"c42beb7d6fbc8275156b457d6cd93e89a4dda64c","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            # find if any host can accommodate the volume"},{"line_number":231,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(volume)"},{"line_number":232,"context_line":"        except error_util.VimException as excep:"},{"line_number":233,"context_line":"            LOG.exception(_(\"Not able to find a suitable datastore for \""},{"line_number":234,"context_line":"                            \"the volume: %s.\"), volume[\u0027name\u0027])"},{"line_number":235,"context_line":"            raise excep"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAU3%2F%2FuAc%3D","line":232,"in_reply_to":"AAAAU3%2F%2FwTc%3D","updated":"2014-02-25 04:17:45.000000000","message":"Thanks for noticing this. I shall raise a VimFaultException - which derives from VolumeBackendAPIException - here.","commit_id":"21f1933f1916afe86c2a60a6a314924508411958"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e27588d562878f2011a367ca470bcce7f499c46e","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            # find if any host can accommodate the volume"},{"line_number":231,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(volume)"},{"line_number":232,"context_line":"        except error_util.VimException as excep:"},{"line_number":233,"context_line":"            msg \u003d _(\"Not able to find a suitable datastore for the volume: \""},{"line_number":234,"context_line":"                    \"%s.\") % volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2FtmM%3D","line":231,"updated":"2014-02-25 05:36:54.000000000","message":"host, rp, folder, summary aren\u0027t used.","commit_id":"29b6151f697a315deb358aafa2aa565fd112cae9"},{"author":{"_account_id":7948,"name":"Subbu","email":"subramanian.neelakantan@gmail.com","username":"subbu"},"change_message_id":"50d8c4011eee631ba53660c5bcdecabe257de061","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":"        try:"},{"line_number":230,"context_line":"            # find if any host can accommodate the volume"},{"line_number":231,"context_line":"            (host, rp, folder, summary) \u003d self._select_ds_for_volume(volume)"},{"line_number":232,"context_line":"        except error_util.VimException as excep:"},{"line_number":233,"context_line":"            msg \u003d _(\"Not able to find a suitable datastore for the volume: \""},{"line_number":234,"context_line":"                    \"%s.\") % volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAU3%2F%2Ftgs%3D","line":231,"in_reply_to":"AAAAU3%2F%2FtmM%3D","updated":"2014-02-25 06:23:22.000000000","message":"Done","commit_id":"29b6151f697a315deb358aafa2aa565fd112cae9"}]}
