)]}'
{"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3ccc44e23e8cddb31f3b14ee8bb9b2ca41129887","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            driver \u003d self._client_conf[\u0027volume_driver\u0027]"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"            if \u0027HPE3PARISCSIDriver\u0027 in driver:"},{"line_number":484,"context_line":"                s \u003d re.search(\u0027:443\u0027, backend_url)"},{"line_number":485,"context_line":"                if s:"},{"line_number":486,"context_line":"                    LOG.error(\"For Primera, only FC is supported. \""},{"line_number":487,"context_line":"                              \"iSCSI cannot be used.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_6e510e30","line":484,"updated":"2019-11-01 13:50:04.000000000","message":"Two things:\n\n1 - it might be safer to use urlparse to get the port, because hopefully they\u0027ve thought of all the edge cases to make sure that you get the port and only the port.  (For example, you are going to get a match on \"http://what:4433/yeah\", even though the port is not 443)\n\n2 - are you guaranteed that only Primera will use port 443 (and Primera will *always* use port 443)? This isn\u0027t configurable on the backend side?  I wonder if there is a better way to figure out what kind of backend you\u0027ve connected to.","commit_id":"f5b64ddc56b7aba40d46650f26536e9e1ab7d570"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"348c1bf272dfdd746f45de971fc7434894e13864","unresolved":false,"context_lines":[{"line_number":484,"context_line":"                if is_primera:"},{"line_number":485,"context_line":"                    LOG.error(\"For Primera, only FC is supported. \""},{"line_number":486,"context_line":"                              \"iSCSI cannot be used.\")"},{"line_number":487,"context_line":"                    raise NotImplementedError()"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"            wsapi_version \u003d self.client.getWsApiVersion()"},{"line_number":490,"context_line":"            self.API_VERSION \u003d wsapi_version[\u0027build\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9e69f48c","line":487,"updated":"2019-11-05 13:14:50.000000000","message":"This seems to make sense to live in the iscsi driver, not common.","commit_id":"c3efafbf9755199b158f1448a5e6788896ffda00"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"849ed0f7a950cfd73e3510f0a0da3836499d150d","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        if is_primera:"},{"line_number":147,"context_line":"            LOG.error(\"For Primera, only FC is supported. \""},{"line_number":148,"context_line":"                      \"iSCSI cannot be used\")"},{"line_number":149,"context_line":"            raise NotImplementedError()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        self.iscsi_ips \u003d {}"},{"line_number":152,"context_line":"        common.client_login()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9384430d","line":149,"updated":"2019-11-12 14:39:52.000000000","message":"I wasn\u0027t sure about this being the appropriate exception, but looks like hpe_3par_base calls this method inside its do_setup() call. cinder/volume/manager.py calls do_setup inside of _init_host() and catches any raised exception, which will log an exception that the driver could not be initialized and return. That will result in self.driver.initialized never being set to true, which unfortunately will cause retries in the initialization, but no way around that and not much harm really.","commit_id":"25a32168a0f280ff4355baf18917289c76f64e45"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"523aab2bf04e95dab768277dd32fad5eb0baf9b0","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        if is_primera:"},{"line_number":147,"context_line":"            LOG.error(\"For Primera, only FC is supported. \""},{"line_number":148,"context_line":"                      \"iSCSI cannot be used\")"},{"line_number":149,"context_line":"            raise NotImplementedError()"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        self.iscsi_ips \u003d {}"},{"line_number":152,"context_line":"        common.client_login()"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_5aeebeed","line":149,"in_reply_to":"3fa7e38b_9384430d","updated":"2019-11-14 09:33:17.000000000","message":"I agree with Sean, it\u0027s not great, and I think we need some kind of unrecoverable error mechanism that allows Cinder to exit, but that\u0027s definitely out of the scope of this patch.","commit_id":"25a32168a0f280ff4355baf18917289c76f64e45"}]}