)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e64f24bfdb4f322da02444f7cea2c1e8f972a673","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove unnecessary saving of host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing backup creation, we already use method"},{"line_number":10,"context_line":"`_get_available_backup_service_host` to select and save the host;"},{"line_number":11,"context_line":"and in restoring or deleting operation, the host of backup will"},{"line_number":12,"context_line":"never be modified. So it\u0027s safe to remove them."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_6106941f","line":10,"updated":"2019-11-12 12:59:34.000000000","message":"nit: mention that this is done by the API service","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"7fa319afaf729f65456ce6eeb122188ceae4b0b7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove unnecessary saving of host"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When doing backup creation, we already use method"},{"line_number":10,"context_line":"`_get_available_backup_service_host` to select and save the host;"},{"line_number":11,"context_line":"and in restoring or deleting operation, the host of backup will"},{"line_number":12,"context_line":"never be modified. So it\u0027s safe to remove them."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_c42d0c90","line":10,"in_reply_to":"3fa7e38b_6106941f","updated":"2019-11-13 05:53:58.000000000","message":"Done","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e64f24bfdb4f322da02444f7cea2c1e8f972a673","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When doing backup creation, we already use method"},{"line_number":10,"context_line":"`_get_available_backup_service_host` to select and save the host;"},{"line_number":11,"context_line":"and in restoring or deleting operation, the host of backup will"},{"line_number":12,"context_line":"never be modified. So it\u0027s safe to remove them."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If6dc705db18e138ed13fe3e9a5eecd366c33fe89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_611f745b","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":46},"updated":"2019-11-12 12:59:34.000000000","message":"nit: \"to remove them from the manager code, since we are not actually changing the contents. This removes an unnecessary DB request in backup create, restore, and delete operations.\"","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"7fa319afaf729f65456ce6eeb122188ceae4b0b7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When doing backup creation, we already use method"},{"line_number":10,"context_line":"`_get_available_backup_service_host` to select and save the host;"},{"line_number":11,"context_line":"and in restoring or deleting operation, the host of backup will"},{"line_number":12,"context_line":"never be modified. So it\u0027s safe to remove them."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: If6dc705db18e138ed13fe3e9a5eecd366c33fe89"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a42b3093","line":12,"range":{"start_line":12,"start_character":32,"end_line":12,"end_character":46},"in_reply_to":"3fa7e38b_611f745b","updated":"2019-11-13 05:53:58.000000000","message":"Done\nThank you for improving my English expression skills.","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"}],"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e64f24bfdb4f322da02444f7cea2c1e8f972a673","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self._notify_about_backup_usage(context, backup, \"create.start\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":362,"context_line":"        backup.save()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        expected_status \u003d \"backing-up\""},{"line_number":365,"context_line":"        if snapshot_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a1980ccc","line":362,"range":{"start_line":361,"start_character":0,"end_line":362,"end_character":21},"updated":"2019-11-12 12:59:34.000000000","message":"-1: I believe this is also unnecessary, we have it also in the create API method:\n\n        availability_zone \u003d availability_zone or volume.availability_zone\n        host \u003d self._get_available_backup_service_host(volume_host,\n                                                       availability_zone)","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"7fa319afaf729f65456ce6eeb122188ceae4b0b7","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        self._notify_about_backup_usage(context, backup, \"create.start\")"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        backup.availability_zone \u003d self.az"},{"line_number":362,"context_line":"        backup.save()"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"        expected_status \u003d \"backing-up\""},{"line_number":365,"context_line":"        if snapshot_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e42128b7","line":362,"range":{"start_line":361,"start_character":0,"end_line":362,"end_character":21},"in_reply_to":"3fa7e38b_a1980ccc","updated":"2019-11-13 05:53:58.000000000","message":"Done\nYes, you are right!","commit_id":"55fac6ddab705c7aa9c479a7c2261105017b6099"}]}