)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6d612268f766deeba10d8f2da4f15dcdcb2a8f3e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yang Youseok \u003cileixe@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-12-02 10:29:56 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix KeyError exception when volume filter file does not exist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since current code assume that resource key is existed, exception"},{"line_number":10,"context_line":"happens when filter file does not initialized. Return empty list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_144f996a","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":12},"updated":"2019-12-30 09:34:02.000000000","message":"Please report a bug with the associated traceback of where this error is happening","commit_id":"29f6bf84192327f980cb89dd3450d74e9ac84d5d"}],"cinder/api/common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6d612268f766deeba10d8f2da4f15dcdcb2a8f3e","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            return {resource: _FILTERS_COLLECTION[resource]}"},{"line_number":384,"context_line":"    except Exception:"},{"line_number":385,"context_line":"        LOG.debug(\"Failed to collect resource %s\u0027s filters.\", resource)"},{"line_number":386,"context_line":"        return {resource: []}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def convert_filter_attributes(filters, resource):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d406e11b","line":386,"range":{"start_line":386,"start_character":16,"end_line":386,"end_character":28},"updated":"2019-12-30 09:34:02.000000000","message":"It is anyway being set the same in L#422\nCould you explain if there is any additional benefit for this change?","commit_id":"29f6bf84192327f980cb89dd3450d74e9ac84d5d"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"e93442e7c13772c311d7305a3c6532b2d3dd211a","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            return {resource: _FILTERS_COLLECTION[resource]}"},{"line_number":384,"context_line":"    except Exception:"},{"line_number":385,"context_line":"        LOG.debug(\"Failed to collect resource %s\u0027s filters.\", resource)"},{"line_number":386,"context_line":"        return {resource: []}"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"def convert_filter_attributes(filters, resource):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_345c1519","line":386,"range":{"start_line":386,"start_character":16,"end_line":386,"end_character":28},"in_reply_to":"3fa7e38b_d406e11b","updated":"2019-12-30 09:48:33.000000000","message":"KeyError occurs at cinder/api/v2/volumes.py _get_volume_filter_options() when filter json file does not existed.\n\nAfter your comments, I realized the function is to be fixed, rather than this spot since unconditional key access is absurd.","commit_id":"29f6bf84192327f980cb89dd3450d74e9ac84d5d"}]}