)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"221e52864b67f2032d42694bb7b73b224d912536","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        if storage_group:"},{"line_number":924,"context_line":"            try:"},{"line_number":925,"context_line":"                tag_list \u003d storage_group[\u0027tags\u0027]"},{"line_number":926,"context_line":"            except Exception:"},{"line_number":927,"context_line":"                pass"},{"line_number":928,"context_line":"        return tag_list"},{"line_number":929,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_5c13615a","line":926,"updated":"2020-01-14 17:25:06.000000000","message":"I can see catching Exception at line 921 because you\u0027re going out on the network and anything could happen.  Are you worried about a KeyError here from line 925?  If so, you could use storage_group.get(\u0027tags\u0027) instead.  Or is it possible that storage_group could be not None but also not be a dict?  (I\u0027m just kind of wary of overbroad except clauses.)","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9eaf78471cb4dae2db34b1245bbe07dbf2a32c81","unresolved":false,"context_lines":[{"line_number":923,"context_line":"        if storage_group:"},{"line_number":924,"context_line":"            try:"},{"line_number":925,"context_line":"                tag_list \u003d storage_group[\u0027tags\u0027]"},{"line_number":926,"context_line":"            except Exception:"},{"line_number":927,"context_line":"                pass"},{"line_number":928,"context_line":"        return tag_list"},{"line_number":929,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_94419e39","line":926,"in_reply_to":"3fa7e38b_5c13615a","updated":"2020-01-15 13:57:51.000000000","message":"Yes, good point, I will change it","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"221e52864b67f2032d42694bb7b73b224d912536","unresolved":false,"context_lines":[{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":2077,"context_line":"        :raises: VolumeBackendAPIException:"},{"line_number":2078,"context_line":"        \"\"\""},{"line_number":2079,"context_line":"        tag_list \u003d None"},{"line_number":2080,"context_line":"        try:"},{"line_number":2081,"context_line":"            tag_list \u003d extra_specs.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_bc6935c1","line":2078,"updated":"2020-01-14 17:25:06.000000000","message":"This is more of a taste thing, so I don\u0027t insist, but you could start with\n\n  tag_list \u003d e_s.get(utils.STORAGE_GROUP_TAGS)\n\nwhich would either give you the string or None, and then\n\n  if tag_list:\n    pass tag_list.split() as the arg to verify_tag_list\n\nthis would leave tag_list as a string when you log it at line 2097, and you wouldn\u0027t need the try/except block at lines 2080-2084","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9eaf78471cb4dae2db34b1245bbe07dbf2a32c81","unresolved":false,"context_lines":[{"line_number":2075,"context_line":""},{"line_number":2076,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":2077,"context_line":"        :raises: VolumeBackendAPIException:"},{"line_number":2078,"context_line":"        \"\"\""},{"line_number":2079,"context_line":"        tag_list \u003d None"},{"line_number":2080,"context_line":"        try:"},{"line_number":2081,"context_line":"            tag_list \u003d extra_specs.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_efafdf9a","line":2078,"in_reply_to":"3fa7e38b_bc6935c1","updated":"2020-01-15 13:57:51.000000000","message":"Sure.  I will change it.","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"221e52864b67f2032d42694bb7b73b224d912536","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    extra_specs[utils.STORAGE_GROUP_TAGS],"},{"line_number":439,"context_line":"                    storage_group[\u0027tags\u0027])"},{"line_number":440,"context_line":"                if not new_tag_list:"},{"line_number":441,"context_line":"                    LOG.warning(\"No new tags to add. Existing tags \""},{"line_number":442,"context_line":"                                \"associated with %(sg_name)s are \""},{"line_number":443,"context_line":"                                \"%(tags)s.\","},{"line_number":444,"context_line":"                                {\u0027sg_name\u0027: storage_group[\u0027storageGroupId\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_3c4ea539","line":441,"range":{"start_line":441,"start_character":24,"end_line":441,"end_character":31},"updated":"2020-01-14 17:25:06.000000000","message":"is this more like info, or is it really a warning?","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9eaf78471cb4dae2db34b1245bbe07dbf2a32c81","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                    extra_specs[utils.STORAGE_GROUP_TAGS],"},{"line_number":439,"context_line":"                    storage_group[\u0027tags\u0027])"},{"line_number":440,"context_line":"                if not new_tag_list:"},{"line_number":441,"context_line":"                    LOG.warning(\"No new tags to add. Existing tags \""},{"line_number":442,"context_line":"                                \"associated with %(sg_name)s are \""},{"line_number":443,"context_line":"                                \"%(tags)s.\","},{"line_number":444,"context_line":"                                {\u0027sg_name\u0027: storage_group[\u0027storageGroupId\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_afc9e77a","line":441,"range":{"start_line":441,"start_character":24,"end_line":441,"end_character":31},"in_reply_to":"3fa7e38b_3c4ea539","updated":"2020-01-15 13:57:51.000000000","message":"Yes.  Agreed","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"}],"releasenotes/notes/powermax-storage-group-tagging-d2281e9b35994bec.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"221e52864b67f2032d42694bb7b73b224d912536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_fccc8d97","line":7,"updated":"2020-01-14 17:25:06.000000000","message":"This is going to show up in a long list like this:\nhttps://docs.openstack.org/releasenotes/cinder/train.html#new-features\n\nYou don\u0027t have any control over the ordering, so I suggest rewriting the note to read something like this:\n\n  Dell EMC PowerMax driver: Added support for Unisphere\n  storage group and array tagging to allow ...\n\nThat will make it easier for operators using your driver to notice the new feature.","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9eaf78471cb4dae2db34b1245bbe07dbf2a32c81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3fa7e38b_6fc3ef59","line":7,"in_reply_to":"3fa7e38b_fccc8d97","updated":"2020-01-15 13:57:51.000000000","message":"Sure.  I will change this.  We will keep this convention for all release notes for PowerMax","commit_id":"ad5d1a743d285fe0306f018e424ae472f0c25901"}]}